Issue Details (XML | Word | Printable)

Key: MDL-16143
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Duplicate
Priority: Major Major
Assignee: Dongsheng Cai
Reporter: Urs Hunkler
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-12098

In a popup window there is one closing div too much

Created: 20/Aug/08 09:40 PM   Updated: 03/Mar/09 05:47 PM
Return to search
Component/s: Resource
Affects Version/s: 1.9.2, 2.0
Fix Version/s: None

Issue Links:
Duplicate
 

Participants: Dongsheng Cai, Tim Hunt and Urs Hunkler
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 18/Feb/09
Affected Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
In a popup window there is one closing div too much. The div added to correct MDL-12098 is now breaking the page.

Patch:

Index: resource.class.php
===================================================================
RCS file: /cvsroot/moodle/moodle/mod/resource/type/file/resource.class.php,v
retrieving revision 1.71.2.12
diff -u -r1.71.2.12 resource.class.php
--- resource.class.php 10 Jul 2008 09:48:47 -0000 1.71.2.12
+++ resource.class.php 20 Aug 2008 13:37:04 -0000
@@ -619,7 +619,6 @@
 
             if ($inpopup) {
                 echo "<div class=\"popupnotice\">(<a href=\"$fullurl\">$strdirectlink</a>)</div>";
- echo "</div>"; // MDL-12098
                 print_footer($course); // MDL-12098
             } else {
                 print_spacer(20,20);



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dongsheng Cai added a comment - 18/Feb/09 05:07 PM
Duplicate with MDL-17697

Tim Hunt added a comment - 03/Mar/09 05:21 PM
The commit for this bug got linked to MDL-17696 by mistake.

Tim Hunt added a comment - 03/Mar/09 05:47 PM
Closing. It is, indeed, a duplicate.