Moodle

In a popup window there is one closing div too much

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 1.9.2, 2.0
  • Fix Version/s: None
  • Component/s: Resource
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

In a popup window there is one closing div too much. The div added to correct MDL-12098 is now breaking the page.

Patch:

Index: resource.class.php
===================================================================
RCS file: /cvsroot/moodle/moodle/mod/resource/type/file/resource.class.php,v
retrieving revision 1.71.2.12
diff -u -r1.71.2.12 resource.class.php
— resource.class.php 10 Jul 2008 09:48:47 -0000 1.71.2.12
+++ resource.class.php 20 Aug 2008 13:37:04 -0000
@@ -619,7 +619,6 @@

if ($inpopup) { echo "<div class=\"popupnotice\">(<a href=\"$fullurl\">$strdirectlink</a>)</div>"; - echo "</div>"; // MDL-12098 print_footer($course); // MDL-12098 } else {
print_spacer(20,20);

Issue Links

Activity

Hide
Dongsheng Cai added a comment -

Duplicate with MDL-17697

Show
Dongsheng Cai added a comment - Duplicate with MDL-17697
Hide
Tim Hunt added a comment -

The commit for this bug got linked to MDL-17696 by mistake.

Show
Tim Hunt added a comment - The commit for this bug got linked to MDL-17696 by mistake.
Hide
Tim Hunt added a comment -

Closing. It is, indeed, a duplicate.

Show
Tim Hunt added a comment - Closing. It is, indeed, a duplicate.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: