Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Won't Fix
-
Affects Version/s: 1.8.6, 1.9, 1.9.1, 1.9.2
-
Fix Version/s: None
-
Component/s: Resource
-
Labels:None
-
Environment:Moodle 1.8.6 (Build: 20080730)
-
Affected Branches:MOODLE_18_STABLE, MOODLE_19_STABLE
Description
The frametarget() added to /lib/weblib.php in http://cvs.moodle.org/moodle/lib/weblib.php?r1=1.735&r2=1.736 silently drops any use of _top as a frame target, as per http://tracker.moodle.org/browse/MDL-8050 .
To reproduce:
1. Create an activity, e.g. a forum
2. Create an HTML file including the text of the above resource
3. Upload the HTML file and link it as a file resource, opening in same window with navigation visible
4. Ensure activity autolinking is enabled
5. View the HTML resource
6. Click on the autolink
Expected result:
Activity loads with one set of navigation.
Actual result:
Activity loads with two sets of navigation, as it has loaded the activity with it's own navigation into the existing content frame.
I don't know how determined the plan to move to XHTML strict is, but until all the file resources are loaded into iframes, the target attribute should be kept functional.
Patch to allow frametarget() to return target="_top" attached.
Attachments
Issue Links
| This issue has been marked as being related by: | ||||
| MDL-20327 | Links in framed resource header don't load in _top if javascript is disabled. |
|
|
|
Thanks for reporting this issue.
We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.
If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.
Michael d;
lqjjLKA0p6