Issue Details (XML | Word | Printable)

Key: MDL-16164
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Petr Skoda
Reporter: Petr Skoda
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

use of formslib is notes edit/add code is incorrect

Created: 22/Aug/08 04:49 AM   Updated: 22/Aug/08 05:42 AM
Return to search
Component/s: Administration
Affects Version/s: 1.9
Fix Version/s: 2.0

Participants: Petr Skoda
Security Level: None
Resolved date: 22/Aug/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
the correct way is:
* create form
* set defaults
* check if submitted
* display if not

different order is NOT supported!

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Petr Skoda made changes - 22/Aug/08 04:49 AM
Field Original Value New Value
Priority Minor [ 4 ] Major [ 3 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 22/Aug/08 04:52 AM - edited
found also incorrect use of ->get_submitted_data();

Petr Skoda made changes - 22/Aug/08 05:33 AM
Summary use of formslib is notes edit code is incorrect use of formslib is notes edit/add code is incorrect
Petr Skoda committed 6 files to 'Moodle CVS' - 22/Aug/08 05:40 AM
MDL-16164 improved use of forms in notes code and some other minor cleanup
MODIFY notes/index.php   Rev. 1.12    (+3 -3 lines)
MODIFY notes/lib.php   Rev. 1.11    (+13 -13 lines)
MODIFY notes/edit.php   Rev. 1.12    (+28 -30 lines)
DEL notes/Attic/add.php   Rev. 1.12    (+0 -0 lines)
MODIFY notes/edit_form.php   Rev. 1.7    (+5 -5 lines)
MODIFY notes/delete.php   Rev. 1.10    (+6 -5 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 22/Aug/08 05:40 AM
done

Petr Skoda made changes - 22/Aug/08 05:40 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators