Issue Details (XML | Word | Printable)

Key: MDL-16188
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Eloy Lafuente (stronk7)
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Prevent PHP notices at install time because $CFG->release is undefined

Created: 25/Aug/08 12:18 AM   Updated: 26/Aug/08 04:00 PM
Return to search
Component/s: Installation
Affects Version/s: 1.8.6, 1.9.2
Fix Version/s: 1.8.7, 1.9.3

Participants: Eloy Lafuente (stronk7) and Tim Hunt
Security Level: None
QA Assignee: Tim Hunt
Resolved date: 25/Aug/08
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
At install time, when environmental tests are executed, they use the $CFG->release value to change custom checks behaviour. That variable isn't defined at install time and causes PHP notices.

Prevent them.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 25/Aug/08 12:30 AM
Prevent some notices at install. MDL-16188
MODIFY lib/environmentlib.php   Rev. 1.20.2.5    (+3 -2 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 25/Aug/08 12:31 AM
Prevent some notices at install. MDL-16188 ; merged from 18_STABLE
MODIFY lib/environmentlib.php   Rev. 1.27.2.3    (+4 -3 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 25/Aug/08 12:33 AM
Prevent some notices at install. MDL-16188 ; merged from 19_STABLE
MODIFY lib/environmentlib.php   Rev. 1.32    (+4 -3 lines)
Eloy Lafuente (stronk7) committed 1 file to 'Moodle CVS' - 25/Aug/08 12:39 AM
Remove hack not needed anymore. Now enviroment check handles this properly. MDL-16008 & MDL-16188
MODIFY install.php   Rev. 1.108    (+1 -2 lines)
Eloy Lafuente (stronk7) added a comment - 25/Aug/08 12:54 AM
Done in 18_STABLE, 19_STABLE and HEAD. Also removed hack used to fix this in installer (MDL-16008).

Ciao


Eloy Lafuente (stronk7) made changes - 25/Aug/08 12:54 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Tim Hunt added a comment - 26/Aug/08 04:00 PM
Looks (and tests) good to me.

Tim Hunt made changes - 26/Aug/08 04:00 PM
QA Assignee timhunt
Status Resolved [ 5 ] Closed [ 6 ]