Moodle

mod/quiz/reviewquestion.php does not call questiontype::get_html_head_contributions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.3
  • Component/s: Questions
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Causes problems like, for example, issue 2. in http://moodle.org/mod/forum/discuss.php?d=102690#p459958.

Issue Links

Activity

Hide
Tim Hunt added a comment -

This was missed when implementing MDL-6368.

Show
Tim Hunt added a comment - This was missed when implementing MDL-6368.
Hide
Tim Hunt added a comment -

Fixed. Thanks to Süreç Özcan for spotting this problem.

Show
Tim Hunt added a comment - Fixed. Thanks to Süreç Özcan for spotting this problem.
Hide
Pierre Pichet added a comment -

get this message on HEAD CVS attemplib.php 1.15
Fatal error: Only variables can be passed by reference in C:\moodle\moodle\site\moodle_head\mod\quiz\attemptlib.php on line 624

Show
Pierre Pichet added a comment - get this message on HEAD CVS attemplib.php 1.15 Fatal error: Only variables can be passed by reference in C:\moodle\moodle\site\moodle_head\mod\quiz\attemptlib.php on line 624
Hide
Pierre Pichet added a comment -

and reviewquestion.php 1.29

Show
Pierre Pichet added a comment - and reviewquestion.php 1.29
Hide
Tim Hunt added a comment -

Yes, sorry about that. I forgot the commit the change to questionlib.php, becuase I was in the middle of another change to the file, and had to untangle the two sets of changes. Problem sorted now.

Show
Tim Hunt added a comment - Yes, sorry about that. I forgot the commit the change to questionlib.php, becuase I was in the middle of another change to the file, and had to untangle the two sets of changes. Problem sorted now.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: