Issue Details (XML | Word | Printable)

Key: MDL-16263
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

A way for students to flag/bookmark, particular questions during a quiz attempt for later review

Created: 29/Aug/08 10:15 AM   Updated: 03/Sep/08 04:33 PM
Return to search
Component/s: Questions, Quiz
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Ray Lawrence and Tim Hunt
Security Level: None
Resolved date: 03/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
We want students to be able to mark certain questions as they are doing them for whatever purpose, for example:
* because they want to go back and check their answer before submitting the quiz.
* because the results will only be released later, and they particularly want to remember to check whether they got this question right.
* because they want to ask their friend or teacher something relating to that question later.

Design document at http://docs.moodle.org/en/Development:Flagging_questions_during_a_quiz_attempt.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Ray Lawrence added a comment - 29/Aug/08 04:49 PM
Trying to visualise the interface where a quiz has the timer running. The timer position is already considered problematic in many quarters. In addition to being an annoyance will it now potentially obscure the flagging option?

tjhunt committed 18 files to 'Moodle CVS' - 29/Aug/08 06:08 PM
MDL-16263 A way for students to flag/bookmark, particular questions during a quiz attempt for later review.

This is an initial implementation that is now at a working state, but with a few things left to do. It seemed like a good idea to commit it before leaving work on Friday night.
MODIFY lib/db/install.xml   Rev. 1.169    (+2 -1 lines)
MODIFY lib/questionlib.php   Rev. 1.157    (+77 -7 lines)
MODIFY lang/en_utf8/question.php   Rev. 1.24    (+5 -0 lines)
MODIFY mod/quiz/lib.php   Rev. 1.315    (+2 -1 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.601    (+9 -0 lines)
MODIFY question/type/question.html   Rev. 1.19    (+2 -1 lines)
MODIFY version.php   Rev. 1.786    (+1 -1 lines)
MODIFY pix/i/unflagged.png   Rev. 1.1    (+0 -0 lines)
ADD question/toggleflag.php   Rev. 1.1    (+0 -0 lines)
MODIFY pix/i/flagged.png   Rev. 1.1    (+0 -0 lines)
MODIFY lang/en_utf8/role.php   Rev. 1.64    (+2 -1 lines)
MODIFY mod/quiz/locallib.php   Rev. 1.157    (+34 -8 lines)
MODIFY lib/db/upgrade.php   Rev. 1.233    (+17 -1 lines)
MODIFY question/preview.php   Rev. 1.31    (+6 -3 lines)
MODIFY question/type/questiontype.php   Rev. 1.98    (+64 -2 lines)
MODIFY mod/quiz/attemptlib.php   Rev. 1.17    (+27 -9 lines)
ADD question/qengine.js   Rev. 1.1    (+0 -0 lines)
MODIFY lib/db/access.php   Rev. 1.90    (+14 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 29/Aug/08 06:18 PM
MDL-16263 - followup - fix regression.
MODIFY mod/quiz/attemptlib.php   Rev. 1.18    (+1 -1 lines)
Tim Hunt added a comment - 29/Aug/08 06:45 PM
A better place to discuss is in http://moodle.org/mod/forum/discuss.php?d=104487, so I'll respond there, if that is OK?

tjhunt committed 2 files to 'Moodle CVS' - 29/Aug/08 07:30 PM
MDL-16263 - followup - fix notices.
MODIFY mod/quiz/report/overview/report.php   Rev. 1.157    (+2 -1 lines)
MODIFY mod/quiz/report/responses/report.php   Rev. 1.19    (+2 -1 lines)
tjhunt committed 2 files to 'Moodle CVS' - 29/Aug/08 07:40 PM
MDL-16263 - next bit. Flags on the quiz summary page.
MODIFY theme/standard/styles_layout.css   Rev. 1.602    (+5 -1 lines)
MODIFY mod/quiz/summary.php   Rev. 1.6    (+6 -1 lines)
tjhunt committed 2 files to 'Moodle CVS' - 29/Aug/08 08:22 PM
MDL-16263 - next bit. And display flagged questions in the navigation panel.
MODIFY theme/standard/styles_layout.css   Rev. 1.603    (+5 -0 lines)
MODIFY theme/standard/pix/Attic/flaggedquestionnav.png   Rev. 1.1    (+0 -0 lines)
Mitsuhiro Yoshida committed 9 files to 'Lang CVS' - 30/Aug/08 09:42 PM
MDL-13766 - Translated a new string for repository.
MDL-16267 - Updated a translated string for messaging.
MDL-16267 - Adding three new translated lang files for message processor.
MDL-15362 - Addding a translated lang file for Mahara portfolio plugin.
MDL-16263 - Translated new strings for question and role.
MODIFY ja_utf8/repository.php   Rev. 1.10    (+2 -1 lines)
ADD ja_utf8/portfolio_mahara.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/role.php   Rev. 1.70    (+9 -8 lines)
MODIFY ja_utf8/question.php   Rev. 1.26    (+6 -1 lines)
MODIFY ja_utf8/README   Rev. 1.799    (+1 -1 lines)
ADD ja_utf8/messageprocessor_email.php   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/messageprocessor_popup.php   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/messageprocessor_jabber.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/message.php   Rev. 1.19    (+3 -2 lines)
tjhunt committed 3 files to 'Moodle CVS' - 03/Sep/08 10:35 AM
MDL-16263 Flagging questions during a quiz attempt. Update flag state in the navigtion panel when it is updated on the question.
MODIFY question/qengine.js   Rev. 1.2    (+27 -1 lines)
MODIFY mod/quiz/attemptlib.php   Rev. 1.20    (+21 -8 lines)
MODIFY mod/quiz/quiz.js   Rev. 1.9    (+20 -0 lines)
tjhunt committed 1 file to 'Moodle CVS' - 03/Sep/08 01:37 PM
MDL-16263 Flagging questions during a quiz attempt. IE cannot cope with an object initialiser with a trailing comma, so change how thise JS is output.
MODIFY lib/questionlib.php   Rev. 1.160    (+6 -4 lines)
tjhunt committed 1 file to 'Moodle CVS' - 03/Sep/08 01:38 PM
MDL-16263 Flagging questions during a quiz attempt. Flag updating in nav not working on the review page.
MODIFY mod/quiz/review.php   Rev. 1.78    (+2 -1 lines)
tjhunt committed 3 files to 'Moodle CVS' - 03/Sep/08 01:50 PM
MDL-16263 Flagging questions during a quiz attempt. Make it work nicely with just the keyboard, no mouse, if JavaScript is on.
MODIFY theme/standard/styles_layout.css   Rev. 1.604    (+0 -4 lines)
MODIFY question/qengine.js   Rev. 1.3    (+37 -25 lines)
MODIFY question/type/questiontype.php   Rev. 1.99    (+2 -2 lines)
tjhunt committed 2 files to 'Moodle CVS' - 03/Sep/08 03:11 PM
MDL-16263 Flagging questions during a quiz attempt. Save flag state on submit when JS is off.
MODIFY lib/questionlib.php   Rev. 1.161    (+22 -7 lines)
MODIFY question/qengine.js   Rev. 1.4    (+24 -19 lines)
tjhunt committed 5 files to 'Moodle CVS' - 03/Sep/08 04:32 PM
MDL-16263 Flagging questions during a quiz attempt. Save flag state on the review page when JS is off too.
MODIFY lang/en_utf8/question.php   Rev. 1.25    (+1 -0 lines)
MODIFY question/qengine.js   Rev. 1.5    (+6 -0 lines)
MODIFY lib/questionlib.php   Rev. 1.162    (+51 -8 lines)
MODIFY mod/quiz/review.php   Rev. 1.79    (+31 -3 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.605    (+1 -0 lines)
Tim Hunt added a comment - 03/Sep/08 04:33 PM
I think this is now done!

If you test it and find any bugs, please file them as new issues, that would be more convenient for me. Thanks.


Tim Hunt made changes - 03/Sep/08 04:33 PM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
tjhunt committed 1 file to 'Moodle CVS' - 03/Sep/08 05:37 PM
MDL-16263 Flagging questions during a quiz attempt. Submit all and finish was nuking flag states. Fix that.
MODIFY mod/quiz/processattempt.php   Rev. 1.6    (+4 -3 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 04/Sep/08 12:52 AM
MDL-16263 - Translated a new string for question flagging.
MDL-13766, MDL-15402 - Translated new strings for repository.
MODIFY ja_utf8/question.php   Rev. 1.27    (+2 -1 lines)
MODIFY ja_utf8/repository.php   Rev. 1.14    (+4 -0 lines)
MODIFY ja_utf8/README   Rev. 1.803    (+1 -1 lines)
tjhunt committed 1 file to 'Moodle CVS' - 04/Sep/08 12:52 PM
MDL-16263 Improve comment.
MODIFY mod/quiz/quiz.js   Rev. 1.10    (+2 -2 lines)
martignoni committed 2 files to 'Lang CVS' - 05/Sep/08 06:40 PM
MDL-16263 strings added
MODIFY fr_utf8/role.php   Rev. 1.85    (+2 -1 lines)
MODIFY fr_utf8/question.php   Rev. 1.33    (+6 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 08/Sep/08 03:30 AM
MDL-16263 New string
MODIFY fr_utf8/question.php   Rev. 1.34    (+2 -1 lines)
tjhunt committed 6 files to 'Moodle CVS' - 10/Sep/08 10:45 AM
tjhunt committed 1 file to 'Moodle CVS' - 10/Sep/08 10:58 AM
MDL-16429 Notice when previewing questions since MDL-16263 was implemented.
MODIFY question/preview.php   Rev. 1.34    (+2 -3 lines)
tjhunt committed 7 files to 'Moodle CVS' - 18/Sep/08 03:39 PM
MDL-16334 Convert mod/quiz/comment.php to use attemptlib.php - final part of the work on the quiz navigtion, I hope.
MDL-16559 Remove question/comment.html template, and instead just have a function in questionlib.php
MDL-16562 Regression from MDL-16263, notices when regrading.
Sorry, the three got tangled together (coupled through questionlib) while I was fixing bugs in preparation for a demo.
MODIFY mod/quiz/attemptlib.php   Rev. 1.27    (+36 -0 lines)
MODIFY mod/quiz/report/grading/report.php   Rev. 1.46    (+16 -12 lines)
DEL question/Attic/comment.html   Rev. 1.8    (+0 -0 lines)
MODIFY mod/quiz/comment.php   Rev. 1.14    (+37 -48 lines)
MODIFY lib/questionlib.php   Rev. 1.169    (+44 -29 lines)
MODIFY lang/en_utf8/question.php   Rev. 1.27    (+1 -0 lines)
MODIFY mod/quiz/reviewquestion.php   Rev. 1.31    (+3 -6 lines)