Issue Details (XML | Word | Printable)

Key: MDL-16267
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Luis Rodrigues
Reporter: Martin Dougiamas
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-10107

Improve message settings editing form

Created: 29/Aug/08 05:17 PM   Updated: 13/Jan/09 03:48 PM
Return to search
Component/s: Messages
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: None
Image Attachments:

1. Cleaned up form.jpg
(131 kB)

Participants: Luis Rodrigues and Martin Dougiamas
Security Level: None
Resolved date: 13/Jan/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
The message settings editing form can be improved to:

   - put the output plugins into columns, with the name at the top only.
   - tidy up the layout (whole thing centered, left-hand text should be right-justified etc)
   - XHTML Strict compliant

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Luis Rodrigues committed 10 files to 'Moodle CVS' - 30/Aug/08 07:19 AM
MDL-16267 done all items in list (html tidy, xhtml strict, plugins tidy)
MODIFY message/output/popup/message_output_popup.php   Rev. 1.2    (+6 -2 lines)
MODIFY message/edit.php   Rev. 1.5    (+113 -72 lines)
MODIFY lang/en_utf8/message.php   Rev. 1.12    (+2 -2 lines)
ADD lang/en_utf8/messageprocessor_email.php   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/messageprocessor_jabber.php   Rev. 1.1    (+0 -0 lines)
MODIFY message/output/lib.php   Rev. 1.2    (+3 -3 lines)
ADD lang/en_utf8/messageprocessor_popup.php   Rev. 1.1    (+0 -0 lines)
DEL message/Attic/edit_form.php   Rev. 1.3    (+0 -0 lines)
MODIFY message/output/jabber/message_output_jabber.php   Rev. 1.2    (+7 -7 lines)
MODIFY message/output/email/message_output_email.php   Rev. 1.2    (+7 -7 lines)
Luis Rodrigues committed 1 file to 'Moodle CVS' - 30/Aug/08 07:20 AM
MDL-16267 deleted old form file
DEL message/Attic/edit2.php   Rev. 1.2    (+0 -0 lines)
Mitsuhiro Yoshida committed 9 files to 'Lang CVS' - 30/Aug/08 09:42 PM
MDL-13766 - Translated a new string for repository.
MDL-16267 - Updated a translated string for messaging.
MDL-16267 - Adding three new translated lang files for message processor.
MDL-15362 - Addding a translated lang file for Mahara portfolio plugin.
MDL-16263 - Translated new strings for question and role.
MODIFY ja_utf8/repository.php   Rev. 1.10    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.799    (+1 -1 lines)
ADD ja_utf8/messageprocessor_popup.php   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/messageprocessor_email.php   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/portfolio_mahara.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/message.php   Rev. 1.19    (+3 -2 lines)
ADD ja_utf8/messageprocessor_jabber.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/question.php   Rev. 1.26    (+6 -1 lines)
MODIFY ja_utf8/role.php   Rev. 1.70    (+9 -8 lines)
martignoni committed 3 files to 'Lang CVS' - 05/Sep/08 06:44 PM
MDL-16267 new lang files
ADD fr_utf8/messageprocessor_popup.php   Rev. 1.1    (+0 -0 lines)
ADD fr_utf8/messageprocessor_email.php   Rev. 1.1    (+0 -0 lines)
ADD fr_utf8/messageprocessor_jabber.php   Rev. 1.1    (+0 -0 lines)
moodler committed 7 files to 'Moodle CVS' - 23/Sep/08 11:05 AM
MDL-16267 and MDL-10107

I did some further work tidying up the form. I also just treat the popup like another plugin and moved all the config into the plugin.
This still needs help buttons everywhere now!
MODIFY message/output/email/message_output_email.php   Rev. 1.3    (+5 -5 lines)
MODIFY message/output/popup/message_output_popup.php   Rev. 1.4    (+22 -6 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.614    (+4 -0 lines)
MODIFY message/edit.php   Rev. 1.9    (+7 -32 lines)
MODIFY lang/en_utf8/messageprocessor_jabber.php   Rev. 1.3    (+2 -1 lines)
MODIFY message/output/jabber/message_output_jabber.php   Rev. 1.5    (+5 -5 lines)
MODIFY message/output/lib.php   Rev. 1.3    (+3 -2 lines)
moodler committed 2 files to 'Moodle CVS' - 23/Sep/08 11:15 AM
MDL-16267 Removed another table and added "th" for better readability. Removed hardcoded styles
MODIFY theme/standard/styles_layout.css   Rev. 1.615    (+5 -0 lines)
MODIFY message/edit.php   Rev. 1.10    (+6 -8 lines)
moodler committed 1 file to 'Moodle CVS' - 23/Sep/08 11:16 AM
MDL-16267 Tweaking styles for layout of message editing
MODIFY theme/standard/styles_layout.css   Rev. 1.616    (+2 -2 lines)
Mitsuhiro Yoshida committed 7 files to 'Lang CVS' - 24/Sep/08 12:30 PM
MDL-10107, MDL-16267 - Updated translated strings for Messaging interface based on lang/en_utf8 change.
MDL-15488 - Translated a new string for repository.
MDL-16486 - Translated new strings for simple test.
MODIFY ja_utf8/messageprocessor_popup.php   Rev. 1.2    (+2 -2 lines)
MODIFY ja_utf8/message.php   Rev. 1.21    (+7 -7 lines)
MODIFY ja_utf8/messageprocessor_jabber.php   Rev. 1.2    (+3 -2 lines)
MODIFY ja_utf8/repository.php   Rev. 1.28    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.822    (+1 -1 lines)
MODIFY ja_utf8/admin.php   Rev. 1.305    (+2 -2 lines)
MODIFY ja_utf8/simpletest.php   Rev. 1.14    (+5 -1 lines)
Luis Rodrigues committed 1 file to 'Moodle CVS' - 25/Sep/08 10:19 PM
MDL-16267 Messages from other users (had forgot to commit file)
ADD message/db/Attic/messages.php   Rev. 1.1    (+0 -0 lines)
Luis Rodrigues committed 5 files to 'Moodle CVS' - 26/Sep/08 01:05 AM
MDL-16267 added initial documentation for all the message providers
ADD lang/en_utf8/help/messaging/Attic/moodle_errors.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/messaging/Attic/moodle_notices.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/messaging/Attic/mod_forum_digests.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/messaging/Attic/mod_forum_posts.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/messaging/Attic/message_instantmessage.html   Rev. 1.1    (+0 -0 lines)
Luis Rodrigues committed 1 file to 'Moodle CVS' - 26/Sep/08 01:06 AM
MDL-16267 now shows default email to send message
MODIFY message/output/email/message_output_email.php   Rev. 1.4    (+6 -2 lines)
Luis Rodrigues committed 1 file to 'Moodle CVS' - 26/Sep/08 01:10 AM
MDL-16267 added helpbutton for all the message providers
MODIFY message/edit.php   Rev. 1.12    (+4 -6 lines)
moodler committed 1 file to 'Moodle CVS' - 26/Sep/08 10:20 AM
MDL-16267 and MDL-10107 Fixed a typo
MODIFY message/output/popup/message_output_popup.php   Rev. 1.5    (+5 -5 lines)
moodler committed 4 files to 'Moodle CVS' - 26/Sep/08 10:43 AM
MDL-16267 More cleanups, simplifications
MODIFY message/output/popup/message_output_popup.php   Rev. 1.6    (+7 -10 lines)
MODIFY message/output/email/message_output_email.php   Rev. 1.5    (+5 -7 lines)
MODIFY message/edit.php   Rev. 1.13    (+188 -182 lines)
MODIFY message/output/jabber/message_output_jabber.php   Rev. 1.6    (+2 -5 lines)
moodler committed 6 files to 'Moodle CVS' - 26/Sep/08 11:27 AM
MDL-16267 Moved and tidied help files
ADD lang/en_utf8/help/message/moodle_errors.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/forum/message_posts.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/forum/message_digests.html   Rev. 1.1    (+0 -0 lines)
ADD lang/en_utf8/help/message/message_instantmessage.html   Rev. 1.1    (+0 -0 lines)
MODIFY message/edit.php   Rev. 1.14    (+10 -3 lines)
ADD lang/en_utf8/help/message/moodle_notices.html   Rev. 1.1    (+0 -0 lines)
Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 05/Oct/08 11:27 PM
MDL-16267 Adding translated help files for forum and message.
MODIFY ja_utf8/README   Rev. 1.833    (+1 -1 lines)
ADD ja_utf8/help/message/message_instantmessage.html   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/help/forum/message_digests.html   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/help/forum/message_posts.html   Rev. 1.1    (+0 -0 lines)
Mitsuhiro Yoshida committed 8 files to 'Lang CVS' - 09/Oct/08 01:29 PM
MDL-16267 Adding translated help files for message.
MDL-14676 Translated a new string for question.
MDL-15887 Translated new strings for grade percentage.
MDL-15887 Adding a translated help file grade percentage.
MDL-15262 Translated new strings for role.
MDL-15402 Translated new strings for repository.
MODIFY ja_utf8/question.php   Rev. 1.30    (+3 -2 lines)
ADD ja_utf8/help/grade/showpercentage.html   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/repository.php   Rev. 1.29    (+3 -1 lines)
MODIFY ja_utf8/README   Rev. 1.836    (+1 -1 lines)
MODIFY ja_utf8/grades.php   Rev. 1.140    (+38 -36 lines)
MODIFY ja_utf8/role.php   Rev. 1.72    (+4 -1 lines)
ADD ja_utf8/help/message/moodle_notices.html   Rev. 1.1    (+0 -0 lines)
ADD ja_utf8/help/message/moodle_errors.html   Rev. 1.1    (+0 -0 lines)
martignoni committed 1 file to 'Lang CVS' - 13/Oct/08 04:38 AM
MDL-16267 and MDL-10107 new string
MODIFY fr_utf8/messageprocessor_jabber.php   Rev. 1.2    (+2 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators