Moodle

Incorporate addition of dragmath features in adminlib.php

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.8.4, 1.8.5, 1.8.6, 1.9, 1.9.1, 1.9.2, 2.0
  • Fix Version/s: DEV backlog
  • Component/s: Unknown
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

As a result of some previous efforts dragmath is now offered in Moodle CVS, but relies on a version of adminlib.php that includes minimal setting for dragmath

'insertdragmath' => 'em.icon.dragmath.gif'

The problem is that as new releases of moodle are made available the dragmath cvs faces either having to provide a separate version for each release, or face possible inconsistencies in adminlib.php.

I don't think requiring or expecting that that all users have the most recent release is reasonable.

As Dragmath is expected to be included in core 2 moodle anyway and could be actually move to core 1.9 Moodle with very minimal work, I would like to see the core adminlib.php for version 1.8.4 on be altered in Stabel to include the additional code so that adminlib.php can be deleted from the dragmath cvs.

Activity

Hide
Petr Škoda (skodak) added a comment -

There are not going to be any more improvements in 1.8.x or backporting, only critical bug fixes. 1.9.x is not getting any new features either, only normal bugfixing - sometimes there are exceptions, but those are often made for security reasons or for better backwards compatibility.

If I understand it correctly, you want one plugin to work in 1.8.x, 1.9.x? This is not possible, maybe you could use branches in contrib, right?

Show
Petr Škoda (skodak) added a comment - There are not going to be any more improvements in 1.8.x or backporting, only critical bug fixes. 1.9.x is not getting any new features either, only normal bugfixing - sometimes there are exceptions, but those are often made for security reasons or for better backwards compatibility. If I understand it correctly, you want one plugin to work in 1.8.x, 1.9.x? This is not possible, maybe you could use branches in contrib, right?
Hide
Marc Grober added a comment -

I am talking about one line in adminlib.php to support an app which was moved to CVS and as a result is presenting issues because it means that everytime someone changes adminlib.php a new version of adminlib.php has to be created for the app.... though in fact, unless I am asea on this, with 2.0 this one line will be included in adminlib.php and the added lines has no backwards compatibility issues....

Show
Marc Grober added a comment - I am talking about one line in adminlib.php to support an app which was moved to CVS and as a result is presenting issues because it means that everytime someone changes adminlib.php a new version of adminlib.php has to be created for the app.... though in fact, unless I am asea on this, with 2.0 this one line will be included in adminlib.php and the added lines has no backwards compatibility issues....
Hide
Petr Škoda (skodak) added a comment -

I do not understand at all what you want, could you please attach a patch?

Show
Petr Škoda (skodak) added a comment - I do not understand at all what you want, could you please attach a patch?
Hide
Petr Škoda (skodak) added a comment -

Found it, added the line and tested - now I can see one more checkbox there that does nothing, is that what you propose for 1.8.x and 1.9.x?

Show
Petr Škoda (skodak) added a comment - Found it, added the line and tested - now I can see one more checkbox there that does nothing, is that what you propose for 1.8.x and 1.9.x?
Hide
Marc Grober added a comment -

It does nothing if dragmath is not installed, and invokes dragmath if dragmath is installed.
Arguably, the best solution would be to include the line but to have the item not selected. Then the user could be told to activate it from the admin gui, and no further patching of adminlib.php would ever be necessary....

Show
Marc Grober added a comment - It does nothing if dragmath is not installed, and invokes dragmath if dragmath is installed. Arguably, the best solution would be to include the line but to have the item not selected. Then the user could be told to activate it from the admin gui, and no further patching of adminlib.php would ever be necessary....
Hide
Petr Škoda (skodak) added a comment -

"It does nothing if dragmath is not installed" - the way I see it it adds a new option which a) does not work if the rest of dragmath not installed b) is not documented in 1.8.x and 1.9.x
many modifications require patching of files, people usually use patches and cvs to keep the after upgrades

Show
Petr Škoda (skodak) added a comment - "It does nothing if dragmath is not installed" - the way I see it it adds a new option which a) does not work if the rest of dragmath not installed b) is not documented in 1.8.x and 1.9.x many modifications require patching of files, people usually use patches and cvs to keep the after upgrades

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated: