Issue Details (XML | Word | Printable)

Key: MDL-16285
Type: Bug Bug
Status: Open Open
Priority: Minor Minor
Assignee: Peter Bulmer
Reporter: Peter Bulmer
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

mnet code missing comments

Created: 01/Sep/08 07:38 AM   Updated: 01/Sep/08 07:38 AM
Return to search
Component/s: Networking
Affects Version/s: 1.8.6, 1.9.2
Fix Version/s: None

Participants: Peter Bulmer
Security Level: None
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
In many places mnet code is under-commented.

Provide clear function-level and inline comments that explain what the code does, reducing the need to codetrace every function to understand functionality

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Peter Bulmer committed 1 file to 'Moodle CVS' - 01/Sep/08 07:54 AM
MDL-16285 add comments to mnet/peer.php
MODIFY mnet/peer.php   Rev. 1.14    (+17 -1 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 01/Sep/08 11:32 AM
MDL-16285 MDL-16286 Cleanup and document delete function in mnet/peer


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY mnet/peer.php   Rev. 1.16    (+24 -14 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:15 AM
MDL-16285 unfold logic inversion
Ignoring whitespace this patch is 4 lines of -, and 3 lines of +, if you want to understand what the diff is, I highly recommend looking at it without whitespace changes visible.

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY mnet/xmlrpc/server.php   Rev. 1.27    (+85 -86 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:16 AM
MDL-16286 MDL-16285 Bring 'signed by old key' logic together
and add appropriate comments


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY mnet/xmlrpc/server.php   Rev. 1.28    (+15 -10 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:24 AM
MDL-16285 Simplify separate treatment of executing peer.
Change 'if' to comply with moodle coding standards
Improvements to comment


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY auth/mnet/auth.php   Rev. 1.47    (+7 -11 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:16 PM
MDL-16285 Renamed generic variable


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY mnet/xmlrpc/client.php   Rev. 1.26    (+7 -7 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:17 PM
Created commit f319290: MDL-16285 MDL-16286 - Farm menial statements out to function
& improve variable names


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY mnet/xmlrpc/client.php   Rev. 1.27    (+26 -15 lines)
Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:18 PM
MDL-16286 MDL-16285 better variable names and improved structure
Another one of those diffs that is a little more understandable when ignoring whitespace changes.


Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>
MODIFY mnet/xmlrpc/client.php   Rev. 1.28    (+20 -20 lines)