[#MDL-16286] mnet code inappropriate structure

Issue Details (XML | Word | Printable)

Key:	MDL-16286
Type:	Bug
Status:	Open
Priority:	Minor
Assignee:	Peter Bulmer
Reporter:	Peter Bulmer
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

mnet code inappropriate structure

Created: 01/Sep/08 08:05 AM Updated: 01/Sep/08 08:05 AM

Return to search

Component/s:

Networking

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Peter Bulmer
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

In places mnet code has some strange formatting & inappropriate structure.

Change code to improve readability and comply with moodle coding standards.

All

Comments

Change History

Version Control

Sort Order:

Peter Bulmer committed 1 file to 'Moodle CVS' - 01/Sep/08 08:29 AM

MDL-16286 Change flow of bootstrap to remove hanging indent

MODIFY

mnet/peer.php

Rev. 1.15

(+44 -44 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 01/Sep/08 11:32 AM

MDL-16285 MDL-16286 Cleanup and document delete function in mnet/peer

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/peer.php

Rev. 1.16

(+24 -14 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:16 AM

MDL-16286 MDL-16285 Bring 'signed by old key' logic together
and add appropriate comments

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/server.php

Rev. 1.28

(+15 -10 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:18 AM

MDL-16286 separate strip wrappers() to decrypt() and check_sig()
additionally unfold logic inverstion around encrypted if block
To view this diff more effectively, consider setting 'ignore whitespace'

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/server.php

Rev. 1.29

(+86 -115 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:22 AM

MDL-16286 - replace get_records_sql with more generic get_records

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

auth/mnet/auth.php

Rev. 1.46

(+3 -11 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 07/Sep/08 11:26 AM

MDL-16286 remove additional reference to (now undefined) $sql

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

auth/mnet/auth.php

Rev. 1.49

(+2 -2 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 11:45 AM

MDL-16286 minor formatting adjustment

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/client.php

Rev. 1.22

(+1 -1 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 11:47 AM

MDL-16286 Remove redundant lines and improve variable names

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/client.php

Rev. 1.23

(+3 -6 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:04 PM

MDL-16286 farm permission-to-call checks out to a function

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/client.php

Rev. 1.24

(+55 -42 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:16 PM

MDL-16286 MDL16285 add comment & invert logic flow
(This diff is best viewed ignoring whitespace changes)
Ignore logic flow so that errors are dealt with first

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/client.php

Rev. 1.25

(+47 -47 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:17 PM

Created commit f319290: MDL-16285 MDL-16286 - Farm menial statements out to function
& improve variable names

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/client.php

Rev. 1.27

(+26 -15 lines)

Peter Bulmer committed 1 file to 'Moodle CVS' - 28/Sep/08 12:18 PM

MDL-16286 MDL-16285 better variable names and improved structure
Another one of those diffs that is a little more understandable when ignoring whitespace changes.

Author: Peter Bulmer <peter.bulmer@catalyst.net.nz>

MODIFY

mnet/xmlrpc/client.php

Rev. 1.28

(+20 -20 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.