Moodle

Course Creators Appear in Group Potential Member List

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9, 2.0
  • Fix Version/s: 2.0
  • Component/s: Groups
  • Labels:
    None

Description

Along with students and teachers, course creators and "better than course creators" (our creation) appear in the list of potential members when defining Groups. This can confuse teachers who are defining groups.

Issue Links

This issue will be resolved by:
MDL-11798 separation of course:view capability Blocker Closed
This issue has been marked as being related by:
MDL-16316 Users with admin role assigned at the system level show up on participants drop down list for recent activity in courses they are not enrolled in. Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Borrow added a comment -

In the forum, I raised the question of use scenarios when course creators would be added to groups. It does not seem likely to me but I thought it good to check with the community and see how folks are using it. I think we should be consistent with who appears. I'd be interested in defining the logic of what users are listed in particular contexts. Looking at the code it revolves around the groups_get_members_by_role function defined in /group/lib.php. The code does as it says and returns all the roles. Would it be helpful to have a course setting that would exclude particular roles? Peace - Anthony

Show
Anthony Borrow added a comment - In the forum, I raised the question of use scenarios when course creators would be added to groups. It does not seem likely to me but I thought it good to check with the community and see how folks are using it. I think we should be consistent with who appears. I'd be interested in defining the logic of what users are listed in particular contexts. Looking at the code it revolves around the groups_get_members_by_role function defined in /group/lib.php. The code does as it says and returns all the roles. Would it be helpful to have a course setting that would exclude particular roles? Peace - Anthony
Hide
Permalink
Sam Marshall added a comment -

Hi Anthony - I'm not going to have time to change this in the near future as I'm about to go on holiday again Also I don't think my code change actually altered behaviour here (ie it showed those people before, they just weren't categorised into roles)?

If this is to be changed I would suggest looking at the way we do this for other code, for example grade reports (and the new completion system in 2.0). These have, in admin settings, a list of roles with checkboxes. So we could add an admin setting 'roles that are shown as potential group members' , which could default to (say) student, teacher, and editing teacher only.

Show
Sam Marshall added a comment - Hi Anthony - I'm not going to have time to change this in the near future as I'm about to go on holiday again Also I don't think my code change actually altered behaviour here (ie it showed those people before, they just weren't categorised into roles)? If this is to be changed I would suggest looking at the way we do this for other code, for example grade reports (and the new completion system in 2.0). These have, in admin settings, a list of roles with checkboxes. So we could add an admin setting 'roles that are shown as potential group members' , which could default to (say) student, teacher, and editing teacher only.
Hide
Permalink
Anthony Borrow added a comment -

Thanks for the reply Sam and enjoy your well deserved holiday. I agree that your change helped to organize the presentation of the potential users and was a step forward. Now its just a matter of seeing how we might make the interface either more consistent, as you mentioned with gradebook, and user friendly. I think the extra roles increases the possibility for confusion and that teachers generally expect only to see their students and perhaps the teachers but I think course creators could be removed without too much complaint. I like the suggestion for handling it in admin settings with a list of checkboxes. If Petr thinks this sounds reasonable, I may try to start work on a patch. Peace - Anthony

Show
Anthony Borrow added a comment - Thanks for the reply Sam and enjoy your well deserved holiday. I agree that your change helped to organize the presentation of the potential users and was a step forward. Now its just a matter of seeing how we might make the interface either more consistent, as you mentioned with gradebook, and user friendly. I think the extra roles increases the possibility for confusion and that teachers generally expect only to see their students and perhaps the teachers but I think course creators could be removed without too much complaint. I like the suggestion for handling it in admin settings with a list of checkboxes. If Petr thinks this sounds reasonable, I may try to start work on a patch. Peace - Anthony
Hide
Permalink
Anthony Borrow added a comment -

I've added 2.0 to this as we may just want to fix it up in 2.0 rather than changing the behavior in 1.9 with the option of a patch for 1.9.

Show
Anthony Borrow added a comment - I've added 2.0 to this as we may just want to fix it up in 2.0 rather than changing the behavior in 1.9 with the option of a patch for 1.9.
Hide
Permalink
Petr Škoda (skodak) added a comment -

In 1.9.x please make sure that the course creator does not have the moodle/course:view capability - it was incorrectly specified there in early 1.7.x versions.
In 2.0 this was changed to sue enrolments table instead, only real enrolled users are available there.

Thank you for the report.

Petr Skoda

Show
Petr Škoda (skodak) added a comment - In 1.9.x please make sure that the course creator does not have the moodle/course:view capability - it was incorrectly specified there in early 1.7.x versions. In 2.0 this was changed to sue enrolments table instead, only real enrolled users are available there. Thank you for the report. Petr Skoda

People

Vote (6)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.