Moodle

Lesson module does not export the maximum grade into the gradebook

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.5
  • Component/s: Lesson
  • Labels:
    None
  • Environment:
    Observed at Postgre 8.2.7 and 8.3.3, PHP 5
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Easy to reproduce:
===============

1. create a new Lesson
2. in the Lesson edit form set the "Maximum grade" to e.g. "10"
3. go to the gradebook and choose "Show ranges"
4. see the grade item for the new lesson

What is expected
==============
You should see range 0-10.00 (or whatever you have set)

What actually happened
===================
the range is still 0-100 and you are not able to change it

Setting high priority for this as it makes lesson grading not backward compatible with 1.8 behaviour. Assigning to myself - I'm going to look at it.

Issue Links

This issue duplicates:
MDL-12883 Lesson maxgrade value set to 100.00, no matter how many points are selected. Minor Closed
This issue has a non-specific relationship to:
MDL-17101 Lesson module reports wring grade to gradebook Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

Tha patch resolves this. In the current version, the maxgrade hardcoded to 100 and the multfactor was calculated. However, multfactor does not seem to work at the moment . Also, IMHO the correct behaviour is to set maxgrade and let multfactor being defined at the gradebook level only (not module level).

Show
David Mudrak added a comment - Tha patch resolves this. In the current version, the maxgrade hardcoded to 100 and the multfactor was calculated. However, multfactor does not seem to work at the moment . Also, IMHO the correct behaviour is to set maxgrade and let multfactor being defined at the gradebook level only (not module level).
Hide
Permalink
David Mudrak added a comment -

Eloy, please +1 before commit. Thanks

Show
David Mudrak added a comment - Eloy, please +1 before commit. Thanks
Hide
Permalink
David Mudrak added a comment -

QA to skodak as he seems to be an author of the current solution.

Show
David Mudrak added a comment - QA to skodak as he seems to be an author of the current solution.
Hide
Permalink
Martin Dougiamas added a comment -

Looks sensible, I say +1 for 1.9 and HEAD. Thanks, David!

Show
Martin Dougiamas added a comment - Looks sensible, I say +1 for 1.9 and HEAD. Thanks, David!
Hide
Permalink
David Mudrak added a comment -

Fixed in CVS

Show
David Mudrak added a comment - Fixed in CVS
Hide
Permalink
Petr Škoda (skodak) added a comment -

reopening

Show
Petr Škoda (skodak) added a comment - reopening
Hide
Permalink
Mark Nielsen added a comment -

This ticket caused MDL-17101, from what I can tell.

Show
Mark Nielsen added a comment - This ticket caused MDL-17101, from what I can tell.
Hide
Permalink
Mark Nielsen added a comment -

The fix for MDL-17101 has been committed. Should wrap up the changes made for this ticket.

Show
Mark Nielsen added a comment - The fix for MDL-17101 has been committed. Should wrap up the changes made for this ticket.
Hide
Permalink
Andrew Davis added a comment -

Tested this at the same time as MDL-17101. Maximum grade for a lesson is being correctly reported in the grader report. Closing.

Show
Andrew Davis added a comment - Tested this at the same time as MDL-17101. Maximum grade for a lesson is being correctly reported in the grader report. Closing.
Hide
Permalink
Paul Nijbakker added a comment -

I am afraid that, even though the grade range in my lessons is correctly shown as 0 to 5 in the gradebook, the grade is still calculated as if it was a range of 0 to 100, i.e. a 100% result, which should render a grade 5 is rendered as a grade 0,25.

Show
Paul Nijbakker added a comment - I am afraid that, even though the grade range in my lessons is correctly shown as 0 to 5 in the gradebook, the grade is still calculated as if it was a range of 0 to 100, i.e. a 100% result, which should render a grade 5 is rendered as a grade 0,25.
Hide
Permalink
David Mudrak added a comment -

Paul, are you sure you are using the latest Moodle version?

Show
David Mudrak added a comment - Paul, are you sure you are using the latest Moodle version?

People

Vote (1)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.