Moodle

mimeinfo_from_icon should optionally return all mimetypes associated with a given icon

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Files API, Portfolio API
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

Currently it just returns the LAST match. I'm committing a patch to head that lets you optionally request it to return you all matches.

Feel free to quarrel about this patch, I guess it could be controversial.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Penny Leach added a comment -

making sure potential quarrelers are watching this bug.

here's the patch: http://paste.dollyfish.net.nz/2ef6d5

Show
Penny Leach added a comment - making sure potential quarrelers are watching this bug. here's the patch: http://paste.dollyfish.net.nz/2ef6d5
Hide
Permalink
Penny Leach added a comment -

er. slightly better version:

http://paste.dollyfish.net.nz/4c52e2

Show
Penny Leach added a comment - er. slightly better version: http://paste.dollyfish.net.nz/4c52e2
Hide
Permalink
Sam Marshall added a comment -

Looks OK to me.

Show
Sam Marshall added a comment - Looks OK to me.
Hide
Permalink
Penny Leach added a comment -

committing to head (taking sam's suggestion about the comment with my name on it into account) - can still be reworked if people have a better solution. (and I will leave this bug open for awhile too)

Show
Penny Leach added a comment - committing to head (taking sam's suggestion about the comment with my name on it into account) - can still be reworked if people have a better solution. (and I will leave this bug open for awhile too)
Hide
Permalink
Penny Leach added a comment -

closing for lack of quarrelling.

Show
Penny Leach added a comment - closing for lack of quarrelling.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.