[#MDL-16359] mimeinfo_from_icon should optionally return all mimetypes associated with a given icon

Issue Details (XML | Word | Printable)

Key:	MDL-16359
Type:	Improvement
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Penny Leach
Reporter:	Penny Leach
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

mimeinfo_from_icon should optionally return all mimetypes associated with a given icon

Created: 06/Sep/08 12:23 AM Updated: 09/Sep/08 08:59 PM

Return to search

Component/s:

Files API, Portfolio API

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Penny Leach and Sam Marshall
Security Level:	None
Resolved date:	09/Sep/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

Currently it just returns the LAST match. I'm committing a patch to head that lets you optionally request it to return you all matches.

Feel free to quarrel about this patch, I guess it could be controversial.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Penny Leach added a comment - 06/Sep/08 12:25 AM

making sure potential quarrelers are watching this bug.

here's the patch: http://paste.dollyfish.net.nz/2ef6d5

[ Permalink | « Hide ]

Penny Leach added a comment - 06/Sep/08 12:27 AM

er. slightly better version:

http://paste.dollyfish.net.nz/4c52e2

[ Permalink | « Hide ]

Sam Marshall added a comment - 06/Sep/08 12:37 AM

Looks OK to me.

[ Permalink | « Hide ]

Penny Leach added a comment - 06/Sep/08 12:43 AM

committing to head (taking sam's suggestion about the comment with my name on it into account) - can still be reworked if people have a better solution. (and I will leave this bug open for awhile too)

[ Permalink | « Hide ]

Penny Leach added a comment - 09/Sep/08 08:59 PM

closing for lack of quarrelling.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.