Issue Details (XML | Word | Printable)

Key: MDL-16360
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Penny Leach
Reporter: Penny Leach
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-14591

use mime detection to detect sub formats of 'file'

Created: 06/Sep/08 01:03 AM   Updated: 06/Sep/08 03:15 AM
Return to search
Component/s: Portfolio API
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Nicolas Connault and Penny Leach
Security Level: None
Resolved date: 06/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
related to MDL-16359, I am leveraging the ability to go from icon types (roughly equivalent to portfolio formats for now) to supported mimetypes for any given format.

i've tested this with the flickr plugin (which i've changed to support image and video formats) and it's working nice.

also changed docs to add notes about supportedformats for single file export and mime detection:

http://docs.moodle.org/en/Development:Adding_a_Portfolio_Button_to_a_page#supported_formats_.28static.29_.28read_this_even_if_you_don.27t_want_to_override_this_function.2C_it.27s_important.29

and changed all logical places to be more specific about supported formats.

also related to MDL-16124

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
mjollnir_ committed 10 files to 'Moodle CVS' - 06/Sep/08 01:07 AM
MDL-16360 - added support for mime-style subformat detection for portfolio supported formats
works well with flickr plugin (tested by uploading an image as a forum attachment and being offered flickr plugin but not for normal attachments)
MODIFY portfolio/type/flickr/Attic/lib.php   Rev. 1.3    (+4 -0 lines)
MODIFY mod/chat/lib.php   Rev. 1.122    (+2 -1 lines)
MODIFY mod/forum/lib.php   Rev. 1.728    (+1 -3 lines)
MODIFY mod/data/lib.php   Rev. 1.198    (+1 -0 lines)
MODIFY mod/assignment/lib.php   Rev. 1.360    (+9 -6 lines)
MODIFY mod/resource/lib.php   Rev. 1.97    (+11 -1 lines)
MODIFY mod/glossary/lib.php   Rev. 1.230    (+2 -1 lines)
MODIFY mod/assignment/type/online/assignment.class.php   Rev. 1.63    (+5 -1 lines)
MODIFY lib/portfoliolib.php   Rev. 1.51    (+99 -5 lines)
MODIFY lang/en_utf8/portfolio.php   Rev. 1.21    (+4 -1 lines)
Penny Leach added a comment - 06/Sep/08 01:08 AM
adding Nico - as flickr plugin ninja this affects him.

Penny Leach added a comment - 06/Sep/08 01:09 AM
committed

Penny Leach made changes - 06/Sep/08 01:09 AM
Field Original Value New Value
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
mjollnir_ committed 1 file to 'Moodle CVS' - 06/Sep/08 01:23 AM
MDL-16360 - better forum implementation
MODIFY mod/forum/lib.php   Rev. 1.729    (+16 -3 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 06/Sep/08 01:36 AM
Brushed up a translated help file for portfolio box.net.
MDL-16360 - Translated new strings for portfolio.
MODIFY ja_utf8/help/portfolio/boxnet_apikey.html   Rev. 1.2    (+1 -1 lines)
MODIFY ja_utf8/portfolio.php   Rev. 1.17    (+4 -1 lines)
Nicolas Connault added a comment - 06/Sep/08 03:15 AM
well done Penny!

martignoni committed 1 file to 'Lang CVS' - 14/Sep/08 07:21 PM
MDL-16360 strings added
MODIFY fr_utf8/portfolio.php   Rev. 1.17    (+5 -2 lines)