Issue Details (XML | Word | Printable)

Key: MDL-16411
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Move all plugintype_pluginname_version values from config to config_plugins

Created: 09/Sep/08 04:25 PM   Updated: 10/Sep/08 06:15 PM
Return to search
Component/s: Administration
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File config_plugins.patch.txt (9 kB)

Participants: Tim Hunt
Security Level: None
Resolved date: 10/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt made changes - 10/Sep/08 01:47 PM
Field Original Value New Value
Issue Type Sub-task [ 5 ] Improvement [ 4 ]
Parent MDL-6751 [ 17519 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Sep/08 01:51 PM
Actually, it is easier to do this for all types of plugin, not just qtypes.

This should save 32 config variables, or 9% of the size of the config table.


Tim Hunt made changes - 10/Sep/08 01:51 PM
Component/s Questions [ 10087 ]
Summary Move qtype_xxx_version variable to the config_plugins table Move all plugintype_pluginname_version values from config to config_plugins
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Sep/08 04:15 PM
Patch for review

Tim Hunt made changes - 10/Sep/08 04:15 PM
Attachment config_plugins.patch.txt [ 15122 ]
Tim Hunt made changes - 10/Sep/08 04:16 PM
Attachment config_plugins.patch.txt [ 15122 ]
Tim Hunt made changes - 10/Sep/08 04:17 PM
Attachment config_plugins.patch.txt [ 15123 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 10/Sep/08 04:19 PM
I tested both a fresh install, and also, upgrading from yesterday's head while simultaneously upgrading one core question type plugin and installing a contrib question type. Both worked.

tjhunt committed 3 files to 'Moodle CVS' - 10/Sep/08 06:15 PM
MDL-16411 Move all plugintype_pluginname_version values from config to config_plugins
MODIFY version.php   Rev. 1.802    (+1 -1 lines)
MODIFY lib/db/upgrade.php   Rev. 1.238    (+27 -1 lines)
MODIFY lib/adminlib.php   Rev. 1.265    (+39 -19 lines)
Tim Hunt made changes - 10/Sep/08 06:15 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
tjhunt committed 1 file to 'Moodle CVS' - 10/Sep/08 06:30 PM
MDL-16411 Oops, I had the logic backwards.
MODIFY lib/db/upgrade.php   Rev. 1.239    (+2 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 15/Sep/08 12:20 PM
MDL-16492: the fix for MDL-16411 broke the fix for MDL-16200. Fix it.
MODIFY mod/quiz/db/upgrade.php   Rev. 1.26    (+2 -2 lines)
tjhunt committed 1 file to 'Moodle CVS' - 18/Sep/08 10:46 AM
MDL-16411 - fix qtype admin page to look in the new place for version numbers.
MODIFY admin/qtypes.php   Rev. 1.6    (+4 -4 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators