Moodle

Portfolio: Download a file

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Portfolio API
  • Labels:
    None
  • Environment:
    LAMP
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

I think "File Download" plugin should behave differently from other plugin. There is too many steps in order to download a file. I think we should directly download the file when you press the button called "next"/"Add to portfolio". This button could be renamed by javascript into "Download" when "File Download" option is selected.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Penny Leach added a comment -

Questions:

Do you think it's worthwhile printing the summary of previous exports? That stage gets skipped if it's a first off.

I can skip the config step if there's no config (although I can't guarantee there won't be based on what the calling code needs to know (options) and if there are multiple available export formats)

Show
Penny Leach added a comment - Questions: Do you think it's worthwhile printing the summary of previous exports? That stage gets skipped if it's a first off. I can skip the config step if there's no config (although I can't guarantee there won't be based on what the calling code needs to know (options) and if there are multiple available export formats)
Hide
Permalink
Penny Leach added a comment -

That was a total brain -> keyboard fail.

The first question still stands.

You were talking about the final screen though, I guess. I will look at that.

Show
Penny Leach added a comment - That was a total brain -> keyboard fail. The first question still stands. You were talking about the final screen though, I guess. I will look at that.
Hide
Permalink
Penny Leach added a comment -

i had a play with this today and it's actually more complicated.

if you just redirect to the file url (causing the download to start on the 'next' button click) you get stuck on that screen with no way to get out of it.

you get the next and cancel buttons, which don't make sense anymore, pressing next again will generate an error because the transfer has completed after the file has been sent, and the cancel button will do the same since it can't get the returnurl anymore either, as the transfer is completed.

Show
Penny Leach added a comment - i had a play with this today and it's actually more complicated. if you just redirect to the file url (causing the download to start on the 'next' button click) you get stuck on that screen with no way to get out of it. you get the next and cancel buttons, which don't make sense anymore, pressing next again will generate an error because the transfer has completed after the file has been sent, and the cancel button will do the same since it can't get the returnurl anymore either, as the transfer is completed.
Hide
Permalink
Penny Leach added a comment -

Jerome, I'm tempted to close this 'wontfix' as I think the work that needs to go into it is much greater than the potential gain. Please give your comments tomorrow.

Show
Penny Leach added a comment - Jerome, I'm tempted to close this 'wontfix' as I think the work that needs to go into it is much greater than the potential gain. Please give your comments tomorrow.
Hide
Permalink
Jerome Mouneyrac added a comment -

No worries Penny, I close it as "won't fix".
Anyway first I though it was strange from an user point of view to have the download functionality into "Add to Portfolio". It's not the first place I would look in order to download, even if I understand why it's here (like any portfolio, we export the file). I would rather put a link everywhere, next to "Add to portfolio". Thanks for the time spent to look for a better solution

Show
Jerome Mouneyrac added a comment - No worries Penny, I close it as "won't fix". Anyway first I though it was strange from an user point of view to have the download functionality into "Add to Portfolio". It's not the first place I would look in order to download, even if I understand why it's here (like any portfolio, we export the file). I would rather put a link everywhere, next to "Add to portfolio". Thanks for the time spent to look for a better solution
Hide
Permalink
Penny Leach added a comment -

Actually it was really developed as a proof of concept plugin. I'm not really even sure it makes sense to keep in core, I might move it to contrib before 2.0... although it does start to make more sense as more export formats evolve (eg moodle backup)

Show
Penny Leach added a comment - Actually it was really developed as a proof of concept plugin. I'm not really even sure it makes sense to keep in core, I might move it to contrib before 2.0... although it does start to make more sense as more export formats evolve (eg moodle backup)
Hide
Permalink
Martin Dougiamas added a comment -

Can I reopen this? ... I think this could be improved still.

1. The last page says "Portfolio export complete!" when it isn't complete yet .
2. The download link is tiny and hidden under the "Return to where you were"

Could this this page instead just start the download and then immediately redirect back to where we came from? (Using JS)

Without JS, could it have nice big centered button with "Click here to download your file" and a link beneath it with "Return to Forum: News Forum" (and even better, rewrite the navigation to show the original navigation for the forum plus " -> Portfolio -> Download". And the header could be "Downloading..."

Show
Martin Dougiamas added a comment - Can I reopen this? ... I think this could be improved still. 1. The last page says "Portfolio export complete!" when it isn't complete yet . 2. The download link is tiny and hidden under the "Return to where you were" Could this this page instead just start the download and then immediately redirect back to where we came from? (Using JS) Without JS, could it have nice big centered button with "Click here to download your file" and a link beneath it with "Return to Forum: News Forum" (and even better, rewrite the navigation to show the original navigation for the forum plus " -> Portfolio -> Download". And the header could be "Downloading..."
Hide
Permalink
Penny Leach added a comment -

ok i think this is much better now.

one last thing that could be improved - currently if you export the same content multiple times it creates a new stage to tell you about it - the confirm stage. at least, if there's no export config it creates a new stage. if there is export config (not in the case of download plugin) you don't notice the difference as you always get that screen.

I could make portfolio plugins able to override this and say "don't care about previous exports - skip the confirm stage unless you have other stuff to tell me about (eg actual config options)

That would make the download plugin even faster. Thoughts?

Show
Penny Leach added a comment - ok i think this is much better now. one last thing that could be improved - currently if you export the same content multiple times it creates a new stage to tell you about it - the confirm stage. at least, if there's no export config it creates a new stage. if there is export config (not in the case of download plugin) you don't notice the difference as you always get that screen. I could make portfolio plugins able to override this and say "don't care about previous exports - skip the confirm stage unless you have other stuff to tell me about (eg actual config options) That would make the download plugin even faster. Thoughts?
Hide
Permalink
Penny Leach added a comment -

I think we should close this now - everyone happy ?

Show
Penny Leach added a comment - I think we should close this now - everyone happy ?
Hide
Permalink
Penny Leach added a comment -

closing after much inactivity after fixing.

Show
Penny Leach added a comment - closing after much inactivity after fixing.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.