[#MDL-16438] centralise information about plugins to avoid duplication

Issue Details (XML | Word | Printable)

Key:	MDL-16438
Type:	Bug
Status:	Reopened
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Penny Leach
Votes:	1
Watchers:	9

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

centralise information about plugins to avoid duplication

Created: 10/Sep/08 06:44 PM Updated: 01/Sep/09 04:13 AM

Return to search

Component/s:

General

Affects Version/s:

2.0

Fix Version/s:

2.0

File Attachments:

plugins_cleanup9.patch (103 kB)

Issue Links:

Dependency

This issue will help resolve:

MDL-16487 The plugins check is outdated

~~MDL-16392~~ Portfolio plugins can't register queue handlers

This issue will be resolved by:

~~MDL-20191~~ Subplugins are not uninstalled together with a module

Relates

This issue has a non-specific relationship to:

~~MDL-19346~~ Discrepancies between plugins declared in get_plugin_types() and detected by get_db_directories()

~~MDL-13816~~ Improve the mechanisms by which the places to search for plugins' language strings is managed

This issue has been marked as being related by:

MDL-20152 glossary should use format-specific strings for concept and definition

~~MDL-19550~~ Question formats from contrib are not completely pluggable - must modify core lang files.

Participants:	Anthony Borrow, Dan Poltawski, David Mudrak, Eloy Lafuente (stronk7), Nicolas Connault, Penny Leach, Petr Skoda and Tim Hunt
Security Level:	None
Resolved date:	19/Jun/09
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Sub-Tasks:

All

Open

Sub-Task Progress:

~~use $capabilities = array() in db/access.php~~

Resolved

Petr Skoda

Description

« Hide

From a conversation in jabber and following on from ~~MDL-16392~~

It would be good to have an array somewhere containing all information about plugins, where their db directories are etc. At the moment get_db_directories seems to contain most of this information but there are other places in moodle that duplicate this (the example was events_load_def).

If we could maintain *one* array containing this information and then a few helper functions around it we could potentially:

a) remove a lot of duplication
b) make it easier to add new plugin 'types' later without having to add db location information in muliple places

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 60 files to 'Moodle CVS' - 19/Jun/09 10:25 PM

MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions

MODIFY	mod/survey/lib.php	Rev. 1.78	(+4 -1 lines)
MODIFY	mod/wiki/lib.php	Rev. 1.68	(+2 -5 lines)
MODIFY	theme/index.php	Rev. 1.44	(+5 -5 lines)
MODIFY	mod/data/lib.php	Rev. 1.232	(+2 -2 lines)
MODIFY	admin/report/unittest/test_tables.php	Rev. 1.4	(+2 -8 lines)
MODIFY	admin/settings/courses.php	Rev. 1.36	(+3 -3 lines)
MODIFY	mod/choice/mod_form.php	Rev. 1.31	(+1 -1 lines)
MODIFY	lib/accesslib.php	Rev. 1.601	(+15 -85 lines)
DEL	lib/Attic/locallib.php	Rev. 1.30	(+0 -0 lines)
MODIFY	mod/resource/lib.php	Rev. 1.118	(+3 -4 lines)
MODIFY	user/filters/lib.php	Rev. 1.16	(+3 -3 lines)
MODIFY	admin/enrol.php	Rev. 1.35	(+5 -6 lines)
MODIFY	admin/settings/users.php	Rev. 1.50	(+5 -5 lines)
MODIFY	grade/lib.php	Rev. 1.174	(+8 -8 lines)
MODIFY	mod/scorm/lib.php	Rev. 1.120	(+0 -1 lines)
MODIFY	course/import.php	Rev. 1.17	(+4 -4 lines)
MODIFY	admin/settings/grades.php	Rev. 1.40	(+10 -11 lines)
MODIFY	grade/edit/settings/form.php	Rev. 1.13	(+4 -4 lines)
MODIFY	lib/portfoliolib.php	Rev. 1.70	(+2 -2 lines)
MODIFY	mod/quiz/settingstree.php	Rev. 1.5	(+4 -4 lines)
MODIFY	lib/db/messages.php	Rev. 1.2	(+5 -7 lines)
MODIFY	blocks/admin/block_admin.php	Rev. 1.125	(+3 -3 lines)
MODIFY	user/editadvanced_form.php	Rev. 1.30	(+4 -4 lines)
MODIFY	admin/xmldb/actions/XMLDBAction.class.php	Rev. 1.7	(+4 -4 lines)
MODIFY	mod/hotpot/lib.php	Rev. 1.120	(+8 -1 lines)
MODIFY	admin/cron.php	Rev. 1.164	(+23 -20 lines)
MODIFY	mod/assignment/restorelib.php	Rev. 1.39	(+2 -2 lines)
MODIFY	lib/setup.php	Rev. 1.275	(+5 -4 lines)
DEL	message/db/Attic/messages.php	Rev. 1.2	(+0 -0 lines)
MODIFY	mod/quiz/report/reportlib.php	Rev. 1.39	(+2 -2 lines)
MODIFY	admin/auth.php	Rev. 1.69	(+0 -3 lines)
MODIFY	mod/chat/lib.php	Rev. 1.145	(+7 -1 lines)
MODIFY	admin/enrol_config.php	Rev. 1.22	(+3 -3 lines)
MODIFY	rss/file.php	Rev. 1.25	(+3 -2 lines)
MODIFY	course/edit_form.php	Rev. 1.68	(+4 -4 lines)
MODIFY	course/report.php	Rev. 1.12	(+4 -4 lines)
MODIFY	lib/gradelib.php	Rev. 1.159	(+2 -4 lines)
MODIFY	grade/report/index.php	Rev. 1.9	(+7 -7 lines)
MODIFY	mod/assignment/lib.php	Rev. 1.388	(+10 -8 lines)
MODIFY	lib/javascript-mod.php	Rev. 1.5	(+7 -25 lines)
MODIFY	mod/forum/lib.php	Rev. 1.797	(+0 -2 lines)
MODIFY	lib/weblib.php	Rev. 1.1269	(+16 -20 lines)
MODIFY	mod/label/lib.php	Rev. 1.31	(+0 -1 lines)
MODIFY	mod/choice/lib.php	Rev. 1.105	(+9 -6 lines)
MODIFY	lib/db/upgrade.php	Rev. 1.308	(+61 -1 lines)
MODIFY	mod/lesson/lib.php	Rev. 1.67	(+0 -2 lines)
ADD	local/readme.txt	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/moodlelib.php	Rev. 1.1216	(+205 -67 lines)
MODIFY	lib/questionlib.php	Rev. 1.203	(+8 -8 lines)
MODIFY	lib/adminlib.php	Rev. 1.364	(+27 -68 lines)
MODIFY	mod/feedback/lib.php	Rev. 1.40	(+3 -2 lines)
MODIFY	version.php	Rev. 1.1149	(+1 -1 lines)
MODIFY	lib/messagelib.php	Rev. 1.8	(+3 -36 lines)
MODIFY	admin/uploaduser.php	Rev. 1.94	(+3 -2 lines)
MODIFY	mod/quiz/lib.php	Rev. 1.340	(+1 -1 lines)
MODIFY	lib/editorlib.php	Rev. 1.14	(+1 -1 lines)
MODIFY	lib/upgradelib.php	Rev. 1.21	(+33 -106 lines)
MODIFY	lib/ddl/database_manager.php	Rev. 1.27	(+1 -1 lines)
MODIFY	lib/eventslib.php	Rev. 1.25	(+2 -39 lines)
MODIFY	admin/settings/plugins.php	Rev. 1.42	(+15 -5 lines)

tjhunt committed 2 files to 'Moodle CVS' - 22/Jun/09 02:03 PM

MDL-16438 fix string manager unit tests.

MODIFY	lib/moodlelib.php		Rev. 1.1218		(+2 -2 lines)
MODIFY	lib/simpletest/teststringmanager.php		Rev. 1.5		(+8 -8 lines)

Nicolas Connault committed 1 file to 'Moodle CVS' - 25/Jun/09 09:32 AM

MDL-16438 Reverting upgrade of assignment/lib.php. get_plugin_types() is not fully implemented and doesn't yet support assignment types.

MODIFY

mod/assignment/lib.php

Rev. 1.389

(+1 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 25/Jun/09 05:14 PM

MDL-16438 fixed regression during recent plugin centralisation effort

MODIFY

lib/weblib.php

Rev. 1.1277

(+5 -5 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 26/Jun/09 05:02 PM

MDL-16438 standardized component names

MODIFY

lib/upgradelib.php

Rev. 1.22

(+7 -7 lines)

Sam Hemelryk committed 1 file to 'Moodle CVS' - 30/Jun/09 09:41 AM

course-reports MDL-16438 Fixed broken reports, changed plugin list type to coursereport

MODIFY

course/report.php

Rev. 1.13

(+2 -2 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 02/Jul/09 11:01 PM

MDL-16438 dixed resource borking install - no code execution in lib.php files!

MODIFY	mod/resource/lib.php		Rev. 1.120		(+0 -4 lines)
MODIFY	mod/resource/db/install.php		Rev. 1.3		(+2 -1 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 02/Jul/09 11:02 PM

MDL-16438 fixed incomplete plugin centralisation, sorry; unfortunately install is kind of non-working now; this may break current dev installs :-(

MODIFY	mod/quiz/report/statistics/db/install.php		Rev. 1.2		(+2 -2 lines)
MODIFY	lib/moodlelib.php		Rev. 1.1225		(+4 -4 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 02/Jul/09 11:11 PM

MDL-16438 fixed incomplete plugin centralisation, sorry; unfortunately install is kind of non-working now; this may break current dev installs :-(

MODIFY	mod/quiz/report/statistics/db/upgrade.php		Rev. 1.12		(+2 -2 lines)
MODIFY	mod/quiz/report/statistics/db/access.php		Rev. 1.3		(+1 -1 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 04/Jul/09 05:48 PM

MDL-16438 fixed portfolio regression

MODIFY

lib/portfoliolib.php

Rev. 1.72

(+3 -2 lines)

Nicolas Connault committed 1 file to 'Moodle CVS' - 06/Jul/09 02:56 PM

MDL-16438 Fixed parsing of get_plugins_list for grader reports.

MODIFY

grade/report/index.php

Rev. 1.10

(+5 -6 lines)

tjhunt committed 5 files to 'Moodle CVS' - 07/Jul/09 01:05 PM

themes: MDL-19077 - more work on the theme_config class.

* Writing lots more PHPdoc comments for all the settings.
* Strip the comments from the standard theme config.php (see below)
* Move finding the layout template from moodle_core_renderer to the theme_config class
* Move loading meta.php files from moodle_core_renderer to the theme_config class
* ~~MDL-19719~~ Remove support for $THEME->langsheets, and lang/.../styles.php
* ~~MDL-19719~~ Put the Vietnamese-specific code into the standard theme
* Support for styles.php in all plugin types (at the theme's discretion). (c/f MDL-16438)
* More PHP doc comments for moodle_core_renderer methods.

About stripping comments from config.php: I'm not sure if this
is a good idea, and I may revert this bit. I am hoping that once
http://phpdocs.moodle.org/HEAD/moodlecore/theme_config.html has
been updated, that will be better than copying and pasting these
comments into every theme. I intend to post in the themes forum
to canvas opinions.

MODIFY	theme/standardwhite/config.php	Rev. 1.12	(+58 -103 lines)
MODIFY	theme/styles.php	Rev. 1.2	(+27 -38 lines)
MODIFY	lib/outputlib.php	Rev. 1.21	(+477 -232 lines)
MODIFY	theme/standard/styles_fonts.css	Rev. 1.179	(+14 -0 lines)
MODIFY	theme/standard/config.php	Rev. 1.29	(+57 -169 lines)

tjhunt committed 1 file to 'Moodle CVS' - 22/Jul/09 05:20 PM

quiz reports: Fix ordering of reports broken by MDL-16438.

MODIFY

mod/quiz/report/reportlib.php

Rev. 1.40

(+9 -11 lines)

tjhunt committed 1 file to 'Moodle CVS' - 24/Jul/09 12:05 PM

plugins: ~~MDL-19921~~ external database auth was not showing up.
This was a regression from MDL-16438

MODIFY

lib/moodlelib.php

Rev. 1.1231

(+7 -0 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.