Moodle

User and group pictures have hard-coded style tags for size and can't be overridden

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.3
  • Component/s: Themes
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

Styles should be removed so that themes can redefine the size

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Hmm. Martin, if you are taking out the hard-coded HTML, should you add corresponding style rules to the standard theme, so that the appearance of existing sites does not change?

Show
Tim Hunt added a comment - Hmm. Martin, if you are taking out the hard-coded HTML, should you add corresponding style rules to the standard theme, so that the appearance of existing sites does not change?
Hide
Permalink
Tim Hunt added a comment -

Martin explained that the images are already those pixel sizes, so there is no need for anything in the theme.

Show
Tim Hunt added a comment - Martin explained that the images are already those pixel sizes, so there is no need for anything in the theme.
Hide
Permalink
Helen Foster added a comment -

Martin, I notice that large group icons are still displayed in forum search results when using the moodle2 theme. Is this also due to hard-coded style tags?

Show
Helen Foster added a comment - Martin, I notice that large group icons are still displayed in forum search results when using the moodle2 theme. Is this also due to hard-coded style tags?
Hide
Permalink
Martin Dougiamas added a comment -

I added a selector for

#mod-forum-search img.grouppicture

in moodle2/moodle2.css so it now works on that page too.

Show
Martin Dougiamas added a comment - I added a selector for #mod-forum-search img.grouppicture in moodle2/moodle2.css so it now works on that page too.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.5#665-sha1:422aead) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.