Issue Details (XML | Word | Printable)

Key: MDL-16486
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Nicolas Connault
Reporter: Penny Leach
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

generator should support an array for assignment types to create (not just one or random)

Created: 13/Sep/08 05:44 PM   Updated: 28/Nov/08 01:45 AM
Return to search
Component/s: General
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Nicolas Connault, Penny Leach and Sam Marshall
Security Level: None
Resolved date: 16/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
as discussed awhile ago on jabber

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Nicolas Connault added a comment - 16/Sep/08 01:50 AM
Penny had the idea to pass an object instead of an array, to provide the generator with more info. This may not work well with the CLI version though

type: RANDOM, SEQUENCE
options: array(online, upload, single etc...) OR ALL


Nicolas Connault committed 3 files to 'Moodle CVS' - 16/Sep/08 03:33 PM
MDL-15666 MDL-16486
MODIFY mod/assignment/simpletest/test_assignment_portfolio_callers.php   Rev. 1.4    (+8 -4 lines)
MODIFY admin/generator.php   Rev. 1.15    (+70 -27 lines)
MODIFY mod/resource/simpletest/Attic/test_resource_portfolio_callers.php   Rev. 1.3    (+8 -3 lines)
[ Permalink | « Hide ]
Nicolas Connault added a comment - 16/Sep/08 03:38 PM - edited
You can now pass
1. A single string
2. An array of strings, in which case the RANDOM selection will apply
3. An object with two params
a. type: GENERATOR_RANDOM or GENERATOR_SEQUENCE
b. options: array of strings

The SEQUENCE selection uses the types in the order in which you entered them in the array, and keeps wrapping to the beginning.


Nicolas Connault made changes - 16/Sep/08 03:38 PM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Nicolas Connault committed 13 files to 'Moodle CVS' - 17/Sep/08 10:31 PM
MDL-15666 MDL-16486
MODIFY lib/simpletest/fixtures/gradetest.php   Rev. 1.44    (+8 -25 lines)
MODIFY lib/simpletest/portfolio_testclass.php   Rev. 1.6    (+5 -1 lines)
MODIFY lib/dml/simpletest/testdml.php   Rev. 1.16    (+1 -1 lines)
MODIFY mod/data/simpletest/testpreset.php   Rev. 1.8    (+2 -2 lines)
MODIFY lib/simpletestlib.php   Rev. 1.12    (+4 -2 lines)
MODIFY lib/adminlib.php   Rev. 1.271    (+104 -79 lines)
MODIFY lib/ddl/simpletest/testddl.php   Rev. 1.4    (+1 -1 lines)
MODIFY admin/index.php   Rev. 1.342    (+1 -11 lines)
MODIFY mod/glossary/simpletest/test_glossary_portfolio_callers.php   Rev. 1.4    (+0 -1 lines)
MODIFY lib/grade/simpletest/testgradegrades.php   Rev. 1.12    (+3 -3 lines)
MODIFY lib/simpletest/testportfolioaddbutton.php   Rev. 1.3    (+3 -14 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.25    (+42 -7 lines)
MODIFY lib/dml/simpletest/Attic/dbspecific.php   Rev. 1.3    (+1 -1 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 17/Sep/08 10:41 PM
MDL-15666 MDL-16486
MODIFY lib/simpletestlib.php   Rev. 1.13    (+3 -3 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 18/Sep/08 03:34 PM
MDL-16486 Fixed mistyped function call
MODIFY lib/adminlib.php   Rev. 1.275    (+2 -2 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 18/Sep/08 05:42 PM
MDL-16486 Added few cfg vars
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.26    (+20 -18 lines)
Nicolas Connault committed 2 files to 'Moodle CVS' - 18/Sep/08 06:05 PM
MDL-16486 changed unittest_prefix to unittestprefix
MODIFY lib/simpletestlib.php   Rev. 1.14    (+90 -27 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.27    (+7 -7 lines)
Nicolas Connault committed 3 files to 'Moodle CVS' - 18/Sep/08 09:43 PM
MDL-16486 Activated autopilot for test table install/upgrade
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.28    (+9 -3 lines)
MODIFY lib/Attic/scroll_to_errors.js   Rev. 1.4    (+17 -16 lines)
MODIFY lib/adminlib.php   Rev. 1.278    (+35 -23 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 18/Sep/08 10:32 PM
MDL-16486 Activated autopilot for test table install/upgrade
MODIFY lib/Attic/scroll_to_errors.js   Rev. 1.5    (+1 -1 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 18/Sep/08 11:26 PM
MDL-16486 Correctly overriding $DB at construct time.
MODIFY lib/simpletestlib.php   Rev. 1.15    (+4 -2 lines)
Nicolas Connault committed 5 files to 'Moodle CVS' - 19/Sep/08 10:28 PM
MDL-16486 Implemented the proxy DB class. Sort of working, but still some issues to sort out, like fix_course_sort_order, which updates a record NOT inserted by the unit test.
MODIFY mod/chat/simpletest/test_chat_portfolio_callers.php   Rev. 1.4    (+1 -5 lines)
MODIFY mod/resource/simpletest/Attic/test_resource_portfolio_callers.php   Rev. 1.4    (+2 -2 lines)
MODIFY mod/resource/lib.php   Rev. 1.104    (+3 -2 lines)
MODIFY lang/en_utf8/simpletest.php   Rev. 1.8    (+5 -1 lines)
MODIFY lib/simpletestlib.php   Rev. 1.16    (+205 -24 lines)
martignoni committed 1 file to 'Lang CVS' - 20/Sep/08 04:05 PM
MDL-16486, new strings
MODIFY fr_utf8/simpletest.php   Rev. 1.7    (+5 -1 lines)
Mitsuhiro Yoshida committed 3 files to 'Lang CVS' - 21/Sep/08 12:01 AM
MDL-16486 - Translated new strings for simpletest.
MDL-16384 - Adding a translated lang file for alfresco plugin.
ADD ja_utf8/repository_alfresco.php   Rev. 1.1    (+0 -0 lines)
MODIFY ja_utf8/simpletest.php   Rev. 1.11    (+5 -1 lines)
MODIFY ja_utf8/README   Rev. 1.819    (+1 -1 lines)
Nicolas Connault committed 4 files to 'Moodle CVS' - 22/Sep/08 03:06 PM
MDL-16486 Only using one test $DB connection. Completed most of the implementation. Tests working well now.
MODIFY lib/simpletest/fixtures/gradetest.php   Rev. 1.45    (+5 -527 lines)
MODIFY lang/en_utf8/simpletest.php   Rev. 1.9    (+2 -1 lines)
MODIFY lib/simpletestlib.php   Rev. 1.17    (+23 -18 lines)
MODIFY mod/forum/lib.php   Rev. 1.741    (+9 -7 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 22/Sep/08 03:23 PM
MDL-16486 - Translated a new string for simple test.
MODIFY ja_utf8/simpletest.php   Rev. 1.12    (+1 -0 lines)
MODIFY ja_utf8/README   Rev. 1.820    (+1 -1 lines)
Nicolas Connault committed 3 files to 'Moodle CVS' - 22/Sep/08 04:54 PM
MDL-16486 Implemented test DB upgrade, needs further testing
MODIFY lib/adminlib.php   Rev. 1.279    (+18 -12 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.29    (+37 -4 lines)
MODIFY lang/en_utf8/simpletest.php   Rev. 1.10    (+5 -1 lines)
Mitsuhiro Yoshida committed 2 files to 'Lang CVS' - 23/Sep/08 01:03 AM
MDL-16486 - Translated new strings for simple test.
MODIFY ja_utf8/README   Rev. 1.821    (+1 -1 lines)
MODIFY ja_utf8/simpletest.php   Rev. 1.13    (+4 -0 lines)
Nicolas Connault committed 1 file to 'Moodle CVS' - 23/Sep/08 01:11 PM
MDL-16486 Flushing output buffer between each test, and fixed problem with update/delete of course_categories and context_temp
MODIFY lib/simpletestlib.php   Rev. 1.18    (+10 -4 lines)
Nicolas Connault committed 3 files to 'Moodle CVS' - 23/Sep/08 02:42 PM
MDL-16486 Improved interface, added permission warning and other minor fixes
MODIFY lang/en_utf8/simpletest.php   Rev. 1.11    (+5 -1 lines)
MODIFY admin/report/simpletest/Attic/index.php   Rev. 1.30    (+44 -30 lines)
MODIFY config-dist.php   Rev. 1.110    (+2 -1 lines)
Mitsuhiro Yoshida committed 7 files to 'Lang CVS' - 24/Sep/08 12:30 PM
MDL-10107, MDL-16267 - Updated translated strings for Messaging interface based on lang/en_utf8 change.
MDL-15488 - Translated a new string for repository.
MDL-16486 - Translated new strings for simple test.
MODIFY ja_utf8/messageprocessor_jabber.php   Rev. 1.2    (+3 -2 lines)
MODIFY ja_utf8/message.php   Rev. 1.21    (+7 -7 lines)
MODIFY ja_utf8/messageprocessor_popup.php   Rev. 1.2    (+2 -2 lines)
MODIFY ja_utf8/repository.php   Rev. 1.28    (+2 -1 lines)
MODIFY ja_utf8/README   Rev. 1.822    (+1 -1 lines)
MODIFY ja_utf8/admin.php   Rev. 1.305    (+2 -2 lines)
MODIFY ja_utf8/simpletest.php   Rev. 1.14    (+5 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 11/Oct/08 08:12 PM
MDL-16486 String translated
MODIFY fr_utf8/simpletest.php   Rev. 1.9    (+2 -1 lines)
martignoni committed 1 file to 'Lang CVS' - 13/Oct/08 04:37 AM
MDL-16486 new strings translated
MODIFY fr_utf8/simpletest.php   Rev. 1.10    (+6 -2 lines)
martignoni committed 1 file to 'Lang CVS' - 13/Oct/08 04:44 AM
MDL-16486 Strings translated
MODIFY fr_utf8/simpletest.php   Rev. 1.11    (+4 -1 lines)
[ Permalink | « Hide ]
Sam Marshall added a comment - 28/Nov/08 01:45 AM
Nicolas: Why is simpletestlib.php 210 (truncate_test_tables) commented out? (Not sure why it's to do with this bug but apparently it is according to the commit comment...)


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators