[#MDL-16493] File storage conversion Database

Issue Details (XML | Word | Printable)

Key:	MDL-16493
Type:	Sub-task
Status:	Open
Priority:	Major
Assignee:	Petr Skoda
Reporter:	Petr Skoda
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-14589

File storage conversion Database

Created: 14/Sep/08 04:21 PM Updated: 17/Sep/08 03:02 AM

Return to search

Component/s:

Database activity module

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Penny Leach and Petr Skoda
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 18 files to 'Moodle CVS' - 14/Sep/08 04:22 PM

MDL-16493 file and picture element migrated; waiting for file picker to mature, presets not finished yet

MODIFY	mod/data/view.php	Rev. 1.99	(+11 -11 lines)
MODIFY	mod/data/field/picture/field.class.php	Rev. 1.29	(+124 -169 lines)
MODIFY	mod/data/version.php	Rev. 1.40	(+2 -2 lines)
MODIFY	mod/data/field/text/field.class.php	Rev. 1.10	(+1 -5 lines)
MODIFY	mod/data/field/textarea/field.class.php	Rev. 1.24	(+1 -6 lines)
MODIFY	mod/data/field/multimenu/field.class.php	Rev. 1.19	(+1 -6 lines)
MODIFY	mod/data/field/date/field.class.php	Rev. 1.12	(+1 -5 lines)
DEL	mod/data/Attic/preset_new.php	Rev. 1.6	(+0 -0 lines)
MODIFY	mod/data/field/menu/field.class.php	Rev. 1.17	(+1 -5 lines)
MODIFY	mod/data/db/upgrade.php	Rev. 1.23	(+86 -4 lines)
MODIFY	mod/data/field/number/field.class.php	Rev. 1.12	(+1 -5 lines)
MODIFY	mod/data/field/latlong/field.class.php	Rev. 1.16	(+1 -5 lines)
MODIFY	mod/data/field/url/field.class.php	Rev. 1.19	(+1 -5 lines)
MODIFY	mod/data/field/radiobutton/field.class.php	Rev. 1.13	(+1 -6 lines)
MODIFY	mod/data/lib.php	Rev. 1.201	(+170 -73 lines)
MODIFY	mod/data/field/checkbox/field.class.php	Rev. 1.18	(+1 -5 lines)
DEL	mod/data/Attic/preset_class.php	Rev. 1.9	(+0 -0 lines)
MODIFY	mod/data/field/file/field.class.php	Rev. 1.27	(+64 -58 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 14/Sep/08 04:23 PM

file and picture element migrated
waiting for file picker to mature - more pickers on one form, etc. - we will steal the integration code from filepicker forms element
presets not finished yet

[ Permalink | « Hide ]

Petr Skoda added a comment - 14/Sep/08 06:06 PM

after spending several hours on preset files I have decided to add a new table instead - it should be far more flexible and much easier to implement :-D

[ Permalink | « Hide ]

Penny Leach added a comment - 16/Sep/08 11:23 PM

Why did you make data_field_picture subclass data_field_base directly rather than data_field_file?

That causes some yuk special cases for me which is fine if there's a good reason - just wondering what it is..

http://cvs.moodle.org/moodle/mod/data/field/picture/field.class.php?r1=1.28&r2=1.29

mjollnir_ committed 3 files to 'Moodle CVS' - 16/Sep/08 11:48 PM

~~MDL-15777~~ - updated data file and picture field types to export files using file api.

There's still something about this I don't like - documented in MDL-16493 and code

MODIFY	mod/data/lib.php	Rev. 1.202	(+39 -10 lines)
MODIFY	mod/data/field/picture/field.class.php	Rev. 1.30	(+18 -1 lines)
MODIFY	mod/data/field/file/field.class.php	Rev. 1.28	(+17 -3 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 17/Sep/08 03:02 AM

I did that because it does not share any method anymore, all methods from file are overriden.
We can change it back, but what would be the benefit?

All content on this web site is made available under the GNU General Public License, unless otherwise stated.