[#MDL-16583] Clean up JavaScript usage in HEAD

Issue Details (XML | Word | Printable)

Key:	MDL-16583
Type:	Improvement
Status:	Open
Priority:	Minor
Assignee:	Sam Hemelryk
Reporter:	Tim Hunt
Votes:	2
Watchers:	7

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

Clean up JavaScript usage in HEAD

Created: 19/Sep/08 01:40 PM Updated: 18/Jun/09 03:57 PM

Return to search

Component/s:

Lib

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Duplicate

This issue is duplicated by:

~~MDL-18809~~ Call javascript files in footer rather then calling it in header of themes

Participants:	Eloy Lafuente (stronk7), Sam Hemelryk and Tim Hunt
Security Level:	None
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Sub-Tasks:

All

Open

Sub-Task Progress:

1.	~~Change admintree JavaScript to move the code out of the page, and into a separate .js file.~~	Resolved	Tim Hunt
2.	~~Move openpopup out of javascript.php and in to javascript-static.js~~	Resolved	Tim Hunt
3.	~~Output a standard set of config variables into JavaScript on every page~~	Resolved	Tim Hunt
4.	~~Move inserttext out of javascript.php and in to javascript-static.js~~	Resolved	Tim Hunt
5.	~~Emoticons help file contains JavaScript to insert the emoticons, but it won't acutally work in a lot of situations~~	Resolved	Tim Hunt
6.	~~Change require_js so that callers don't have to fiddly around with $CFG->wwwroot~~	Resolved	Tim Hunt
7.	~~Change require_js so JavaScript is included in the page footer by default, but with an option to output it sooner~~	Resolved	Tim Hunt
8.	~~Make a new requirements_manager to hold the implementation of requrie_js and friends~~	Resolved	Tim Hunt
9.	~~Remove unnecessary JavaScript from bulk user enrol page~~	Resolved	Tim Hunt
10.	~~Allow JavaScript to set user preferences~~	Resolved	Tim Hunt
11.	~~Add a CSS class name to <body> when JavaScript is enabled~~	Resolved	Tim Hunt
12.	~~We don't need a function called uncheckall, as well as one called checknone!~~	Resolved	Tim Hunt
13.	~~Replace all calls to require_js with $PAGE->requries->js~~	Resolved	Tim Hunt
14.	~~Clean up all the places we link to javascript files, to use $PAGE->requires->js~~	Resolved	Sam Hemelryk
15.	~~Clean up message Javascript code~~	Resolved	Sam Hemelryk
16.	~~JavaScript for setting target=XX on links based on a CSS class~~	Resolved	Sam Hemelryk
17.	Modification to improve javascript and css header insertion for blocks, modules and filters	Open	Tim Hunt
18.	Split javascript-static.js into a small file included in <head> and the rest that can be included in the footer	In Progress	Sam Hemelryk
19.	Eliminate other inline scripts	Open	Sam Hemelryk
20.	Remove inline JavaScript from backup/backup_form.html	Open	Sam Hemelryk
21.	~~Move tagging JavaScript out of the HTML~~	Resolved	Sam Hemelryk
22.	Clean up grader report JavaScript	Open	moodle.com
23.	cleanup filepicker code to require css and js before printing head	Open	Petr Skoda
24.	~~Clean up lib/overlib/overlib.js if possible~~	Resolved	Sam Hemelryk
25.	~~Clean up lib/overlib/overlib_cssstyle.js if possible~~	Resolved	Sam Hemelryk
26.	~~Clean up lib/cookies.js if possible~~	Resolved	Sam Hemelryk
27.	~~Clean up lib/ufo.js is possible~~	Resolved	Sam Hemelryk
28.	~~Clean up lib/dropdown.js if possible~~	Resolved	Sam Hemelryk
29.	Search and replace code that uses the old method of focus and change it to the new	Open	Sam Hemelryk

Description

« Hide

See the sub tasks for details.

All

Comments

Change History

Version Control

Sort Order:

tjhunt committed 6 files to 'Moodle CVS' - 23/Sep/08 03:00 PM

MDL-16583 - Clean up some fo the places we link to javascript files, to use require_js

MODIFY	calendar/lib.php	Rev. 1.227	(+3 -3 lines)
MODIFY	grade/report/grader/index.php	Rev. 1.78	(+3 -3 lines)
MODIFY	admin/xmldb/Attic/javascript.php	Rev. 1.5	(+2 -2 lines)
MODIFY	course/report/progress/index.php	Rev. 1.9	(+1 -1 lines)
MODIFY	tag/coursetagslib.php	Rev. 1.3	(+3 -2 lines)
MODIFY	course/view.php	Rev. 1.116	(+10 -10 lines)

tjhunt committed 2 files to 'Moodle CVS' - 24/Sep/08 05:32 PM

MDL-16583 - Clean up javascript: Move some static scripts out of javascript.php and into javascript-static.js. Also, ensure the HTML editor JS is only included if the user has chosen to use the HTML editor.

MODIFY	lib/javascript-static.js		Rev. 1.43		(+46 -0 lines)
MODIFY	lib/Attic/javascript.php		Rev. 1.43		(+19 -64 lines)

tjhunt committed 3 files to 'Moodle CVS' - 25/Sep/08 02:29 PM

MDL-16583 Make require_js accept library names like lib/javascript-static.js without the caller having to fiddle around with $CFG->wwwroot themselves.

ADD	lib/ajax/simpletest/testajaxlib.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/weblib.php	Rev. 1.1151	(+18 -17 lines)
MODIFY	lib/ajax/ajaxlib.php	Rev. 1.47	(+7 -5 lines)

tjhunt committed 1 file to 'Moodle CVS' - 26/Sep/08 04:22 PM

MDL-16583 switch to print_js_call

MODIFY

admin/report/capability/index.php

Rev. 1.6

(+2 -2 lines)

tjhunt committed 3 files to 'Moodle CVS' - 10/Dec/08 05:57 PM

javascript cleanup: MDL-16583 clean up the close_window function in weblib.php.

MODIFY	lib/javascript-static.js	Rev. 1.55	(+16 -0 lines)
MODIFY	lib/weblib.php	Rev. 1.1185	(+24 -19 lines)
MODIFY	lang/en_utf8/moodle.php	Rev. 1.219	(+2 -1 lines)

martignoni committed 1 file to 'Lang CVS' - 10/Dec/08 07:45 PM

New string for MDL-16583

MODIFY

fr_utf8/moodle.php

Rev. 1.266

(+2 -1 lines)

Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 11/Dec/08 01:36 PM

MDL-17429 ~~MDL-16867~~ Translated new strings fro admin.
MDL-16583 Translated a new string for the close_window function.
~~MDL-17575~~ Translated a new string for role.

MODIFY	ja_utf8/admin.php	Rev. 1.323	(+8 -2 lines)
MODIFY	ja_utf8/moodle.php	Rev. 1.338	(+3 -2 lines)
MODIFY	ja_utf8/README	Rev. 1.889	(+1 -1 lines)
MODIFY	ja_utf8/role.php	Rev. 1.85	(+2 -1 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.