[#MDL-16596] Formslib element: filemanager (non-JS)

Issue Details (XML | Word | Printable)

Key:	MDL-16596
Type:	Sub-task
Status:	Reopened
Priority:	Major
Assignee:	Dongsheng Cai
Reporter:	Petr Skoda
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-14589

Formslib element: filemanager (non-JS)

Created: 21/Sep/08 04:23 AM Updated: 04/Aug/09 01:46 PM

Return to search

Component/s:

Files API, Forms Library

Affects Version/s:

2.0

Fix Version/s:

2.0

File Attachments:

File manager interface (root).bmml (3 kB)

Image Attachments:

1. File manager interface (root).png
(45 kB)

Issue Links:

Relates

This issue has been marked as being related by:

MDL-16597 Formslib element: filemanager (JS)

Participants:	Dongsheng Cai, Martin Dougiamas and Petr Skoda
Security Level:	None
Resolved date:	21/Sep/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

new forms element primarily used for managing of multiple file attachments

1/ first version that do not needs javascript - plain old upload form and embedded file manager
2/ ajax version

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda committed 9 files to 'Moodle CVS' - 21/Sep/08 04:56 AM

MDL-16596 basic areafiles formslib element

MODIFY	lib/file/file_info_coursefile.php	Rev. 1.5	(+2 -2 lines)
MODIFY	lib/file/file_info_stored.php	Rev. 1.6	(+17 -10 lines)
MODIFY	lib/filelib.php	Rev. 1.100	(+44 -16 lines)
MODIFY	lib/formslib.php	Rev. 1.158	(+3 -2 lines)
ADD	files/Attic/areafiles.php	Rev. 1.1	(+0 -0 lines)
MODIFY	mod/scorm/lib.php	Rev. 1.106	(+2 -2 lines)
ADD	lib/form/Attic/areafiles.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/file/file_browser.php	Rev. 1.12	(+13 -9 lines)
MODIFY	draftfile.php	Rev. 1.6	(+6 -3 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 21/Sep/08 04:56 AM

basic version in cvs, going to file new issue for 2/

Petr Skoda made changes - 21/Sep/08 04:56 AM

Field	Original Value	New Value
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Petr Skoda made changes - 21/Sep/08 04:59 AM

Link

This issue has been marked as being related by MDL-16597 [ MDL-16597 ]

[ Permalink | « Hide ]

Petr Skoda added a comment - 21/Sep/08 06:31 PM - edited

reopening - found a better way - yay!
going to move the area files to draft area also when editing existing content - benefits:

less code
more secure
we can also cancel all file operations on form
upload limits and other server side validation will be much easier
it will be easier to understand too

testing patch - going to commit it today

Petr Skoda made changes - 21/Sep/08 06:31 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Petr Skoda committed 1 file to 'Moodle CVS' - 21/Sep/08 06:32 PM

MDL-16596 always force download of draft files - this prevents problems when editing area with file suploaded by otehr users

MODIFY

draftfile.php

Rev. 1.7

(+2 -3 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 21/Sep/08 06:33 PM

MDL-16596 adding missing get_pathnamehash() method

MODIFY

lib/file/stored_file.php

Rev. 1.13

(+5 -1 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 21/Sep/08 06:35 PM

MDL-16596 file listing methods now return arrays index with pathnamehash (useful when looking for existing files); create from stored file now supports directories too - very useful when moving files between areas

MODIFY

lib/file/file_storage.php

Rev. 1.25

(+21 -9 lines)

Petr Skoda committed 4 files to 'Moodle CVS' - 21/Sep/08 11:37 PM

MDL-16596 reworked areafiles element

MODIFY	lib/form/Attic/areafiles.php	Rev. 1.2	(+29 -40 lines)
ADD	files/draftfiles.php	Rev. 1.1	(+0 -0 lines)
MODIFY	lib/filelib.php	Rev. 1.101	(+107 -20 lines)
DEL	files/Attic/areafiles.php	Rev. 1.2	(+0 -0 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 21/Sep/08 11:54 PM

MDL-16596 adding missing get_pathnamehash() method

MODIFY

lib/file/virtual_root_file.php

Rev. 1.2

(+6 -1 lines)

Petr Skoda committed 2 files to 'Moodle CVS' - 22/Sep/08 03:53 AM

MDL-16596 adding missing get_parent_directory() method

MODIFY	lib/file/stored_file.php		Rev. 1.14		(+25 -1 lines)
MODIFY	lib/file/virtual_root_file.php		Rev. 1.3		(+9 -1 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 22/Sep/08 03:54 AM

MDL-16596 improved and simplified draftarea browsing

MODIFY

files/draftfiles.php

Rev. 1.2

(+76 -148 lines)

Petr Skoda committed 3 files to 'Moodle CVS' - 22/Sep/08 04:45 AM

MDL-16596 support for restricting of subdirectory browsing/upload

MODIFY	lib/form/Attic/areafiles.php	Rev. 1.3	(+10 -8 lines)
MODIFY	lib/filelib.php	Rev. 1.102	(+18 -7 lines)
MODIFY	files/draftfiles.php	Rev. 1.3	(+33 -22 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 22/Sep/08 04:48 AM

MDL-16596 support for restricting of subdirectory browsing/upload - getter and setter methods

MODIFY

lib/form/Attic/areafiles.php

Rev. 1.4

(+21 -2 lines)

Petr Skoda committed 4 files to 'Moodle CVS' - 22/Sep/08 05:29 AM

MDL-16596 support for total maxbytes per draft area - proper server-side validation still missing; some minor refactoring

MODIFY	lib/form/Attic/areafiles.php	Rev. 1.5	(+8 -4 lines)
MODIFY	lib/formslib.php	Rev. 1.159	(+5 -39 lines)
MODIFY	lib/filelib.php	Rev. 1.103	(+50 -1 lines)
MODIFY	files/draftfiles.php	Rev. 1.4	(+61 -26 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 22/Sep/08 05:30 AM

MDL-16596 fixed comment

MODIFY

files/draftfiles.php

Rev. 1.5

(+1 -2 lines)

Petr Skoda committed 1 file to 'Moodle CVS' - 23/Sep/08 06:56 AM

MDL-16596 minor constructor improvements

MODIFY

lib/form/Attic/areafiles.php

Rev. 1.6

(+8 -5 lines)

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 24/Sep/08 02:15 PM

Move or copy?

If you are moving the files while editing, won't that break the content for others while it is being edited?

[ Permalink | « Hide ]

Petr Skoda added a comment - 24/Sep/08 02:28 PM

sure, only copying

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 26/Sep/08 11:36 AM

Can I suggest renaming this "filemanager" or "filepickermulti" to make it more consistent for new developers approaching the API from the outside.

Martin Dougiamas made changes - 26/Sep/08 11:36 AM

Summary

areafiles formslib element

Forms element: areafiles

Martin Dougiamas made changes - 26/Sep/08 11:36 AM

Summary

Forms element: areafiles

Forms element: areafiles (non-JS)

Martin Dougiamas made changes - 26/Sep/08 01:29 PM

Summary

Forms element: areafiles (non-JS)

Formslib element: areafiles (non-JS)

Petr Skoda committed 1 file to 'Moodle CVS' - 20/Nov/08 05:24 AM

MDL-16596 areafiles improvements

MODIFY

lib/form/Attic/areafiles.php

Rev. 1.7

(+10 -2 lines)

Petr Skoda committed 3 files to 'Moodle CVS' - 20/Nov/08 05:27 AM

MDL-16596 areafiles element renamed to "filemanager"

MODIFY	lib/formslib.php	Rev. 1.166	(+3 -3 lines)
ADD	lib/form/filemanager.php	Rev. 1.1	(+0 -0 lines)
DEL	lib/form/Attic/areafiles.php	Rev. 1.8	(+0 -0 lines)

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 20/Nov/08 10:35 AM

Renamed from "areafiles"

Martin Dougiamas made changes - 20/Nov/08 10:35 AM

Summary

Formslib element: areafiles (non-JS)

Formslib element: filemanager (non-JS)

[ Permalink | « Hide ]

Martin Dougiamas added a comment - 20/Nov/08 10:43 AM

Currently there is no support in draftfiles.php (which provides the content for filemanager) for the file picker - this needs to be changed.

Dongsheng Cai made changes - 12/Jun/09 01:51 PM

Assignee

Petr Skoda [ skodak ]

Dongsheng Cai [ dongsheng ]

Dongsheng Cai committed 1 file to 'Moodle CVS' - 12/Jun/09 01:59 PM

"MDL-16596, remove inline css from filemanager"

MODIFY

lib/form/filemanager.php

Rev. 1.20

(+1 -4 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 04/Aug/09 01:46 PM

Added UI Mockup: <File manager interface (root)>

Dongsheng Cai committed 1 file to 'Moodle CVS' - 02/Sep/09 01:43 PM

"MDL-16596, improved non-js filemanager, 1. supported subfolder 2. browse draft area 3. create new folder 4. zip folder & unzip archiev"

MODIFY

repository/filepicker.php

Rev. 1.19

(+193 -49 lines)

Dongsheng Cai committed 3 files to 'Moodle CVS' - 03/Sep/09 02:53 PM

"MDL-16596, imporve non-javascript file manager, add useful functions to filelib"

MODIFY	lib/filelib.php	Rev. 1.161	(+107 -0 lines)
MODIFY	repository/filepicker.php	Rev. 1.20	(+12 -13 lines)
MODIFY	lang/en_utf8/repository.php	Rev. 1.61	(+7 -2 lines)

Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 03/Sep/09 03:29 PM

MDL-16596 Translated new strings for repository.

MODIFY

ja_utf8/repository.php

Rev. 1.49

(+7 -2 lines)

Dongsheng Cai committed 4 files to 'Moodle CVS' - 04/Sep/09 02:48 PM

"MDL-16596, make non-js filemanager identical to ajax filemanager, added more language strings"

MODIFY	lang/en_utf8/moodle.php	Rev. 1.253	(+3 -1 lines)
MODIFY	lang/en_utf8/repository.php	Rev. 1.62	(+6 -2 lines)
MODIFY	repository/filepicker.php	Rev. 1.21	(+212 -59 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.200	(+2 -1 lines)

Mitsuhiro Yoshida committed 7 files to 'Lang CVS' - 07/Sep/09 02:08 PM

MDL-19676 Translated new Blog related strings.
MDL-16596 Translated new Filemanager related strings.

MODIFY	ja_utf8/moodle.php	Rev. 1.372	(+3 -1 lines)
MODIFY	ja_utf8/README	Rev. 1.1053	(+1 -1 lines)
MODIFY	ja_utf8/error.php	Rev. 1.147	(+2 -1 lines)
MODIFY	ja_utf8/blog.php	Rev. 1.36	(+39 -4 lines)
MODIFY	ja_utf8/assignment.php	Rev. 1.41	(+6 -2 lines)
MODIFY	ja_utf8/repository.php	Rev. 1.50	(+5 -1 lines)
MODIFY	ja_utf8/admin.php	Rev. 1.366	(+3 -1 lines)

martignoni committed 1 file to 'Lang CVS' - 18/Sep/09 01:13 AM

MDL-16596 New strings

MODIFY

fr_utf8/repository.php

Rev. 1.64

(+7 -2 lines)

martignoni committed 3 files to 'Lang CVS' - 18/Sep/09 01:20 AM

MDL-16596 New strings

MODIFY	fr_utf8/error.php	Rev. 1.204	(+1 -0 lines)
MODIFY	fr_utf8/repository.php	Rev. 1.65	(+6 -2 lines)
MODIFY	fr_utf8/moodle.php	Rev. 1.310	(+2 -0 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.