Moodle

If a role is given permission to import course but not to backup a course, it won't work

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.9.2
  • Fix Version/s: STABLE backlog
  • Component/s: Roles / Access
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE

Description

Suppose you give teachers a permission to import a course, but you remove permissions to create and restore backups. Then the teachers will not be able to use their capability to import courses, because during the import process, they will arrive at the /backup/backup.php?id=5&to=4 page, where they will get an error message saying "You need to be a teacher or admin user to use this page"

Issue Links

This issue duplicates:
MDL-25992 Not Fixed - Teachers cannot import courses despite moodle/site:import = allow Major Open
MDL-12081 Teachers cannot import courses despite moodle/site:import = allow Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

Eloy, are you working on this?

Show
Petr Škoda (skodak) added a comment - Eloy, are you working on this?
Hide
Permalink
Petr Škoda (skodak) added a comment -

it is very sad, but the import functionality is built on top of backup/restore - unfortunately it woudl require major rewrite to make it work separately, I am afraid this will have to wait till 2.0

Show
Petr Škoda (skodak) added a comment - it is very sad, but the import functionality is built on top of backup/restore - unfortunately it woudl require major rewrite to make it work separately, I am afraid this will have to wait till 2.0
Hide
Permalink
Przemyslaw Stencel added a comment -

Sorry to hear that But I guess there are other priorities now.

Show
Przemyslaw Stencel added a comment - Sorry to hear that But I guess there are other priorities now.
Hide
Permalink
Petr Škoda (skodak) added a comment -

The biggest priority is to get the backup/restore + course import/export right in 2.0, in any case thanks for the report, I did not expect myself that it works this way

Show
Petr Škoda (skodak) added a comment - The biggest priority is to get the backup/restore + course import/export right in 2.0, in any case thanks for the report, I did not expect myself that it works this way
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

grrr... after fixing all the pending security bugs for 1.9.7 I'll try this one... I think it can be fixed (only think).

Offtopic, Przemyslaw when I saw this... I got confused with another bug I closed as duplicate recently from you... can you point me to it, plz? I've somehow one big confusion and want to re-read it just to be sure it was properly closed... TIA!

Show
Eloy Lafuente (stronk7) added a comment - grrr... after fixing all the pending security bugs for 1.9.7 I'll try this one... I think it can be fixed (only think). Offtopic, Przemyslaw when I saw this... I got confused with another bug I closed as duplicate recently from you... can you point me to it, plz? I've somehow one big confusion and want to re-read it just to be sure it was properly closed... TIA!
Hide
Permalink
Przemyslaw Stencel added a comment -

Eloy,
The one you closed recently was MDL-20837 - is that what you're looking for?
Cheers,
Przemek

Show
Przemyslaw Stencel added a comment - Eloy, The one you closed recently was MDL-20837 - is that what you're looking for? Cheers, Przemek
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Ah, thanks Przemek.

Was correctly closed with new caps and passwords out from backup files coming soon. For a moment I thought it was related to other backup parts. Sorry for the confusion... and re-thanks!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Ah, thanks Przemek. Was correctly closed with new caps and passwords out from backup files coming soon. For a moment I thought it was related to other backup parts. Sorry for the confusion... and re-thanks! Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Targeting to 1.9.8. Let's see how to handle this after 1.9.7 release within hours

Show
Eloy Lafuente (stronk7) added a comment - Targeting to 1.9.8. Let's see how to handle this after 1.9.7 release within hours
Hide
Permalink
Petr Škoda (skodak) added a comment -

retargeting, sorry

Show
Petr Škoda (skodak) added a comment - retargeting, sorry
Hide
Permalink
Petr Škoda (skodak) added a comment -

moving target once more, sorry

Show
Petr Škoda (skodak) added a comment - moving target once more, sorry
Hide
Permalink
Jonathan Langevin added a comment -

How does this bug still exist? The same issue was fixed in another bug report in 2007 (but I'm still experiencing same issue)?

Show
Jonathan Langevin added a comment - How does this bug still exist? The same issue was fixed in another bug report in 2007 (but I'm still experiencing same issue)?
Hide
Permalink
Petr Škoda (skodak) added a comment -

Hello,
this is most probably not going to be fixed in 1.9.x because the code that implements imports was only a "temporary" solution (we sometimes call it an ugly hack). Fixing it would require major changes, unfortunately major changes are usually not allowed in stable branches.

This should be already fixed in 2.0, sorry for the bad news.

Petr

Show
Petr Škoda (skodak) added a comment - Hello, this is most probably not going to be fixed in 1.9.x because the code that implements imports was only a "temporary" solution (we sometimes call it an ugly hack). Fixing it would require major changes, unfortunately major changes are usually not allowed in stable branches. This should be already fixed in 2.0, sorry for the bad news. Petr

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.