[#MDL-16654] Emoticons help file contains JavaScript to insert the emoticons, but it won't acutally work in a lot of situations - Moodle Tracker

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0
Fix Version/s: 2.0
Component/s: Libraries
Labels:
None

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_20_STABLE

Description

It relies on storing the id of the most recently output textarea in the session, which is then used to generate some JavaScript on the fly when that help page is shown. This will fail on pages with more that one HTML editor, or where the users is browsing in multiple tabs. I think we should just eliminate this feature, especially because the JavaScript is added to every single page that Moodle loads.

Issue Links

This issue is duplicated by:
MDL-16674	Move inserttext out of javascript.php and in to javascript-static.js

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Hunt added a comment - 24/Sep/08 6:23 PM

This misfeature dates from at least Moodle 1.3 times:

http://cvs.moodle.org/moodle/lang/en/help/emoticons.html?hideattic=0&revision=1.1&view=markup

At the very least, the JavaScript should be moved so it is only added to that help page.

Show

Tim Hunt added a comment - 24/Sep/08 6:23 PM This misfeature dates from at least Moodle 1.3 times: http://cvs.moodle.org/moodle/lang/en/help/emoticons.html?hideattic=0&revision=1.1&view=markup At the very least, the JavaScript should be moved so it is only added to that help page.

Hide

Permalink

Tim Hunt added a comment - 25/Sep/08 11:17 AM

Actually, I have now worked out how to clean up the code, so I'll do that.

Show

Tim Hunt added a comment - 25/Sep/08 11:17 AM Actually, I have now worked out how to clean up the code, so I'll do that.

People

Assignee:

Tim Hunt

Reporter:

Tim Hunt

Participants:

Tim Hunt

Vote (0)

Watch (1)

Dates

Created:

24/Sep/08 6:21 PM

Updated:

17/Dec/10 12:51 PM

Resolved:

25/Sep/08 6:07 PM