Issue Details (XML | Word | Printable)

Key: MDL-16654
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-16583

Emoticons help file contains JavaScript to insert the emoticons, but it won't acutally work in a lot of situations

Created: 24/Sep/08 06:21 PM   Updated: 25/Sep/08 06:07 PM
Return to search
Component/s: Lib
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Duplicate
 

Participants: Tim Hunt
Security Level: None
Resolved date: 25/Sep/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
It relies on storing the id of the most recently output textarea in the session, which is then used to generate some JavaScript on the fly when that help page is shown. This will fail on pages with more that one HTML editor, or where the users is browsing in multiple tabs. I think we should just eliminate this feature, especially because the JavaScript is added to every single page that Moodle loads.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt added a comment - 24/Sep/08 06:23 PM
This misfeature dates from at least Moodle 1.3 times:

http://cvs.moodle.org/moodle/lang/en/help/emoticons.html?hideattic=0&revision=1.1&view=markup

At the very least, the JavaScript should be moved so it is only added to that help page.


Tim Hunt added a comment - 25/Sep/08 11:17 AM
Actually, I have now worked out how to clean up the code, so I'll do that.