| Key: |
MDL-16654
|
| Type: |
Sub-task
|
| Status: |
Resolved
|
| Resolution: |
Fixed
|
| Priority: |
Major
|
| Assignee: |
Tim Hunt
|
| Reporter: |
Tim Hunt
|
| Votes: |
0
|
| Watchers: |
1
|
|
|
|
Issue Links:
|
Duplicate
|
|
|
|
This issue is duplicated by:
|
|
MDL-16674
Move inserttext out of javascript.php and in to javascript-static.js
|
|
|
|
|
|
|
| Participants: |
Tim Hunt
|
| Security Level: |
None
|
| Resolved date: |
25/Sep/08
|
| Affected Branches: |
MOODLE_20_STABLE
|
| Fixed Branches: |
MOODLE_20_STABLE
|
|
It relies on storing the id of the most recently output textarea in the session, which is then used to generate some JavaScript on the fly when that help page is shown. This will fail on pages with more that one HTML editor, or where the users is browsing in multiple tabs. I think we should just eliminate this feature, especially because the JavaScript is added to every single page that Moodle loads.
|
|
Description
|
It relies on storing the id of the most recently output textarea in the session, which is then used to generate some JavaScript on the fly when that help page is shown. This will fail on pages with more that one HTML editor, or where the users is browsing in multiple tabs. I think we should just eliminate this feature, especially because the JavaScript is added to every single page that Moodle loads. |
Show » |
made changes - 25/Sep/08 11:15 AM
| Field |
Original Value |
New Value |
|
Parent
|
|
MDL-16583
[ 28539
]
|
|
Issue Type
|
Bug
[ 1
]
|
Sub-task
[ 5
]
|
made changes - 25/Sep/08 11:15 AM
|
Link
|
|
This issue is duplicated by MDL-16674
[ MDL-16674
]
|
tjhunt committed 5 files to 'Moodle CVS' - 25/Sep/08 06:07 PM
MDL-16654 Move javascript used by the emoticons help file from javascript.php to javascript-static.js. Fix it so that it actually works.
|
|
|
made changes - 25/Sep/08 06:07 PM
|
Fix Version/s
|
|
2.0
[ 10122
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
|
Status
|
Open
[ 1
]
|
Resolved
[ 5
]
|
martignoni committed 1 file to 'Lang CVS' - 25/Sep/08 10:52 PM
|
http://cvs.moodle.org/moodle/lang/en/help/emoticons.html?hideattic=0&revision=1.1&view=markup
At the very least, the JavaScript should be moved so it is only added to that help page.