[#MDL-16669] Make sql_substr() to accept parameters instead of simply returning function name

Issue Details (XML | Word | Printable)

Key:	MDL-16669
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Petr Skoda
Reporter:	Eloy Lafuente (stronk7)
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-14679

Make sql_substr() to accept parameters instead of simply returning function name

Created: 25/Sep/08 05:27 AM Updated: 29/Oct/08 04:09 AM

Return to search

Component/s:

Database SQL/XMLDB

Affects Version/s:

2.0

Fix Version/s:

2.0

Participants:	Eloy Lafuente (stronk7) and Petr Skoda
Security Level:	None
QA Assignee:	Petr Skoda
Resolved date:	29/Oct/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

Until Moodle 2.0, the sql_substr() helper function (dmllib), is used without parameters at simply returns the "substring" function used for each DB.

Change this behaviour so it will look like:

$DB->sql_substr(string, from, len)

with len being optional.

- Implement it in new moodle_databases.
- Document it.
- Look for wrong usages in core.
- Add some tests, with and without len.

Ciao :-)

All

Comments

Change History

Version Control

Sort Order:

Petr Skoda made changes - 28/Oct/08 09:17 PM

Field	Original Value	New Value
Assignee	Eloy Lafuente (stronk7) [ stronk7 ]	Petr ?koda [ skodak ]

Petr Skoda committed 13 files to 'Moodle CVS' - 29/Oct/08 12:11 AM

~~MDL-16669~~ dml: improved sql_substring(), added unit tests

MODIFY	lib/dml/mysqli_native_moodle_database.php	Rev. 1.10	(+1 -6 lines)
MODIFY	lib/dml/pgsql_native_moodle_database.php	Rev. 1.12	(+1 -5 lines)
MODIFY	lib/dml/moodle_database.php	Rev. 1.58	(+17 -4 lines)
MODIFY	lib/dml/pdo_moodle_database.php	Rev. 1.12	(+1 -5 lines)
MODIFY	lib/setuplib.php	Rev. 1.35	(+16 -1 lines)
MODIFY	lang/en_utf8/debug.php	Rev. 1.17	(+1 -0 lines)
MODIFY	lib/accesslib.php	Rev. 1.525	(+2 -8 lines)
MODIFY	mod/glossary/sql.php	Rev. 1.45	(+5 -5 lines)
MODIFY	lib/dml/Attic/mssql_adodb_moodle_database.php	Rev. 1.23	(+18 -1 lines)
MODIFY	lib/dml/Attic/adodb_moodle_database.php	Rev. 1.24	(+1 -5 lines)
MODIFY	lib/dml/sqlite3_pdo_moodle_database.php	Rev. 1.8	(+1 -8 lines)
MODIFY	lib/dml/simpletest/testdml.php	Rev. 1.24	(+32 -1 lines)
MODIFY	lib/file/file_storage.php	Rev. 1.26	(+3 -3 lines)

[ Permalink | « Hide ]

Petr Skoda added a comment - 29/Oct/08 12:11 AM

done including unittests

Petr Skoda made changes - 29/Oct/08 12:11 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 29/Oct/08 12:55 AM

~~MDL-16669~~ Translated a new string for debug.
~~MDL-16996~~ Translated new strings for error messages.
MDL-15352 Translated a new string for repository remote Moodle.
~~MDL-16975~~ Translated new strings for xmldb.

MODIFY	ja_utf8/debug.php	Rev. 1.17	(+2 -1 lines)
MODIFY	ja_utf8/README	Rev. 1.853	(+1 -1 lines)
MODIFY	ja_utf8/repository_remotemoodle.php	Rev. 1.5	(+1 -0 lines)
MODIFY	ja_utf8/error.php	Rev. 1.98	(+3 -1 lines)
MODIFY	ja_utf8/xmldb.php	Rev. 1.20	(+12 -3 lines)