Issue Details (XML | Word | Printable)

Key: MDL-16673
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Sam Hemelryk
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-16583

Clean up all the places we link to javascript files, to use $PAGE->requires->js

Created: 25/Sep/08 11:08 AM   Updated: 17/Sep/09 05:39 PM
Return to search
Component/s: Lib
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Sam Hemelryk and Tim Hunt
Security Level: None
Resolved date: 17/Sep/09
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 Description  « Hide
That is, try to get rid of $CFG->javascript, and the truely horrific global $standard_javascript.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt made changes - 12/Jun/09 08:14 PM
Field Original Value New Value
Summary Clean up all the places we link to javascript files, to use require_js Clean up all the places we link to javascript files, to use $PAGE->requires->js
Tim Hunt made changes - 18/Jun/09 03:57 PM
Assignee Tim Hunt [ timhunt ] Sam Hemelryk [ samhemelryk ]
Sam Hemelryk committed 10 files to 'Moodle CVS' - 07/Jul/09 05:09 PM
javascript MDL-16673 Removed all removeable uses of CFG->javascript
In doing this I was able to eliminate the need for javascript.php files, now removed.
I will also be filing several subtasks to clean up the linked to JS files in OUTPUT as well
as all instance of the old style of focusing.
MODIFY admin/xmldb/index.php   Rev. 1.20    (+20 -6 lines)
MODIFY mod/resource/type/ims/Attic/preview.php   Rev. 1.8    (+10 -7 lines)
MODIFY mod/resource/type/ims/Attic/resource.class.php   Rev. 1.57    (+12 -7 lines)
DEL mod/resource/type/ims/Attic/javascript.php   Rev. 1.10    (+0 -0 lines)
MODIFY lib/javascript-static.js   Rev. 1.73    (+10 -0 lines)
ADD mod/resource/type/ims/Attic/ims.js   Rev. 1.1    (+0 -0 lines)
DEL lib/Attic/javascript.php   Rev. 1.53    (+0 -0 lines)
DEL admin/xmldb/Attic/javascript.php   Rev. 1.7    (+0 -0 lines)
MODIFY lib/setup.php   Rev. 1.280    (+0 -1 lines)
MODIFY lib/outputlib.php   Rev. 1.23    (+22 -8 lines)
[ Permalink | « Hide ]
Sam Hemelryk added a comment - 17/Sep/09 01:51 PM
All done other than themes, these will be hopefully upgraded in the future. Remnants still exist in output classes as legacy themes will still be calling
<code php>
include($CFG->javascript)
</code>

Sam Hemelryk made changes - 17/Sep/09 01:51 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Sam Hemelryk committed 3 files to 'Moodle CVS' - 17/Sep/09 02:17 PM
chat MDL-16673 Clean up inline script and output calls
MODIFY mod/chat/gui_header_js/insert.php   Rev. 1.19    (+5 -14 lines)
MODIFY mod/chat/gui_header_js/chat_gui_header.js   Rev. 1.4    (+4 -0 lines)
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.38    (+4 -2 lines)
[ Permalink | « Hide ]
Tim Hunt added a comment - 17/Sep/09 05:39 PM
Wow! that must feel like getting to the end of a marathon.


Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators