Moodle

All references to the text.html and emoticons.html files need to be updated to point to text2.html and emoticons2.html

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Libraries
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

This is a follow-up to MDL-13233.

The files had to be renamed because the content was changed.

However, a lot of places in code, and 3rd party plugins print links to this common HTML editor help file. So, as well as updating all references in core (about a dozen were not updated) we need to catch this in helpbutton and print a developer debug warning.

Issue Links

This issue has a non-specific relationship to:
MDL-13233 Emoticons Documentation should be dynamic with the new configuration settings Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Pierre Pichet added a comment -

the debug message from HEAD update 5 minutes ago...
Array
(
[0] => Array
(
[0] => questiontext
[1] => Question text
[2] => quiz
)

[1] => richtext2
)

'editorhelpbutton'

  • line 38 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()

'eft'

  • line 51 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()

'newt'

  • line 54 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()

Array
(
[0] => generalfeedback
[1] => General feedback
[2] => quiz
)

'helpbutton'

  • line 38 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()

'tadpole'

  • line 42 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()
Show
Pierre Pichet added a comment - the debug message from HEAD update 5 minutes ago... Array ( [0] => Array ( [0] => questiontext [1] => Question text [2] => quiz ) [1] => richtext2 ) 'editorhelpbutton'
  • line 38 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()
'eft'
  • line 51 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()
'newt'
  • line 54 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()
Array ( [0] => generalfeedback [1] => General feedback [2] => quiz ) 'helpbutton'
  • line 38 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()
'tadpole'
  • line 42 of lib\form\textarea.php: call to debugging()
  • line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
  • line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
  • line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
  • line 111 of lib\formslib.php: call to question_edit_form->definition()
  • line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
  • line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
  • line 125 of question\question.php: call to default_questiontype->create_editing_form()
Hide
Permalink
Pierre Pichet added a comment -

either from calculated or simple short answer...

Show
Pierre Pichet added a comment - either from calculated or simple short answer...
Hide
Permalink
Tim Hunt added a comment -

Yes, sorry I screwed up and left some debugging code it. Fixed now.

Show
Tim Hunt added a comment - Yes, sorry I screwed up and left some debugging code it. Fixed now.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.