[#MDL-16676] All references to the text.html and emoticons.html files need to be updated to point to text2.html and emoticons2.html

Issue Details (XML | Word | Printable)

Key:	MDL-16676
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Tim Hunt
Reporter:	Tim Hunt
Votes:	0
Watchers:	0

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

All references to the text.html and emoticons.html files need to be updated to point to text2.html and emoticons2.html

Created: 25/Sep/08 02:58 PM Updated: 26/Sep/08 12:42 PM

Return to search

Issue 4000 of 20195 issue(s)

<< Previous | MDL-16676 | Next >>

Component/s:

Lib

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Relates

This issue has a non-specific relationship to:

~~MDL-13233~~ Emoticons Documentation should be dynamic with the new configuration settings

Participants:	Pierre Pichet and Tim Hunt
Security Level:	None
Resolved date:	25/Sep/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

Description

« Hide

This is a follow-up to ~~MDL-13233~~.

The files had to be renamed because the content was changed.

However, a lot of places in code, and 3rd party plugins print links to this common HTML editor help file. So, as well as updating all references in core (about a dozen were not updated) we need to catch this in helpbutton and print a developer debug warning.

All

Comments

Change History

Version Control

Sort Order:

[ Permalink | « Hide ]

Pierre Pichet added a comment - 26/Sep/08 01:20 AM

the debug message from HEAD update 5 minutes ago...
Array
(
[0] => Array
(
[0] => questiontext
[1] => Question text
[2] => quiz
)

[1] => richtext2
)

'editorhelpbutton'

line 38 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

'eft'

line 51 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

'newt'

line 54 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

Array
(
[0] => generalfeedback
[1] => General feedback
[2] => quiz
)

'helpbutton'

line 38 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

'tadpole'

line 42 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

[ Show » ]

Pierre Pichet added a comment - 26/Sep/08 01:20 AM the debug message from HEAD update 5 minutes ago... Array ( [0] => Array ( [0] => questiontext [1] => Question text [2] => quiz ) [1] => richtext2 ) 'editorhelpbutton'

line 38 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

'eft'

line 51 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

'newt'

line 54 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 112 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

Array ( [0] => generalfeedback [1] => General feedback [2] => quiz ) 'helpbutton'

line 38 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

'tadpole'

line 42 of lib\form\textarea.php: call to debugging()
line 59 of lib\form\htmleditor.php: call to MoodleQuickForm_textarea->setHelpButton()
line 1226 of lib\formslib.php: call to MoodleQuickForm_htmleditor->setHelpButton()
line 144 of question\type\edit_question_form.php: call to MoodleQuickForm->setHelpButton()
line 111 of lib\formslib.php: call to question_edit_form->definition()
line 48 of question\type\edit_question_form.php: call to moodleform->moodleform()
line 174 of question\type\questiontype.php: call to question_edit_form->question_edit_form()
line 125 of question\question.php: call to default_questiontype->create_editing_form()

[ Permalink | « Hide ]

Pierre Pichet added a comment - 26/Sep/08 01:23 AM

either from calculated or simple short answer...

[ Permalink | « Hide ]

Tim Hunt added a comment - 26/Sep/08 12:42 PM

Yes, sorry I screwed up and left some debugging code it. Fixed now.

All content on this web site is made available under the GNU General Public License, unless otherwise stated.