Moodle

Formslib element: editor

Details

  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

The new "editor" form element is similar to the old "htmleditor" component in that it will print an editor for text etc (like tinymce).

In addtion it:

  • requires draftfileareaid, format, current language (and possibly more things later) passed in using JS globals
  • will use the repository filepicker at all input points within the editor interface

Later on we can add:

  • support for special editors for special formats.
  • support conversion of formats (eg into html).

Issue Links

This issue has been marked as being related by:
MDL-24296 Forum post body displayed at the confirmation page Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dongsheng Cai added a comment -

Filepicker works now.

Show
Dongsheng Cai added a comment - Filepicker works now.
Hide
Permalink
Dongsheng Cai added a comment -

Finally figured out how to convert draft files, here is a patch to convert htmleditor to editor in mod/forum, it worked, I will double check tomorrow.

Show
Dongsheng Cai added a comment - Finally figured out how to convert draft files, here is a patch to convert htmleditor to editor in mod/forum, it worked, I will double check tomorrow.
Hide
Permalink
Petr Škoda (skodak) added a comment -

nice, looks ok, I fixed some warnings when adding new posts and added $draftid_editor = file_get_submitted_draftitemid('message'); when solves form reloading problems

please commit into HEAD

Show
Petr Škoda (skodak) added a comment - nice, looks ok, I fixed some warnings when adding new posts and added $draftid_editor = file_get_submitted_draftitemid('message'); when solves form reloading problems please commit into HEAD
Hide
Permalink
Tim Hunt added a comment -

Before it is too late, can I suggest a name change?

I think form elements should be named according to what you are editing, not how you edit it. So I think this element should be called 'htmlcontent' or something like that. That approach makes the form definition more declarative, and makes it easier to make usability improvements in future.

Show
Tim Hunt added a comment - Before it is too late, can I suggest a name change? I think form elements should be named according to what you are editing, not how you edit it. So I think this element should be called 'htmlcontent' or something like that. That approach makes the form definition more declarative, and makes it easier to make usability improvements in future.
Hide
Permalink
Martin Dougiamas added a comment -

If we do this then I think the best name would be text but we have one of those for something else.

The main distinguishing feature is that this element supports all editors (not just html editors either, it depends on the format of the text).

Show
Martin Dougiamas added a comment - If we do this then I think the best name would be text but we have one of those for something else. The main distinguishing feature is that this element supports all editors (not just html editors either, it depends on the format of the text).
Hide
Permalink
Petr Škoda (skodak) added a comment -

kind of works, closing

Show
Petr Škoda (skodak) added a comment - kind of works, closing

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.