|
[
Permalink
| « Hide
]
Tim Hunt added a comment - 26/Sep/08 04:20 PM
It also shows teachers as if they were already enrolled, however this is misleading as they are enrolled as teachers, and this page only lets you enrol people as students.
Yep, hard coding the role id ~ line 93:
if( role_unassign(5, $ids[0], 0, $context->id) ) { is not pretty although I confess doing something similar on one of my servers just because it was a quick/easy way to do it without having to look up the id. Looks really horrible, yup. Perhaps we could use $CFG->defaultcourseroleid as the role to be used when using that bulk operation? Both when detecting current enrolments and when assigning them.
Though it's possible that this will be changed in 2.0 new enrolments... I think it's better to have it working properly (at least "old behaviour") since now, yup? |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Open
Minor
Bulk user enrol hard-codes the student role id as 5 and incorrectly shows teachers as enrolled
 |
|
All content on this web site is made available under the GNU General Public License, unless otherwise stated.
