Issue Details (XML | Word | Printable)

Key: MDL-16706
Type: Sub-task Sub-task
Status: Open Open
Priority: Minor Minor
Assignee: Sam Hemelryk
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-16583

Eliminate other inline scripts

Created: 26/Sep/08 06:48 PM   Updated: 18/Jun/09 03:57 PM
Return to search
Component/s: Lib
Affects Version/s: 2.0
Fix Version/s: 2.0

Participants: Sam Hemelryk and Tim Hunt
Security Level: None
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
tjhunt committed 6 files to 'Moodle CVS' - 26/Sep/08 06:49 PM
MDL-16706 - eliminate miscellaneous inine JavaScript
This does the quiz (apart from the bloody 'secure' window), the question bank and a couple of others.
MODIFY mod/quiz/accessrules.php   Rev. 1.15    (+2 -6 lines)
MODIFY question/export.php   Rev. 1.50    (+3 -12 lines)
MODIFY mod/quiz/review.php   Rev. 1.83    (+3 -5 lines)
MODIFY lib/weblib.php   Rev. 1.1154    (+31 -14 lines)
MODIFY message/refresh.php   Rev. 1.17    (+6 -16 lines)
MODIFY mod/quiz/quiz.js   Rev. 1.12    (+2 -2 lines)
tjhunt committed 3 files to 'Moodle CVS' - 26/Sep/08 07:24 PM
MDL-16706 - eliminate miscellaneous inine JavaScript
A few easy files in lib.
MODIFY lib/filelib.php   Rev. 1.105    (+2 -2 lines)
MODIFY lib/recaptchalib.php   Rev. 1.7    (+4 -4 lines)
MODIFY lib/moodlelib.php   Rev. 1.1116    (+5 -4 lines)
Sam Hemelryk committed 5 files to 'Moodle CVS' - 22/Jun/09 11:16 AM
moddata MDL-16706 Removed inline scripts in mod data and added data.js
MODIFY mod/data/templates.php   Rev. 1.82    (+3 -17 lines)
MODIFY mod/data/view.php   Rev. 1.114    (+2 -2 lines)
MODIFY mod/data/lib.php   Rev. 1.233    (+2 -32 lines)
MODIFY mod/data/edit.php   Rev. 1.45    (+2 -2 lines)
ADD mod/data/data.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 22/Jun/09 12:11 PM
modfeedback MDL-16706 Removed inline scripts in mod feedback and added feedback.js
MODIFY mod/feedback/show_entries_anonym.php   Rev. 1.10    (+3 -10 lines)
MODIFY mod/feedback/edit_item.php   Rev. 1.14    (+4 -10 lines)
ADD mod/feedback/feedback.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 23/Jun/09 09:18 AM
javascript MDL-16706 Removed inline script call in mod choice and scorm
MODIFY mod/choice/lib.php   Rev. 1.106    (+3 -2 lines)
MODIFY lib/javascript-static.js   Rev. 1.68    (+10 -0 lines)
MODIFY mod/scorm/report.php   Rev. 1.62    (+2 -2 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 23/Jun/09 11:16 AM
modforum MDL-16706 Removed inline js script call in mod forum and added forum.js
ADD mod/forum/forum.js   Rev. 1.1    (+0 -0 lines)
MODIFY mod/forum/lib.php   Rev. 1.798    (+10 -20 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 25/Jun/09 10:57 AM
modforum MDL-16706 Removed inline js script call in mod forum
MODIFY mod/forum/forum.js   Rev. 1.2    (+3 -0 lines)
MODIFY mod/forum/search.php   Rev. 1.100    (+3 -6 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 25/Jun/09 11:46 AM
mod-survey MDL-16706 Removed inline script in survey and added survey.js
MODIFY mod/survey/view.php   Rev. 1.63    (+16 -42 lines)
ADD mod/survey/survey.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 25/Jun/09 02:29 PM
mod-lesson MDL-16706 Removed inline scripts and modified timer to take obj args
MODIFY mod/lesson/timer.js   Rev. 1.9    (+13 -1 lines)
MODIFY mod/lesson/locallib.php   Rev. 1.84    (+11 -15 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.693    (+4 -0 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 26/Jun/09 12:00 PM
user-adduser MDL-16706 Included YUI event using requires yui_lib
MODIFY user/editadvanced.php   Rev. 1.51    (+3 -1 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 26/Jun/09 12:04 PM
mod-resource MDL-16706 Removed inline JS and replaced with new PAGE methods
MODIFY mod/resource/type/html/Attic/resource.class.php   Rev. 1.51    (+3 -7 lines)
MODIFY mod/resource/type/text/Attic/resource.class.php   Rev. 1.46    (+3 -7 lines)
Sam Hemelryk committed 4 files to 'Moodle CVS' - 26/Jun/09 01:12 PM
mod-resource-file MDL-16706 Removed inline JS and replaced with new PAGE methods
MODIFY mod/resource/type/file/Attic/resource.class.php   Rev. 1.102    (+35 -49 lines)
MODIFY mod/resource/type/file/Attic/localpath.php   Rev. 1.9    (+4 -23 lines)
MODIFY mod/resource/type/file/Attic/localfile.php   Rev. 1.11    (+3 -18 lines)
ADD mod/resource/type/file/Attic/file.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 26/Jun/09 01:49 PM
mod-chat MDL-16706 Removed inline JS and replaced with new PAGE methods
Removed print_header $meta at same time as no longer used
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.32    (+3 -31 lines)
ADD mod/chat/gui_header_js/chat_gui_header.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 26/Jun/09 01:55 PM
mod-chat MDL-16706 Removed inline JS and replaced with new PAGE methods
MODIFY mod/chat/gui_header_js/users.php   Rev. 1.24    (+10 -46 lines)
MODIFY mod/chat/gui_header_js/chat_gui_header.js   Rev. 1.2    (+24 -0 lines)
MODIFY mod/chat/gui_header_js/chatinput.php   Rev. 1.33    (+2 -2 lines)
Sam Hemelryk committed 5 files to 'Moodle CVS' - 26/Jun/09 02:31 PM
mod-scorm MDL-16706 Removed inline JS and replaced with new PAGE methods
MODIFY mod/scorm/rd.js   Rev. 1.6    (+15 -1 lines)
ADD mod/scorm/datamodels/scorm_datamodels.js   Rev. 1.1    (+0 -0 lines)
MODIFY mod/scorm/player.php   Rev. 1.51    (+13 -20 lines)
MODIFY mod/scorm/datamodels/scorm_13lib.php   Rev. 1.19    (+4 -21 lines)
MODIFY mod/scorm/datamodels/scorm_12lib.php   Rev. 1.21    (+4 -21 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 26/Jun/09 02:53 PM
mod-chat MDL-16706 Removed inline JS and replaced with new PAGE methods
ADD mod/chat/gui_sockets/chat_gui_sockets.js   Rev. 1.1    (+0 -0 lines)
MODIFY mod/chat/gui_sockets/chatinput.php   Rev. 1.20    (+4 -24 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 26/Jun/09 03:32 PM
mod-feedback MDL-16706 Removed inline JS and replaced with new PAGE methods
MODIFY mod/feedback/analysis_course.php   Rev. 1.12    (+3 -13 lines)
MODIFY mod/feedback/feedback.js   Rev. 1.2    (+6 -0 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 26/Jun/09 03:49 PM
mod-forum MDL-16706 Removed inline JS and replaced with new PAGE methods
MODIFY mod/forum/forum.js   Rev. 1.3    (+9 -1 lines)
MODIFY mod/forum/search.php   Rev. 1.102    (+3 -5 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 26/Jun/09 04:12 PM
user MDL-16706 This was not the solution, removing YUI call here
MODIFY user/editadvanced.php   Rev. 1.52    (+1 -3 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 29/Jun/09 10:38 AM
mod-scorm MDL-16706 Replaced inline JS with new PAGE methods and created player.js
MODIFY mod/scorm/rd.js   Rev. 1.7    (+4 -4 lines)
MODIFY mod/scorm/player.php   Rev. 1.52    (+7 -30 lines)
ADD mod/scorm/player.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 29/Jun/09 04:05 PM
filter-mediaplugin MDL-16706 Replaced inline JS with new PAGE methods and created mediaplugin.js
MODIFY filter/mediaplugin/filter.php   Rev. 1.60    (+52 -33 lines)
ADD filter/mediaplugin/Attic/mediaplugin.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 4 files to 'Moodle CVS' - 30/Jun/09 09:28 AM
message MDL-16706 Replaced inline JS with new PAGE methods and created message.js
MODIFY message/send.php   Rev. 1.36    (+6 -10 lines)
ADD message/message.js   Rev. 1.1    (+0 -0 lines)
MODIFY message/lib.php   Rev. 1.85    (+2 -6 lines)
MODIFY message/index.php   Rev. 1.23    (+2 -2 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 02/Jul/09 11:47 AM
weblib MDL-16706 Elimate inline scripts, replaced with PAGE methods
MODIFY lib/weblib.php   Rev. 1.1284    (+4 -6 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 02/Jul/09 12:02 PM
user MDL-16706 Elimate inline scripts, replaced with PAGE methods, created user.js
MODIFY user/index.php   Rev. 1.229    (+3 -32 lines)
ADD user/user.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 02/Jul/09 12:03 PM
user MDL-16706 updated user.js
MODIFY user/user.js   Rev. 1.2    (+2 -2 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 02/Jul/09 12:10 PM
admin reports MDL-16706 Eliminated inline scripts to use PAGE methods
MODIFY admin/report/security/lib.php   Rev. 1.16    (+5 -9 lines)
ADD admin/report/spamcleaner/spamcleaner.js   Rev. 1.1    (+0 -0 lines)
MODIFY admin/report/spamcleaner/index.php   Rev. 1.7    (+7 -86 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 02/Jul/09 12:14 PM
course reports MDL-16706 Eliminated inline scripts to use PAGE methods
MODIFY course/report/participation/index.php   Rev. 1.32    (+4 -39 lines)
MODIFY course/report/log/live.php   Rev. 1.15    (+8 -4 lines)
ADD course/report/participation/participation.js   Rev. 1.1    (+0 -0 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 02/Jul/09 02:00 PM
chat ajax MDL-16706 Eliminated inline scripts to use PAGE methods
MODIFY theme/standard/styles_layout.css   Rev. 1.696    (+6 -0 lines)
MODIFY mod/chat/gui_ajax/index.php   Rev. 1.11    (+31 -36 lines)
MODIFY mod/chat/gui_ajax/Attic/update.php   Rev. 1.8    (+3 -1 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 02/Jul/09 02:37 PM
mod-assignment MDL-16706 Eliminated inline scripts to use PAGE methods
ADD mod/assignment/assignment.js   Rev. 1.1    (+0 -0 lines)
MODIFY mod/assignment/lib.php   Rev. 1.390    (+3 -16 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 02/Jul/09 02:40 PM
mod-scorm MDL-16706 Eliminated inline scripts to use PAGE methods
MODIFY mod/scorm/datamodels/aicclib.php   Rev. 1.19    (+3 -20 lines)
Sam Hemelryk committed 2 files to 'Moodle CVS' - 02/Jul/09 02:46 PM
mod-quiz MDL-16706 Eliminated inline scripts to use PAGE methods
MODIFY mod/quiz/quiz.js   Rev. 1.18    (+5 -1 lines)
MODIFY mod/quiz/accessrules.php   Rev. 1.23    (+3 -4 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 02/Jul/09 03:45 PM
grade-edit-tree MDL-16706 Removed inline script
MODIFY grade/edit/tree/index.php   Rev. 1.37    (+3 -7 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 03/Jul/09 09:36 AM
mod-scorm MDL-16706 Added missing global from commites yesterday
MODIFY mod/scorm/datamodels/aicclib.php   Rev. 1.20    (+2 -2 lines)
Sam Hemelryk committed 1 file to 'Moodle CVS' - 03/Jul/09 10:01 AM
mod-feedback MDL-16706 Removed inline JS and added PAGE methods
MODIFY mod/feedback/analysis_course.php   Rev. 1.13    (+3 -3 lines)
tjhunt committed 2 files to 'Moodle CVS' - 03/Jul/09 05:03 PM
MDL-19696 & MDL-16706 refactor sam's redirect changes, so they can work during initial install.
MODIFY lib/weblib.php   Rev. 1.1293    (+16 -8 lines)
MODIFY lib/outputlib.php   Rev. 1.19    (+15 -25 lines)
Sam Hemelryk committed 3 files to 'Moodle CVS' - 06/Jul/09 11:16 AM
form-filemanager MDL-16706 Removed inline JS and added PAGE methods
ADD lib/form/filemanager.js   Rev. 1.1    (+0 -0 lines)
MODIFY lib/form/filemanager.php   Rev. 1.30    (+11 -58 lines)
MODIFY lib/form/editor.php   Rev. 1.19    (+12 -24 lines)
Dongsheng Cai committed 1 file to 'Moodle CVS' - 07/Jul/09 03:16 PM
"MDL-16706, fixed javascript object used to assoicate editorid with file picker clientid"
MODIFY lib/form/editor.php   Rev. 1.20    (+3 -3 lines)
Sam Hemelryk committed 5 files to 'Moodle CVS' - 07/Jul/09 04:49 PM
lib-form MDL-16706 Changed inline JS to use PAGE methods
MODIFY lib/form/passwordunmask.php   Rev. 1.5    (+3 -31 lines)
MODIFY lib/form/filepicker.php   Rev. 1.30    (+4 -23 lines)
ADD lib/form/filepicker.js   Rev. 1.1    (+0 -0 lines)
MODIFY lib/form/recaptcha.php   Rev. 1.8    (+4 -9 lines)
ADD lib/form/passwordunmask.js   Rev. 1.1    (+0 -0 lines)
Petr Skoda committed 2 files to 'Moodle CVS' - 10/Jul/09 12:33 AM
MDL-16706 fix of previous fix - multiple editors in one form shoudl work again
MODIFY repository/repository.src.js   Rev. 1.16    (+8 -0 lines)
MODIFY lib/form/editor.php   Rev. 1.21    (+4 -4 lines)
Petr Skoda committed 1 file to 'Moodle CVS' - 10/Jul/09 03:14 AM
MDL-16706 fix of fix that was supposed to fix previous regression
MODIFY repository/repository.src.js   Rev. 1.17    (+1 -1 lines)

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators