Issue Details (XML | Word | Printable)

Key: MDL-16780
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Nicolas Connault
Reporter: Nicolas Connault
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

JSON class needs moving to pear directory

Created: 03/Oct/08 03:01 PM   Updated: 04/Nov/08 03:32 AM
Return to search
Component/s: AJAX
Affects Version/s: 1.8.6, 1.9.2
Fix Version/s: 1.8.7, 1.9.3, 2.0

Issue Links:
Cloners
 
Dependency
 

Participants: Dongsheng Cai, Eloy Lafuente (stronk7), Erik Ordway, Nicolas Connault, Paul Taylor, Shane Elliott and Sunner Sun
Security Level: None
QA Assignee: Eloy Lafuente (stronk7)
Resolved date: 13/Oct/08
Affected Branches: MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
As suggested by Eloy, the class in lib/json/JSON.php is a pear class (now residing in HTML/AJAX) and needs to be moved to the right directory, and properly credited in the lib/pear/README.txt file. All files in core and contrib using this class also need updating.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Paul Taylor added a comment - 10/Oct/08 05:40 AM
I'm not sure if this is related, but I noticed on the latest update to 1.8.6 (October 8th) that when you tried to go to groups, there was an error message (with debug on):

Warning: require_once(HTML/AJAX.php) [function.require-once]: failed to open stream: No such file or directory in /var/www/moodle-18/lib/pear/HTML/AJAX/JSON.php on line 14

I remarked out line 14 and then 776-801 in JSON.php, and groups worked. I'm not sure why it is asking for AJAX.php, but no such file exists. I assume it means just the directory HTML/AJAX?

I found this on a few client machines and my test server.


Shane Elliott added a comment - 13/Oct/08 05:34 PM - edited
Confirming that this is a problem on 1.8 sites. Reopening issue.

Nicolas Connault added a comment - 13/Oct/08 08:24 PM
Bug fixed, thanks for the report

Dongsheng Cai added a comment - 14/Oct/08 10:48 AM
Closing, Thanks.

Sunner Sun added a comment - 15/Oct/08 03:42 PM
Warning: main(HTML/AJAX/JSON.php) [function.main]: failed to open stream: No such file or directory in /var/www/moodle/group/index.php on line 14

in MOODLE_18_WEEKLY

I just "cvs up" and got this error


Erik Ordway added a comment - 16/Oct/08 07:38 AM
/lib/pear/HTML/AJAX/*

is missing from 1_9_WEEKLY and causes blank page when loading groups page


Nicolas Connault added a comment - 16/Oct/08 02:57 PM - edited

Eloy Lafuente (stronk7) added a comment - 17/Oct/08 12:20 AM
Thanks for the quick fix, Nicolas! B-)
(just thinking that we don't need it in 19_STABLE nor HEAD, where the include is done centrally in setup.php)

Just raising to Critical, reopening and adding Martin as watcher in order to decide if this require repackaging of STABLE_18 release (released today, some hours before fixing this - so the release contains the bug).


Eloy Lafuente (stronk7) added a comment - 18/Oct/08 01:38 AM - edited
Hi,

both the 1.8.7 release and last 1.8 weekly packages have been rebuilt. Also, tags in CVS have been moved accordingly so people updating to MOODLE_18_WEEKLY will get the working version.

So... reclosing this after some more tests of current generated packages... ciao


Eloy Lafuente (stronk7) added a comment - 18/Oct/08 01:58 AM
Closing this. I've tested 18_WEEKLY, and 1.8.7 downloads and everything seems to be in place.

Thanks all!