Issue Details (XML | Word | Printable)

Key: MDL-16781
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Ralf Hilgenstock
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Lower case in setting menu of quiz

Created: 03/Oct/08 05:25 PM   Updated: 09/Dec/08 10:41 PM
Component/s: Quiz
Affects Version/s: 1.6.6, 1.7.5, 1.8.6, 1.9.2
Fix Version/s: 1.6.9, 1.7.7, 1.8.8, 1.9.4

File Attachments: None
Image Attachments:

1. attempts.png
(15 kB)

2. versuch.png
(194 kB)

Participants: Petr Škoda (skodak), Ralf Hilgenstock and Tim Hunt
Security Level: None
QA Assignee: Petr Škoda (skodak)
Resolved date: 05/Dec/08
Affected Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches: MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE


 Description  « Hide
In the settings menu the translated text for the 'attempts' is automatically switched to lower cases, also if they are correct in the language file.

example: German attempts: Versuche is visible as 'versuche' in the menu.



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt added a comment - 20/Oct/08 03:29 PM
Which menu? A screenshot or a URL would help.

Ralf Hilgenstock added a comment - 05/Nov/08 05:03 PM
Hi Tim,

sorry for late response. I add a screenshot.


Tim Hunt added a comment - 05/Nov/08 06:38 PM
OK. Now why is that a problem?

Actually, it is probalby more of a problem that we are concatenating the string, rather than using the 3rd argument of get_string.

Actually, why don't we just say:

Attempts allowed: Unlimited/1/2/3/4/...

Repeating the word attempts is rather redundant. Wow! that code has been there right from the start! http://cvs.moodle.org/moodle/mod/quiz/mod.html?hideattic=0&revision=1.1&view=markup

Anyway, what do you suggest?


Tim Hunt added a comment - 27/Nov/08 01:28 PM
Ping! Still waiting for a suggestion of what you want me to do to fix this.

Ralf Hilgenstock added a comment - 28/Nov/08 07:47 PM
Hi Tim,

sorry for late reply.

Attempts allowed: Unlimited/1/2/3/4/...

This suggestion may work in the German translation. I can edit the translation in this way.
The term 'Unlimited' will appear as 'unlimited' with lower cases.

I think it is more a general aspect. Translated strings should be shown in the same way they are translated and not changed in any way. I don't know what the consequences in other languages could be.


Ralf Hilgenstock added a comment - 28/Nov/08 09:01 PM
Hi Tim,

the string attempts is not only used for the pulldownmenu. See screenshot. And in the menu is a combination of a number and the 'attempts' string used. If I delete the entry in the string it is missing at other places. I think we need a new string.

Where can I find the singular term of 'attempts'? Couldn't find it in quiz.php


Tim Hunt added a comment - 05/Dec/08 01:21 PM
Done. Thanks for your help Ralph.

Petr Škoda (skodak) added a comment - 09/Dec/08 10:41 PM
thanks