Issue Details (XML | Word | Printable)

Key: MDL-16841
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Nobody
Reporter: Yoshiyuki Owa
Votes: 2
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Mnet isn't work when the setting of mnet_dispatcher_mode is 'dangerous'.

Created: 09/Oct/08 08:41 PM   Updated: 09/Oct/08 08:41 PM
Return to search
Component/s: Networking
Affects Version/s: 1.9.2
Fix Version/s: None

Participants: Nobody and Yoshiyuki Owa
Security Level: None
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
There is a bug in /mnet/xmlrpc/server.php line 504

$includefile = $CFG->dirroot.'/'.$filename;

I think

$includefile = '/'.$filename;

is true;

First, $includefile is used in mnet_server_invoke_method line 506.
Then $includefile is called at mnet_permit_rpc_call at line 691.

The function, mnet_permit_rpc_call, is in /mnet/lib.php.

In /mnet/lib.php line 414,

The system checks whether there is the file you want to include or not.
But, $CFG->dirroot is atatched again, here.

So, if you want to call /filename, the system checks that whether $CFG->dirroot.$CFG->dirroot.'/filename' exists or not.(doubled!)

Moodle isn't work when you access some function that isn't suported as normal function at setting mnet_dispather_mode='dangerous'.
And it returns RPC_NOSUCHFILE error.

Please check!

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
There are no comments yet on this issue.