[#MDL-16841] Mnet isn't work when the setting of mnet_dispatcher_mode is 'dangerous'. - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 1.9.2
Fix Version/s: 2.0
Component/s: MNet
Labels:
None

Affected Branches:
MOODLE_19_STABLE
Fixed Branches:
MOODLE_20_STABLE

Description

There is a bug in /mnet/xmlrpc/server.php line 504

$includefile = $CFG->dirroot.'/'.$filename;

I think

$includefile = '/'.$filename;

is true;

First, $includefile is used in mnet_server_invoke_method line 506.
Then $includefile is called at mnet_permit_rpc_call at line 691.

The function, mnet_permit_rpc_call, is in /mnet/lib.php.

In /mnet/lib.php line 414,

The system checks whether there is the file you want to include or not.
But, $CFG->dirroot is atatched again, here.

So, if you want to call /filename, the system checks that whether $CFG->dirroot.$CFG->dirroot.'/filename' exists or not.(doubled!)

Moodle isn't work when you access some function that isn't suported as normal function at setting mnet_dispather_mode='dangerous'.
And it returns RPC_NOSUCHFILE error.

Please check!

Issue Links

This issue will help resolve:
MDL-21260	General open bugs

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Penny Leach added a comment - 08/Jan/10 4:49 AM

Yep, it definitely seems that is incorrect, judging by the other ones.

Did you confirm that your fix solved the problem?

Show

Penny Leach added a comment - 08/Jan/10 4:49 AM Yep, it definitely seems that is incorrect, judging by the other ones. Did you confirm that your fix solved the problem?

Hide

Permalink

Penny Leach added a comment - 01/Feb/10 11:48 AM

I've changed this code a lot in HEAD. Can you please test the latest 2.0 version from CVS and see if dangerous mode works for you?

Show

Penny Leach added a comment - 01/Feb/10 11:48 AM I've changed this code a lot in HEAD. Can you please test the latest 2.0 version from CVS and see if dangerous mode works for you?

Hide

Permalink

Penny Leach added a comment - 16/Feb/10 10:45 AM

Closing because of lack of action & this should be fixed with the big refactor in Moodle 2.0. Please reopen if you still have trouble.

Show

Penny Leach added a comment - 16/Feb/10 10:45 AM Closing because of lack of action & this should be fixed with the big refactor in Moodle 2.0. Please reopen if you still have trouble.

Hide

Permalink

Jerome Jacobsen added a comment - 08/Apr/10 8:58 PM

This is also broken in 1.9.8.

The patch that works for me is to change line 504
from:
$includefile = $CFG->dirroot.'/'.$filename;
to:
$includefile = '/'.$filename;

Show

Jerome Jacobsen added a comment - 08/Apr/10 8:58 PM This is also broken in 1.9.8. The patch that works for me is to change line 504 from: $includefile = $CFG->dirroot.'/'.$filename; to: $includefile = '/'.$filename;

People

Assignee:

Penny Leach

Reporter:

Yoshiyuki Owa

Participants:

Jerome Jacobsen, Penny Leach, Yoshiyuki Owa

Vote (2)

Watch (2)

Dates

Created:

09/Oct/08 8:41 PM

Updated:

17/Dec/10 12:53 PM

Resolved:

16/Feb/10 10:45 AM