Issue Details (XML | Word | Printable)

Key: MDL-16848
Type: Bug Bug
Status: Resolved Resolved
Resolution: Duplicate
Priority: Minor Minor
Assignee: Jerome Mouneyrac
Reporter: Brett Hinton
Votes: 0
Watchers: 2
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Database Activity - Required Viewing setting is incorrectly preventing users from viewing database entries

Created: 10/Oct/08 01:08 PM   Updated: 24/Nov/08 10:01 AM
Return to search
Component/s: Database activity module
Affects Version/s: 1.9.2
Fix Version/s: None

File Attachments: 1. Zip Archive database_with_viewing_option_issue.zip (22 kB)

Environment: Linux server, apache
Issue Links:
Duplicate
 

Database: MySQL
Participants: Antonio Piedras Morente, Brett Hinton and Jerome Mouneyrac
Security Level: None
Resolved date: 24/Nov/08
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
When participants view a database setup to require 1 entry for a user, but that is set to allow them to see other entries without first posting, the database activity is preventing them from viewing those entries with the following error message:

"You must add 1 more entry/entries before you can view other participants' entries."

This message should only be appearing if the database activity is set to require users to post an entry first. An example of a database activity where this is occurring is attached.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Antonio Piedras Morente added a comment - 21/Oct/08 03:32 PM
To solve this i think is needed to change code in /mod/data/view.php

Change this block

// Check the number of entries required against the number of entries already made (doesn't apply to teachers)
$requiredentries_allowed = true;
$numentries = data_numentries($data);
if ($data->requiredentries > 0 && $numentries < $data->requiredentries && !has_capability('mod/data:manageentries', $context)) { $data->entriesleft = $data->requiredentries - $numentries; $strentrieslefttoadd = get_string('entrieslefttoadd', 'data', $data); notify($strentrieslefttoadd); $requiredentries_allowed = false; }

by the next two

// Check the number of entries required to view other participants' entries against the number of entries already made (doesn't apply to teachers)
$requiredentries_allowed = true;
$numentries = data_numentries($data);
if ($data->requiredentriestoview > 0 && $numentries < $data->requiredentriestoview && !has_capability('mod/data:manageentries', $context)) { $data->entriesleft = $data->requiredentriestoview - $numentries; $strentrieslefttoadd = get_string('entrieslefttoadd', 'data', $data); notify($strentrieslefttoadd); $requiredentries_allowed = false; }

// Check the number of entries required against the number of entries already made (doesn't apply to teachers)
if ($data->requiredentries > 0 && $numentries < $data->requiredentries && !has_capability('mod/data:manageentries', $context)) { $requiredentries = get_string('requiredentries', 'data') . ': ' . $data->requiredentries; notify($requiredentries); }

maybe then message of the second block must be better and show how many entries required and how many entries already made.

Bye


Séverin Terrier made changes - 22/Nov/08 02:01 AM
Field Original Value New Value
Link This issue will be resolved by MDL-16999 [ MDL-16999 ]
Jerome Mouneyrac made changes - 24/Nov/08 09:59 AM
Assignee Eloy Lafuente (stronk7) [ stronk7 ] Jerome Mouneyrac [ jerome ]
Jerome Mouneyrac added a comment - 24/Nov/08 10:00 AM
This is a duplicate of MDL-16999

Jerome Mouneyrac made changes - 24/Nov/08 10:00 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Duplicate [ 3 ]
Jerome Mouneyrac made changes - 24/Nov/08 10:01 AM
Link This issue duplicates MDL-16999 [ MDL-16999 ]
Jerome Mouneyrac made changes - 24/Nov/08 10:01 AM
Link This issue will be resolved by MDL-16999 [ MDL-16999 ]