Moodle

Hidden grade items cause a discrepancy in course totals between user and overview reports

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.9.2
  • Fix Version/s: 1.9.3
  • Component/s: Gradebook
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE

Description

You need a course with quite a few gradable activities for this to be noticeable. I noticed this on a course created by the admin/generator.php script, with default settings.

  • Give a user grades for all activities
  • Hide half of the activities
  • Log in as the graded user
  • Compare the course total for User report and Overview reports

A small-medium discrepancy should become obvious.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda (skodak) added a comment -

should be fixed in cvs, please review asap, thanks!

Show
Petr Škoda (skodak) added a comment - should be fixed in cvs, please review asap, thanks!
Hide
Permalink
Jerome Mouneyrac added a comment -

Tested with data generator, it works. Thanks for your work.

Show
Jerome Mouneyrac added a comment - Tested with data generator, it works. Thanks for your work.
Hide
Permalink
Robert Russo added a comment -

Petr,

We also wrestled with this and I was wondering why you would want to use your own SQL to pull the grades for a user in a course instead of using Moodle's grade_seq object?

We solved it using the grade_seq and want to know if your way is more efficient, as we have a huge Moodle installation and efficiency is paramount.

That's really the only difference between our solution and yours, so any help you can give us would be great. We're running 1.9.2, so we don't have your fix installed yet.

Show
Robert Russo added a comment - Petr, We also wrestled with this and I was wondering why you would want to use your own SQL to pull the grades for a user in a course instead of using Moodle's grade_seq object? We solved it using the grade_seq and want to know if your way is more efficient, as we have a huge Moodle installation and efficiency is paramount. That's really the only difference between our solution and yours, so any help you can give us would be great. We're running 1.9.2, so we don't have your fix installed yet.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.