Issue Details (XML | Word | Printable)

Key: MDL-16925
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Petr Skoda
Reporter: Alex DePena
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

After clicking "Post to Forum" button you get a blank screen

Created: 18/Oct/08 02:41 PM   Updated: 20/Oct/08 06:41 AM
Return to search
Component/s: Forum
Affects Version/s: 1.8.7
Fix Version/s: 1.8.7

Environment:
RedHat 5-Apache 2.2-PHP 5.1.6-IE-Firefox-Mysql
Fedora9-Apache 2.2.9-PHP 5.2.6-MySql-Firefox
Issue Links:
Dependency
 

Database: MySQL
Participants: Alex DePena, Eloy Lafuente (stronk7), Martin Dougiamas and Petr Skoda
Security Level: None
Resolved date: 19/Oct/08
Affected Branches: MOODLE_18_STABLE
Fixed Branches: MOODLE_18_STABLE


 Description  « Hide
I just did a fresh install of MOODLE_18_WEEKLY from the US cvs server on my home machine [ fedora 9, MySQL 5.0.51/ PHP 5/ Firefox/Apache 2.2.9 ] and the forum problem persists.


see http://moodle.org/mod/forum/discuss.php?d=108224#p476907

I manually edited /mod/forum/post.php lines 517, 547, 607 and changed forum_post_subscription($fromform, $forum) to forum_post_subscription($fromform) and it works.

A related issue: http://moodle.org/mod/forum/discuss.php?d=108430 I would check it out but I don't have IE on my fedor 9 box.

See also : Traker item MDL-14558

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Alex DePena added a comment - 18/Oct/08 02:44 PM
Also,

I tried the download .tgz version with the same results.
I tried the EU cvs server too. same results

Did /mod/forum/lib.php get ujpdated?


Martin Dougiamas added a comment - 19/Oct/08 12:58 PM
I'm able to duplicate this now. Working on a fix.

Martin Dougiamas added a comment - 19/Oct/08 02:41 PM
I can't check in now, due to firewall issues here in Oman, but basically the function forum_is_subscribed in mod/forum/lib.php needs to be changed to look like this:

function forum_is_subscribed($userid, $forum) {
if (is_numeric($forum)) { $forum = get_record('forum', 'id', $forum); }
if (forum_is_forcesubscribed($forum)) { return true; }
return record_exists("forum_subscriptions", "userid", $userid, "forum", $forum->id);
}


Petr Skoda added a comment - 19/Oct/08 04:27 PM
going to fix this now...

Petr Skoda added a comment - 19/Oct/08 04:39 PM
fixed in cvs, please retag

Petr Skoda added a comment - 19/Oct/08 04:40 PM
adding more ppl - looks like we need to rerelease 1.8.7

Martin Dougiamas added a comment - 20/Oct/08 02:00 AM
Eloy can you retag it? This was one of the bugs that I thought was fixed on Friday

Eloy Lafuente (stronk7) added a comment - 20/Oct/08 06:40 AM
MOODLE_187 & MOODLE_18_WEEKLY tags moved for mod/forum/lib.php

Moodle 1.8.7 and Moodle weekly repackaged including new mod/forum.lib php

cvs updating to MOODLE_18_WEEKLY should be enough to get this working. Ciao