Moodle

After clicking "Post to Forum" button you get a blank screen

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8.7
  • Fix Version/s: 1.8.7
  • Component/s: Forum
  • Labels:
    None
  • Environment:
    RedHat 5-Apache 2.2-PHP 5.1.6-IE-Firefox-Mysql
    Fedora9-Apache 2.2.9-PHP 5.2.6-MySql-Firefox
  • Database:
    MySQL
  • Affected Branches:
    MOODLE_18_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE

Description

I just did a fresh install of MOODLE_18_WEEKLY from the US cvs server on my home machine [ fedora 9, MySQL 5.0.51/ PHP 5/ Firefox/Apache 2.2.9 ] and the forum problem persists.

see http://moodle.org/mod/forum/discuss.php?d=108224#p476907

I manually edited /mod/forum/post.php lines 517, 547, 607 and changed forum_post_subscription($fromform, $forum) to forum_post_subscription($fromform) and it works.

A related issue: http://moodle.org/mod/forum/discuss.php?d=108430 I would check it out but I don't have IE on my fedor 9 box.

See also : Traker item MDL-14558

Issue Links

This issue will help resolve:
MDL-14558 Users can get subscribed to the forum where subscription not allowed Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alex DePena added a comment -

Also,

I tried the download .tgz version with the same results.
I tried the EU cvs server too. same results

Did /mod/forum/lib.php get ujpdated?

Show
Alex DePena added a comment - Also, I tried the download .tgz version with the same results. I tried the EU cvs server too. same results Did /mod/forum/lib.php get ujpdated?
Hide
Permalink
Martin Dougiamas added a comment -

I'm able to duplicate this now. Working on a fix.

Show
Martin Dougiamas added a comment - I'm able to duplicate this now. Working on a fix.
Hide
Permalink
Martin Dougiamas added a comment -

I can't check in now, due to firewall issues here in Oman, but basically the function forum_is_subscribed in mod/forum/lib.php needs to be changed to look like this:

function forum_is_subscribed($userid, $forum) {
if (is_numeric($forum)) { $forum = get_record('forum', 'id', $forum); }
if (forum_is_forcesubscribed($forum)) { return true; }
return record_exists("forum_subscriptions", "userid", $userid, "forum", $forum->id);
}

Show
Martin Dougiamas added a comment - I can't check in now, due to firewall issues here in Oman, but basically the function forum_is_subscribed in mod/forum/lib.php needs to be changed to look like this: function forum_is_subscribed($userid, $forum) { if (is_numeric($forum)) { $forum = get_record('forum', 'id', $forum); } if (forum_is_forcesubscribed($forum)) { return true; } return record_exists("forum_subscriptions", "userid", $userid, "forum", $forum->id); }
Hide
Permalink
Petr Škoda (skodak) added a comment -

going to fix this now...

Show
Petr Škoda (skodak) added a comment - going to fix this now...
Hide
Permalink
Petr Škoda (skodak) added a comment -

fixed in cvs, please retag

Show
Petr Škoda (skodak) added a comment - fixed in cvs, please retag
Hide
Permalink
Petr Škoda (skodak) added a comment -

adding more ppl - looks like we need to rerelease 1.8.7

Show
Petr Škoda (skodak) added a comment - adding more ppl - looks like we need to rerelease 1.8.7
Hide
Permalink
Martin Dougiamas added a comment -

Eloy can you retag it? This was one of the bugs that I thought was fixed on Friday

Show
Martin Dougiamas added a comment - Eloy can you retag it? This was one of the bugs that I thought was fixed on Friday
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

MOODLE_187 & MOODLE_18_WEEKLY tags moved for mod/forum/lib.php

Moodle 1.8.7 and Moodle weekly repackaged including new mod/forum.lib php

cvs updating to MOODLE_18_WEEKLY should be enough to get this working. Ciao

Show
Eloy Lafuente (stronk7) added a comment - MOODLE_187 & MOODLE_18_WEEKLY tags moved for mod/forum/lib.php Moodle 1.8.7 and Moodle weekly repackaged including new mod/forum.lib php cvs updating to MOODLE_18_WEEKLY should be enough to get this working. Ciao

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.