[#MDL-16939] weblib.php: build_navigation notice when new type parameter not provided - Moodle Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.9, 2.0
Fix Version/s: 1.9.4
Component/s: Libraries
Labels:
None

Affected Branches:
MOODLE_19_STABLE, MOODLE_20_STABLE
Fixed Branches:
MOODLE_19_STABLE

Description

The type variable is not checked for or initialized allowing for a PHP warning in my case:

Notice: Undefined index: type in /home/arborrow/Moodle/code/contrib-605/lib/weblib.php on line 3815

I think if we test for it first that would help especially considering that the usage of type is admittedly not very well documented yet and at this point only used to check for activity.

Peace - Anthony

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

MDL-16939.diff

21/Oct/08 12:21 AM

0.7 kB

Anthony Borrow

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Anthony Borrow added a comment - 21/Oct/08 12:21 AM

here is a quick patch that seemed to resolve the issue

Show

Anthony Borrow added a comment - 21/Oct/08 12:21 AM here is a quick patch that seemed to resolve the issue

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 21/Oct/08 1:13 AM

+1 for that! Anthony, do you use to apply this sort of things or should I assign to someone else?

Thanks, anyway. Ciao

Show

Eloy Lafuente (stronk7) added a comment - 21/Oct/08 1:13 AM +1 for that!

Anthony, do you use to apply this sort of things or should I assign to someone else? Thanks, anyway. Ciao

Hide

Permalink

Anthony Borrow added a comment - 21/Oct/08 1:42 AM

Eloy - I'm happy to apply it, I just like to have someone with more experience give the patch a look before I commit anything to CORE. I'll go ahead and check it in. Peace - Anthony

Show

Anthony Borrow added a comment - 21/Oct/08 1:42 AM Eloy - I'm happy to apply it, I just like to have someone with more experience give the patch a look before I commit anything to CORE. I'll go ahead and check it in. Peace - Anthony

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 21/Oct/08 2:26 AM

Thanks Anthony! Resolving as fixed. Ciao

Show

Eloy Lafuente (stronk7) added a comment - 21/Oct/08 2:26 AM Thanks Anthony! Resolving as fixed. Ciao

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 21/Oct/08 2:27 AM

Checked. Closing.

Show

Eloy Lafuente (stronk7) added a comment - 21/Oct/08 2:27 AM Checked. Closing.

People

Assignee:

Anthony Borrow

Reporter:

Anthony Borrow

Tester:

Eloy Lafuente (stronk7)

Participants:

Anthony Borrow, Eloy Lafuente (stronk7)

Vote (0)

Watch (0)

Dates

Created:

21/Oct/08 12:16 AM

Updated:

21/Oct/08 2:27 AM

Resolved:

21/Oct/08 2:26 AM