Details
-
Type:
New Feature
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0
-
Fix Version/s: 2.0
-
Component/s: Groups, Roles / Access
-
Labels:None
-
Affected Branches:MOODLE_20_STABLE
-
Fixed Branches:MOODLE_20_STABLE
Description
Move this code into a function, or possibly a class, so that it can be shared, but customised to particular circumstances.
Make the search ajax-y when JavaScript is available. In this case:
- No need to click OK to trigger a search.
- With more than MAX_USERS_PER_PAGE we don't display them. When there are fewer, we stop doing a server round-trip for the searches and reduce the timeout.
- If some users are already selected, and you change the search term, then those users stay selected, possibly being moved to a separate optgroup.
- If what you have typed uniquely identifies one user, that option is automatically selected.
This sort of control will also be needed on the explain permissions page (MDL-16964), and in the user's roles report (MDL-11186). MDL-16418 is a subset of this.
Attachments
Issue Links
Activity
- All
- Comments
- History
- Activity
- Source
- Test Sessions
Hide
Dan Poltawski
added a comment -
I really like this 
One minor niggle from the role assignments screen: When no users are assigned to a role (i.e. the existing users list is empty) it has a single entry with the text: "No users match ''". I think it'd be more intuitive to display nothing if the search string is empty and no users are available.
Hacked a quick patch to do this - attached.
Show
Dan Poltawski
added a comment - I really like this
One minor niggle from the role assignments screen: When no users are assigned to a role (i.e. the existing users list is empty) it has a single entry with the text: "No users match ''". I think it'd be more intuitive to display nothing if the search string is empty and no users are available.
Hacked a quick patch to do this - attached.
One minor niggle from the role assignments screen: When no users are assigned to a role (i.e. the existing users list is empty) it has a single entry with the text: "No users match ''". I think it'd be more intuitive to display nothing if the search string is empty and no users are available.
Hacked a quick patch to do this - attached. 
Design document now at http://docs.moodle.org/en/Development:Ajax_user_selector.