Issue Details (XML | Word | Printable)

Key: MDL-16966
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 1
Watchers: 4
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Improve the user selector used on the assign roles and group memebers pages

Created: 22/Oct/08 06:12 PM   Updated: 06/Nov/08 12:21 PM
Component/s: Groups, Roles
Affects Version/s: 2.0
Fix Version/s: 2.0

File Attachments: 1. Text File user_selector_empty_message.patch (1 kB)

Issue Links:
Duplicate
 
Relates
 

Participants: Dan Poltawski, Helen Foster and Tim Hunt
Security Level: None
QA Assignee: Helen Foster
Resolved date: 05/Nov/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE

Sub-Tasks  All   Open   
 Sub-Task Progress: 

 Description  « Hide
Move this code into a function, or possibly a class, so that it can be shared, but customised to particular circumstances.

Make the search ajax-y when JavaScript is available. In this case:
* No need to click OK to trigger a search.
* With more than MAX_USERS_PER_PAGE we don't display them. When there are fewer, we stop doing a server round-trip for the searches and reduce the timeout.
* If some users are already selected, and you change the search term, then those users stay selected, possibly being moved to a separate optgroup.
* If what you have typed uniquely identifies one user, that option is automatically selected.

This sort of control will also be needed on the explain permissions page (MDL-16964), and in the user's roles report (MDL-11186). MDL-16418 is a subset of this.

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt added a comment - 24/Oct/08 02:21 PM

Tim Hunt added a comment - 04/Nov/08 07:49 PM
Finish testing in bloody IE.

Tim Hunt added a comment - 05/Nov/08 05:18 PM
Yay! finally done.

Helen Foster added a comment - 05/Nov/08 05:25 PM
Great work Tim, looking forward to having chance to test this!

Dan Poltawski added a comment - 06/Nov/08 05:46 AM
I really like this

One minor niggle from the role assignments screen: When no users are assigned to a role (i.e. the existing users list is empty) it has a single entry with the text: "No users match ''". I think it'd be more intuitive to display nothing if the search string is empty and no users are available.

Hacked a quick patch to do this - attached.


Tim Hunt added a comment - 06/Nov/08 12:21 PM
Sweet. I spotted that problem last night, and thought I would have to fix it today. I'll review your patch after lunch!