Issue Details (XML | Word | Printable)

Key: MDL-16993
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tim Hunt
Reporter: Tim Hunt
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle
MDL-16966

Convert assign roles page

Created: 24/Oct/08 02:37 PM   Updated: 08/Apr/09 07:59 AM
Return to search
Component/s: Administration, Roles
Affects Version/s: 2.0
Fix Version/s: 2.0

Issue Links:
Relates
 

Participants: Anthony Borrow and Tim Hunt
Security Level: None
Resolved date: 30/Oct/08
Affected Branches: MOODLE_20_STABLE
Fixed Branches: MOODLE_20_STABLE


 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Tim Hunt made changes - 24/Oct/08 02:38 PM
Field Original Value New Value
Component/s Roles [ 10097 ]
[ Permalink | « Hide ]
Tim Hunt added a comment - 30/Oct/08 11:08 AM
In addition, improve the usability of this page in other ways:
  • Make the purpose of the hidden checkbox clearer.
  • Put a back button at the bottom.
  • Improve the layout.

We also need to do MDL-17067 while doing these changes.


[ Permalink | « Hide ]
Tim Hunt added a comment - 30/Oct/08 11:42 AM
Perhaps in the potential users list, but the number of roles each user already has in brackets next to their name.

tjhunt committed 8 files to 'Moodle CVS' - 30/Oct/08 03:26 PM
roles admin: Improve the usability of the assign roles interface - this is the first half of the work. Part of MDL-16993.

To do this, I found a way to clean up the method signatures of a couple of accesslib methods, so I did, hence the fact that this seems to touch some unrelated files.

Also, there is a nice new method in accesslib get_context_url, which gives you the natural URL for a context, so the course view page, or the user profile, etc.
MODIFY admin/roles/Attic/assign.html   Rev. 1.36    (+0 -1 lines)
MODIFY lib/accesslib.php   Rev. 1.526    (+123 -31 lines)
MODIFY theme/standard/styles_layout.css   Rev. 1.622    (+8 -0 lines)
MODIFY admin/roles/assign.php   Rev. 1.84    (+33 -36 lines)
MODIFY admin/roles/override.php   Rev. 1.54    (+3 -3 lines)
MODIFY lang/en_utf8/role.php   Rev. 1.68    (+5 -1 lines)
MODIFY backup/restore_form.html   Rev. 1.80    (+5 -10 lines)
MODIFY blocks/admin/block_admin.php   Rev. 1.118    (+2 -2 lines)
Tim Hunt made changes - 30/Oct/08 07:46 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
tjhunt committed 11 files to 'Moodle CVS' - 30/Oct/08 07:49 PM
user selection: MDL-16993 Convert the assign roles page to use the new components.

At the same time, I took the opportunity to try to work on some of the usability issues on this page. Note that I have not quite finished! So don't comment until tomorrow.

In the course of doing this, I also did: half of

MDL-11529 Show the number of assignees of each role in the change role dropdown on this page.
MDL-17067 Make it clear in the UI that admins are not allowed to unassign themselves.
MODIFY theme/standard/styles_layout.css   Rev. 1.623    (+58 -16 lines)
MODIFY lang/en_utf8/error.php   Rev. 1.137    (+2 -1 lines)
MODIFY user/selector/search.php   Rev. 1.3    (+29 -6 lines)
MODIFY lang/en_utf8/role.php   Rev. 1.69    (+9 -1 lines)
MODIFY lib/accesslib.php   Rev. 1.527    (+30 -2 lines)
MODIFY group/members.php   Rev. 1.17    (+3 -3 lines)
MODIFY user/selector/script.js   Rev. 1.7    (+6 -21 lines)
MODIFY admin/roles/assign.php   Rev. 1.85    (+160 -231 lines)
MODIFY admin/roles/roles.js   Rev. 1.2    (+14 -0 lines)
DEL admin/roles/Attic/assign.html   Rev. 1.37    (+0 -0 lines)
MODIFY user/selector/lib.php   Rev. 1.8    (+268 -26 lines)
Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 31/Oct/08 02:04 PM
MDL-11529 Translated a new string for error message.
MDL-16966 Tarnslated new strings for user selection.
MDL-15352 Translated a new string for remote Moodle repository.
MDL-16993 Translated new strings for role.
MODIFY ja_utf8/moodle.php   Rev. 1.320    (+3 -1 lines)
MODIFY ja_utf8/repository_remotemoodle.php   Rev. 1.7    (+1 -0 lines)
MODIFY ja_utf8/role.php   Rev. 1.75    (+12 -0 lines)
MODIFY ja_utf8/README   Rev. 1.855    (+1 -1 lines)
MODIFY ja_utf8/error.php   Rev. 1.100    (+1 -0 lines)
martignoni committed 1 file to 'Lang CVS' - 16/Nov/08 05:39 AM
MDL-16993 strings added
MODIFY fr_utf8/role.php   Rev. 1.89    (+5 -1 lines)
martignoni committed 2 files to 'Lang CVS' - 16/Nov/08 07:12 PM
MDL-16993 strings added
MODIFY fr_utf8/role.php   Rev. 1.90    (+10 -2 lines)
MODIFY fr_utf8/error.php   Rev. 1.142    (+2 -1 lines)
[ Permalink | « Hide ]
Anthony Borrow added a comment - 08/Apr/09 07:59 AM
Tim - Rather than trying to backport your work for HEAD to 1.9, I'm just committing a simple fix for MDL-16798 to add some continue buttons for Moodle 1.9. I like the changes here much better with the flexibility to pick the next role but I think the simple continue buttons will serve as a functional improvement for usability in 1.9. Really MDL-16798 and MDL-16993 are duplicates (one for 1.9 and one for HEAD). Let me know if you have any concerns with the commits to 1.9. Peace - Anthony

Anthony Borrow made changes - 08/Apr/09 07:59 AM
Link This issue has a non-specific relationship to MDL-16798 [ MDL-16798 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators