[#MDL-16996] Write JavaScript

Issue Details (XML | Word | Printable)

Key:	MDL-16996
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Minor
Assignee:	Tim Hunt
Reporter:	Tim Hunt
Votes:	0
Watchers:	1

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-16966

Write JavaScript

Created: 24/Oct/08 02:39 PM Updated: 03/Nov/08 02:04 PM

Return to search

Component/s:

Administration

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Relates

This issue has been marked as being related by:

MDL-13975 p() and s() should not be used to print lang strings

Participants:	Nicolas Martignoni and Tim Hunt
Security Level:	None
Resolved date:	03/Nov/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

All

Comments

Change History

Version Control

Sort Order:

tjhunt committed 5 files to 'Moodle CVS' - 28/Oct/08 03:51 PM

user selection: ~~MDL-16996~~ Improve the user selector used on the assign roles and group memebers pages - Write the JavaScript to do the Ajax requests and update the list of users.

ADD	user/selector/script.js	Rev. 1.1	(+0 -0 lines)
MODIFY	user/selector/Attic/test.php	Rev. 1.3	(+4 -1 lines)
MODIFY	user/selector/search.php	Rev. 1.2	(+12 -2 lines)
MODIFY	lang/en_utf8/error.php	Rev. 1.135	(+3 -1 lines)
MODIFY	user/selector/lib.php	Rev. 1.3	(+70 -23 lines)

Tim Hunt made changes - 28/Oct/08 03:53 PM

Field	Original Value	New Value
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Mitsuhiro Yoshida committed 5 files to 'Lang CVS' - 29/Oct/08 12:55 AM

~~MDL-16669~~ Translated a new string for debug.
~~MDL-16996~~ Translated new strings for error messages.
MDL-15352 Translated a new string for repository remote Moodle.
~~MDL-16975~~ Translated new strings for xmldb.

MODIFY	ja_utf8/README	Rev. 1.853	(+1 -1 lines)
MODIFY	ja_utf8/xmldb.php	Rev. 1.20	(+12 -3 lines)
MODIFY	ja_utf8/repository_remotemoodle.php	Rev. 1.5	(+1 -0 lines)
MODIFY	ja_utf8/debug.php	Rev. 1.17	(+2 -1 lines)
MODIFY	ja_utf8/error.php	Rev. 1.98	(+3 -1 lines)

[ Permalink | « Hide ]

Nicolas Martignoni added a comment - 02/Nov/08 05:21 AM

Function output_optgroup() in /user/selector/lib.php (around line 429) prints string $groupname using s(), which should be avoided (see MDL-13975).

Nicolas Martignoni made changes - 02/Nov/08 05:21 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Nicolas Martignoni made changes - 02/Nov/08 05:25 AM

Link

This issue has been marked as being related by MDL-13975 [ MDL-13975 ]

tjhunt committed 1 file to 'Moodle CVS' - 03/Nov/08 02:03 PM

user selector: ~~MDL-16996~~- followup - change optgroup label escaping funciton to keep Nicolas Martignoni happy. I can's say I full understand this issue.

MODIFY

user/selector/lib.php

Rev. 1.9

(+3 -3 lines)

[ Permalink | « Hide ]

Tim Hunt added a comment - 03/Nov/08 02:04 PM

OK, I changed it to htmlspecialchars.

Tim Hunt made changes - 03/Nov/08 02:04 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

martignoni committed 1 file to 'Lang CVS' - 16/Nov/08 05:35 AM

~~MDL-16996~~ error strings translated

MODIFY

fr_utf8/error.php

Rev. 1.141

(+3 -1 lines)

All content on this web site is made available under the GNU General Public License, unless otherwise stated.