[#MDL-17014] alfresco plugin requires PHP soap extension which is not required

Issue Details (XML | Word | Printable)

Key:	MDL-17014
Type:	Sub-task
Status:	Resolved
Resolution:	Fixed
Priority:	Blocker
Assignee:	Dongsheng Cai
Reporter:	Petr Skoda
Votes:	0
Watchers:	2

Operations

Add/Edit UI Mockup to this issue

If you were logged in you would be able to see more operations.

Moodle

MDL-13766

alfresco plugin requires PHP soap extension which is not required

Created: 26/Oct/08 01:41 AM Updated: 11/Dec/08 12:20 PM

Return to search

Component/s:

Repository API

Affects Version/s:

2.0

Fix Version/s:

2.0

Issue Links:

Duplicate

This issue is duplicated by:

~~MDL-17021~~ Fatal (alfresco) error upgrading HEAD to 2008101300

Participants:	Dongsheng Cai, Eloy Lafuente (stronk7) and Petr Skoda
Security Level:	None
Resolved date:	11/Dec/08
Affected Branches:	MOODLE_20_STABLE
Fixed Branches:	MOODLE_20_STABLE

All

Comments

Change History

Version Control

Sort Order:

Eloy Lafuente (stronk7) made changes - 27/Oct/08 03:36 AM

Field	Original Value	New Value
Link		This issue is duplicated by ~~MDL-17021~~ [ ~~MDL-17021~~ ]

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 27/Oct/08 03:37 AM

Confirmed. I'm getting:

Fatal error: Class 'SoapClient' not found in /Users/stronk7/cvs_moodle/moodle_head/lib/alfresco/Service/WebService/AlfrescoWebService.php on line 28

And upgrade stops. Assigning to Dongheng as he is the alfresco committer. Ciao

Eloy Lafuente (stronk7) made changes - 27/Oct/08 03:37 AM

Assignee

Martin Dougiamas [ dougiamas ]

Dongsheng Cai [ dongsheng ]

Dongsheng Cai made changes - 27/Oct/08 09:41 AM

Parent		MDL-13766 [ 25249 ]
Issue Type	Bug [ 1 ]	Sub-task [ 5 ]

Dongsheng Cai committed 3 files to 'Moodle CVS' - 27/Oct/08 11:57 AM

"~~MDL-17014~~, check soap extension before create alfresco plugin"

MODIFY	repository/alfresco/repository.class.php	Rev. 1.4	(+30 -16 lines)
MODIFY	lang/en_utf8/repository_alfresco.php	Rev. 1.2	(+2 -1 lines)
MODIFY	repository/lib.php	Rev. 1.135	(+6 -2 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 27/Oct/08 12:04 PM

I added code to check soap extension when initializing alfresco instances, and plugin_init function to check soap when creating new plugin.

However, we still require soap extension when using alfresco plugin, to solve this, we need to replace soap extension with nusoap in alfresco lib, or create a pure php soap lib which has same api with SoapClient, both solutions need a lot of work on it.

Mitsuhiro Yoshida committed 4 files to 'Lang CVS' - 27/Oct/08 03:15 PM

~~MDL-16450~~ Translated new strings for matching questions.
~~MDL-17014~~ Translated a new string for alfresco plugin.
MDL-15352 Translated a new string for remote moodle.

MODIFY	ja_utf8/repository_alfresco.php	Rev. 1.2	(+2 -1 lines)
MODIFY	ja_utf8/README	Rev. 1.851	(+1 -1 lines)
MODIFY	ja_utf8/repository_remotemoodle.php	Rev. 1.4	(+1 -0 lines)
MODIFY	ja_utf8/qtype_match.php	Rev. 1.2	(+5 -3 lines)

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 27/Oct/08 05:23 PM

Haven't we that stuff already in /lib ? It used to be some wrapper library, automatically switching between nusoap / hphsoap and so.

No 100% sure but I remember that vaguely. Ciao

[ Permalink | « Hide ]

Eloy Lafuente (stronk7) added a comment - 27/Oct/08 07:31 PM

Note: I've updated from CVS and... if I go to the "notifications" page... I continue getting:

Fatal error: Class 'SoapClient' not found in /Users/stronk7/cvs_moodle/moodle_head/lib/alfresco/Service/WebService/AlfrescoWebService.php on line 28

Ciao

Dongsheng Cai committed 2 files to 'Moodle CVS' - 28/Oct/08 12:13 PM

"~~MDL-17014~~, check soap extension in alfresco plugin"

MODIFY	repository/lib.php		Rev. 1.136		(+5 -2 lines)
MODIFY	repository/alfresco/repository.class.php		Rev. 1.5		(+7 -5 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 28/Oct/08 12:16 PM

Hi, Eloy, seems that's no way for me to disable soap extension unless I recompile PHP

, so can you help testing again, thanks

I already included nusoap library in alfresco plugin, but the APIs of nuSOAP are different from SoapClient, so it doesn't work.

martignoni committed 1 file to 'Lang CVS' - 16/Nov/08 04:34 AM

~~MDL-17014~~, string translated

MODIFY

fr_utf8/repository_alfresco.php

Rev. 1.2

(+5 -4 lines)

Dongsheng Cai committed 2 files to 'Moodle CVS' - 11/Dec/08 12:19 PM

"~~MDL-17014~~, stop create repository type if plugin_init return false"

MODIFY	repository/alfresco/repository.class.php		Rev. 1.6		(+4 -3 lines)
MODIFY	repository/lib.php		Rev. 1.148		(+9 -8 lines)

[ Permalink | « Hide ]

Dongsheng Cai added a comment - 11/Dec/08 12:20 PM

Please review, feel free to reopen it.
Thanks

Dongsheng Cai made changes - 11/Dec/08 12:20 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

All content on this web site is made available under the GNU General Public License, unless otherwise stated.