Moodle

block instance config page shows duplicated form on blocks admin page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.9.2
  • Fix Version/s: None
  • Component/s: Administration, Blocks
  • Labels:
    None
  • Environment:
    Tested on Ubuntu gutsy, Linux kernel 2.6.28, MySQL 5.0.45, Apache 2.2.4, PHP 5.2.3.
  • Affected Branches:
    MOODLE_19_STABLE

Description

The edit form appears duplicated when trying to configurate a block located on the blocks admin page.

Steps to reproduce:
1. Go to blocks admin page
2. Add a block whose instance is configurable
3. Edit block configuration

Patch included: just replace "admin_externalpage_print_footer()" for "print_footer()" in /admin/blocks.php by the end of file.

Activity

Hide
Eloy Lafuente (stronk7) added a comment -

Hi Renato,

does this happen with any configurable block or only with some?

I've tried to reproduce it here and I only get one config form (nothing seems to be duplicated).

Any idea? Using Moodle 1.9.3+ here.

Ciao

P.S: The call to externalpage_print_footer() seems to be the correct in those pages, because it needs to close "more things" like the standard print_footer() one.

Show
Eloy Lafuente (stronk7) added a comment - Hi Renato, does this happen with any configurable block or only with some? I've tried to reproduce it here and I only get one config form (nothing seems to be duplicated). Any idea? Using Moodle 1.9.3+ here. Ciao P.S: The call to externalpage_print_footer() seems to be the correct in those pages, because it needs to close "more things" like the standard print_footer() one.
Hide
Renato Coutinho added a comment -

Hi Eloy,

I first ran into the issue trying to code my own block, then I tested with the remote RSS feeds block (it has to have instance_allow_config). I'm using moodle 1.9.2+ build 20080917. The block must be located at the blocks admin page (/admin/blocks.php) for this to happen.

I figured it was about the print_footer() / externalpage_print_footer() because I tracked down the problem to the blocks_setup() being called twice, on admin_externalpage_print_header() and on admin_externalpage_print_footer(). Maybe there's some better way to avoid that.

Tchau

Show
Renato Coutinho added a comment - Hi Eloy, I first ran into the issue trying to code my own block, then I tested with the remote RSS feeds block (it has to have instance_allow_config). I'm using moodle 1.9.2+ build 20080917. The block must be located at the blocks admin page (/admin/blocks.php) for this to happen. I figured it was about the print_footer() / externalpage_print_footer() because I tracked down the problem to the blocks_setup() being called twice, on admin_externalpage_print_header() and on admin_externalpage_print_footer(). Maybe there's some better way to avoid that. Tchau
Hide
James Ballard added a comment -

This seems to be affecting all configurable blocks still (Moodle 1.9.4 and 2.0)

For example when configuring a HTML or RSS block on a Course Category page there are multiple editors displayed. In 2.0 there are 2 editors and in 1.9 there are 3.

Show
James Ballard added a comment - This seems to be affecting all configurable blocks still (Moodle 1.9.4 and 2.0) For example when configuring a HTML or RSS block on a Course Category page there are multiple editors displayed. In 2.0 there are 2 editors and in 1.9 there are 3.
Hide
Michael de Raadt added a comment -

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

Show
Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
Hide
Michael de Raadt added a comment -

I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Show
Michael de Raadt added a comment - I'm closing this issue as it appears to have become inactive and is probably not relevant to a current supported version. If you are encountering this problem or one similar, please launch a new issue.

Dates

  • Created:
    Updated:
    Resolved: