Issue Details (XML | Word | Printable)

Key: MDL-17023
Type: Bug Bug
Status: Open Open
Priority: Minor Minor
Assignee: Eloy Lafuente (stronk7)
Reporter: Renato Coutinho
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

block instance config page shows duplicated form on blocks admin page

Created: 27/Oct/08 03:37 AM   Updated: 19/May/09 07:28 PM
Component/s: Administration, Blocks
Affects Version/s: 1.9.2
Fix Version/s: None

File Attachments: 1. Text File admineditblocks.patch (0.2 kB)

Environment: Tested on Ubuntu gutsy, Linux kernel 2.6.28, MySQL 5.0.45, Apache 2.2.4, PHP 5.2.3.

Participants: Eloy Lafuente (stronk7), James Ballard and Renato Coutinho
Security Level: None
Affected Branches: MOODLE_19_STABLE


 Description  « Hide
The edit form appears duplicated when trying to configurate a block located on the blocks admin page.

Steps to reproduce:
1. Go to blocks admin page
2. Add a block whose instance is configurable
3. Edit block configuration

Patch included: just replace "admin_externalpage_print_footer()" for "print_footer()" in /admin/blocks.php by the end of file.



 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Eloy Lafuente (stronk7) added a comment - 02/Nov/08 08:12 PM
Hi Renato,

does this happen with any configurable block or only with some?

I've tried to reproduce it here and I only get one config form (nothing seems to be duplicated).

Any idea? Using Moodle 1.9.3+ here.

Ciao

P.S: The call to externalpage_print_footer() seems to be the correct in those pages, because it needs to close "more things" like the standard print_footer() one.


Renato Coutinho added a comment - 02/Nov/08 09:39 PM
Hi Eloy,

I first ran into the issue trying to code my own block, then I tested with the remote RSS feeds block (it has to have instance_allow_config). I'm using moodle 1.9.2+ build 20080917. The block must be located at the blocks admin page (/admin/blocks.php) for this to happen.

I figured it was about the print_footer() / externalpage_print_footer() because I tracked down the problem to the blocks_setup() being called twice, on admin_externalpage_print_header() and on admin_externalpage_print_footer(). Maybe there's some better way to avoid that.

Tchau


James Ballard added a comment - 19/May/09 07:28 PM
This seems to be affecting all configurable blocks still (Moodle 1.9.4 and 2.0)

For example when configuring a HTML or RSS block on a Course Category page there are multiple editors displayed. In 2.0 there are 2 editors and in 1.9 there are 3.