Moodle

misleading mtrace call in cron.php

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.8.7, 1.9.3, 2.0
  • Fix Version/s: 1.8.8, 1.9.4, 2.0
  • Component/s: Enrolments
  • Labels:
    None
  • Affected Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

Description

in cron.php the call:
mtrace("Deleted assignment for user $assign->userid from course $assign->courseid");

is misleading it sounds like it is referring to the assignment module, when it is actually a "role assignment" we should change it to something like::
mtrace("Deleted role assignment for user $assign->userid from course $assign->courseid");

Activity

Hide
Dan Marsden added a comment -

In fact I like this better:

removing user $assign->userid from course $assign->courseid as they have not accessed the course for over $CFG->longtimenosee days

Show
Dan Marsden added a comment - In fact I like this better: removing user $assign->userid from course $assign->courseid as they have not accessed the course for over $CFG->longtimenosee days
Hide
Martin Dougiamas added a comment -

hell yes +1

Show
Martin Dougiamas added a comment - hell yes +1
Hide
Dan Marsden added a comment -

fix now in 1.8Stable, 1.9Stable and HEAD

Show
Dan Marsden added a comment - fix now in 1.8Stable, 1.9Stable and HEAD
Hide
Petr Škoda (skodak) added a comment -

reviewed, closing - thanks

Show
Petr Škoda (skodak) added a comment - reviewed, closing - thanks

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: