Issue Details (XML | Word | Printable)

Key: MDL-17071
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Dan Marsden
Reporter: Dan Marsden
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Moodle

misleading mtrace call in cron.php

Created: 30/Oct/08 06:55 PM   Updated: 11/Nov/08 03:52 PM
Component/s: Enrolments
Affects Version/s: 1.8.7, 1.9.3, 2.0
Fix Version/s: 1.8.8, 1.9.4, 2.0

Participants: Dan Marsden, Martin Dougiamas and Petr Škoda
Security Level: None
QA Assignee: Petr Škoda


 Description  « Hide
in cron.php the call:
mtrace("Deleted assignment for user $assign->userid from course $assign->courseid");

is misleading it sounds like it is referring to the assignment module, when it is actually a "role assignment" we should change it to something like::
mtrace("Deleted role assignment for user $assign->userid from course $assign->courseid");

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
Dan Marsden added a comment - 30/Oct/08 07:08 PM
In fact I like this better:

removing user $assign->userid from course $assign->courseid as they have not accessed the course for over $CFG->longtimenosee days

Martin Dougiamas added a comment - 05/Nov/08 04:05 PM
hell yes +1

Dan Marsden added a comment - 05/Nov/08 04:17 PM
fix now in 1.8Stable, 1.9Stable and HEAD :-)

Petr Škoda added a comment - 11/Nov/08 03:52 PM
reviewed, closing - thanks