[#MDL-17094] Allow translators to disable automatic language update during Moodle upgrade

Issue Details (XML | Word | Printable)

Key:	MDL-17094
Type:	Improvement
Status:	Closed
Resolution:	Fixed
Priority:	Minor
Assignee:	David Mudrak
Reporter:	David Mudrak
Votes:	0
Watchers:	3

Operations

If you were logged in you would be able to see more operations.

Moodle

Allow translators to disable automatic language update during Moodle upgrade

Created: 01/Nov/08 05:31 AM Updated: 05/Nov/08 08:40 AM

Component/s:

Languages

Affects Version/s:

1.9.3

Fix Version/s:

1.9.4, 2.0

File Attachments:

MDL-17094-2.patch.txt (2 kB)
2.

MDL-17094.patch.txt (2 kB)

Issue Links:

Relates

This issue has been marked as being related by:

~~MDL-8330~~ TTW language updater removes language CVS checkout and thus local modification

Participants:	David Mudrak and Petr Škoda
Security Level:	None
QA Assignee:	Petr Škoda

Description

« Hide

Before Moodle upgrade, the current language pack is automatically updated from download.moodle.org. For translators working with CVS, this replaces their CVS checkouts by the "static" pack from moodle.org :-(
This is a proposal to introduce new $CFG settings that disables automatic language update and let translators (lang pack maintainers) to keep their moodledata/lang/* up-to-date manually (as they do as CVS maintainers).

All

Comments

Change History

Version Control

Sort Order:

[ Permlink | « Hide ]

David Mudrak added a comment - 01/Nov/08 05:42 AM

The patch implements this. It simply hides the note and disables the update of the lang pack.

[ Permlink | « Hide ]

David Mudrak added a comment - 01/Nov/08 05:43 AM

QA to skodak, waiting for +1 before commit

[ Permlink | « Hide ]

Petr Škoda added a comment - 01/Nov/08 05:48 AM

+1 without the ~~MDL-17094~~ in comment, devs can use cvs history to find the reason for commits

[ Permlink | « Hide ]

David Mudrak added a comment - 01/Nov/08 06:17 AM

Fixed in MOODLE_19_STABLE admin/index.php and HEAD lib/adminlib.php.

I have moved MOODLE_19_MERGED from 1.286.2.23 to 1.286.2.24 too. But as the change had to be applied on a different file (lib/adminlib.php instead of admin/index.php), I did not really merge anything into HEAD admin/index.php. Is this correct procedure?

[ Permlink | « Hide ]

Petr Škoda added a comment - 01/Nov/08 07:44 PM

hmm, could you please disable the lang update UI too if this option added

[ Permlink | « Hide ]

David Mudrak added a comment - 01/Nov/08 10:47 PM

The second patch disables admin/langimport.php as well. Please approve how the warning reads and whether to introduce new string at all or keep the warning in English here.

[ Permlink | « Hide ]

Petr Škoda added a comment - 02/Nov/08 02:08 AM

+1 for commit, thanks

[ Permlink | « Hide ]

David Mudrak added a comment - 02/Nov/08 04:37 AM

Fixed in CVS, thanks for the help.

[ Permlink | « Hide ]

Petr Škoda added a comment - 05/Nov/08 08:40 AM

thanks