Moodle

Allow translators to disable automatic language update during Moodle upgrade

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.3
  • Fix Version/s: 1.9.4, 2.0
  • Component/s: Language
  • Labels:
    None
  • Affected Branches:
    MOODLE_19_STABLE
  • Fixed Branches:
    MOODLE_19_STABLE, MOODLE_20_STABLE

Description

Before Moodle upgrade, the current language pack is automatically updated from download.moodle.org. For translators working with CVS, this replaces their CVS checkouts by the "static" pack from moodle.org
This is a proposal to introduce new $CFG settings that disables automatic language update and let translators (lang pack maintainers) to keep their moodledata/lang/* up-to-date manually (as they do as CVS maintainers).

Issue Links

This issue has been marked as being related by:
MDL-8330 TTW language updater removes language CVS checkout and thus local modification Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Mudrak added a comment -

The patch implements this. It simply hides the note and disables the update of the lang pack.

Show
David Mudrak added a comment - The patch implements this. It simply hides the note and disables the update of the lang pack.
Hide
Permalink
David Mudrak added a comment -

QA to skodak, waiting for +1 before commit

Show
David Mudrak added a comment - QA to skodak, waiting for +1 before commit
Hide
Permalink
Petr Škoda (skodak) added a comment -

+1 without the MDL-17094 in comment, devs can use cvs history to find the reason for commits

Show
Petr Škoda (skodak) added a comment - +1 without the MDL-17094 in comment, devs can use cvs history to find the reason for commits
Hide
Permalink
David Mudrak added a comment -

Fixed in MOODLE_19_STABLE admin/index.php and HEAD lib/adminlib.php.

I have moved MOODLE_19_MERGED from 1.286.2.23 to 1.286.2.24 too. But as the change had to be applied on a different file (lib/adminlib.php instead of admin/index.php), I did not really merge anything into HEAD admin/index.php. Is this correct procedure?

Show
David Mudrak added a comment - Fixed in MOODLE_19_STABLE admin/index.php and HEAD lib/adminlib.php. I have moved MOODLE_19_MERGED from 1.286.2.23 to 1.286.2.24 too. But as the change had to be applied on a different file (lib/adminlib.php instead of admin/index.php), I did not really merge anything into HEAD admin/index.php. Is this correct procedure?
Hide
Permalink
Petr Škoda (skodak) added a comment -

hmm, could you please disable the lang update UI too if this option added

Show
Petr Škoda (skodak) added a comment - hmm, could you please disable the lang update UI too if this option added
Hide
Permalink
David Mudrak added a comment -

The second patch disables admin/langimport.php as well. Please approve how the warning reads and whether to introduce new string at all or keep the warning in English here.

Show
David Mudrak added a comment - The second patch disables admin/langimport.php as well. Please approve how the warning reads and whether to introduce new string at all or keep the warning in English here.
Hide
Permalink
Petr Škoda (skodak) added a comment -

+1 for commit, thanks

Show
Petr Škoda (skodak) added a comment - +1 for commit, thanks
Hide
Permalink
David Mudrak added a comment -

Fixed in CVS, thanks for the help.

Show
David Mudrak added a comment - Fixed in CVS, thanks for the help.
Hide
Permalink
Petr Škoda (skodak) added a comment -

thanks

Show
Petr Škoda (skodak) added a comment - thanks

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.