Issue Details (XML | Word | Printable)

Key: MDL-17094
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: David Mudrak
Reporter: David Mudrak
Votes: 0
Watchers: 3
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Moodle

Allow translators to disable automatic language update during Moodle upgrade

Created: 01/Nov/08 05:31 AM   Updated: 05/Nov/08 08:40 AM
Return to search
Component/s: Languages
Affects Version/s: 1.9.3
Fix Version/s: 1.9.4, 2.0

File Attachments: 1. Text File MDL-17094-2.patch.txt (2 kB)
2. Text File MDL-17094.patch.txt (2 kB)
Issue Links:
Relates
 

Participants: David Mudrak and Petr Skoda
Security Level: None
QA Assignee: Petr Skoda
Resolved date: 02/Nov/08
Affected Branches: MOODLE_19_STABLE
Fixed Branches: MOODLE_19_STABLE, MOODLE_20_STABLE


 Description  « Hide
Before Moodle upgrade, the current language pack is automatically updated from download.moodle.org. For translators working with CVS, this replaces their CVS checkouts by the "static" pack from moodle.org :-(
This is a proposal to introduce new $CFG settings that disables automatic language update and let translators (lang pack maintainers) to keep their moodledata/lang/* up-to-date manually (as they do as CVS maintainers).

 All   Comments   Change History   Version Control      Sort Order: Ascending order - Click to sort in descending order
David Mudrak made changes - 01/Nov/08 05:33 AM
Field Original Value New Value
Link This issue has been marked as being related by MDL-8330 [ MDL-8330 ]
[ Permalink | « Hide ]
David Mudrak added a comment - 01/Nov/08 05:42 AM
The patch implements this. It simply hides the note and disables the update of the lang pack.

David Mudrak made changes - 01/Nov/08 05:42 AM
Attachment MDL-17094.patch.txt [ 15535 ]
[ Permalink | « Hide ]
David Mudrak added a comment - 01/Nov/08 05:43 AM
QA to skodak, waiting for +1 before commit

David Mudrak made changes - 01/Nov/08 05:43 AM
QA Assignee skodak
[ Permalink | « Hide ]
Petr Skoda added a comment - 01/Nov/08 05:48 AM
+1 without the MDL-17094 in comment, devs can use cvs history to find the reason for commits

David Mudrak committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 01/Nov/08 06:01 AM
MDL-17094 Allow translators to disable automatic language update during Moodle upgrade.

One needs just add $CFG->skiplangupgrade = true; to their config.php and keep their language pack up-to-date manually. This is intended for lang pack maintainers with CVS access only.
MODIFY admin/index.php   Rev. 1.286.2.24    (+14 -8 lines)
David Mudrak committed 1 file to 'Moodle CVS' - 01/Nov/08 06:11 AM
MDL-17094 Allow translators to disable automatic language update during Moodle upgrade.

One needs just add $CFG->skiplangupgrade = true; to their config.php and keep their language pack up-to-date manually. This is intended for lang pack maintainers with CVS access only.

This is backpported from MOODLE_19_STABLE admin/index.php
MODIFY lib/adminlib.php   Rev. 1.282    (+14 -8 lines)
[ Permalink | « Hide ]
David Mudrak added a comment - 01/Nov/08 06:17 AM
Fixed in MOODLE_19_STABLE admin/index.php and HEAD lib/adminlib.php.

I have moved MOODLE_19_MERGED from 1.286.2.23 to 1.286.2.24 too. But as the change had to be applied on a different file (lib/adminlib.php instead of admin/index.php), I did not really merge anything into HEAD admin/index.php. Is this correct procedure?


David Mudrak made changes - 01/Nov/08 06:17 AM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 01/Nov/08 07:44 PM
hmm, could you please disable the lang update UI too if this option added

Petr Skoda made changes - 01/Nov/08 07:44 PM
Status Resolved [ 5 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
David Mudrak added a comment - 01/Nov/08 10:47 PM
The second patch disables admin/langimport.php as well. Please approve how the warning reads and whether to introduce new string at all or keep the warning in English here.

David Mudrak made changes - 01/Nov/08 10:47 PM
Attachment MDL-17094-2.patch.txt [ 15539 ]
[ Permalink | « Hide ]
Petr Skoda added a comment - 02/Nov/08 02:08 AM
+1 for commit, thanks

David Mudrak committed 2 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 02/Nov/08 04:30 AM
MDL-17094 Automatic language update can be disabled via $CFG->skiplangupgrade settings.
MODIFY admin/langimport.php   Rev. 1.36.2.9    (+8 -1 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.154.2.62    (+1 -0 lines)
David Mudrak committed 2 files to 'Moodle CVS' - 02/Nov/08 04:35 AM
MDL-17094 Automatic language update can be disabled via $CFG->skiplangupgrade settings. Merged from MOODLE_19_STABLE
MODIFY admin/langimport.php   Rev. 1.46    (+8 -1 lines)
MODIFY lang/en_utf8/admin.php   Rev. 1.236    (+1 -0 lines)
[ Permalink | « Hide ]
David Mudrak added a comment - 02/Nov/08 04:37 AM
Fixed in CVS, thanks for the help.

David Mudrak made changes - 02/Nov/08 04:37 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
martignoni committed 1 file to 'Lang CVS' - 02/Nov/08 04:48 AM
MDL-17094, string added
MODIFY fr_utf8/admin.php   Rev. 1.311    (+2 -1 lines)
Mitsuhiro Yoshida committed 1 file to 'Lang CVS' - 02/Nov/08 11:07 AM
MDL-17094 Translated a new string for $CFG->skiplangupgrade.
MODIFY ja_utf8/admin.php   Rev. 1.312    (+1 -0 lines)
[ Permalink | « Hide ]
Petr Skoda added a comment - 05/Nov/08 08:40 AM
thanks

Petr Skoda made changes - 05/Nov/08 08:40 AM
Status Resolved [ 5 ] Closed [ 6 ]

Powered by a free Atlassian JIRA open source license for Moodle. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators