Moodle

The core of the issue I think is the assumption, that $element part of the rule is always an element, while in 'compare' rule it must be an array. This will be pretty easy to fix. Could you please fix it because now it's a sort of blocker for repeat_elements improvement.

There is a very rough fix: you must replace
$onBlur = $element->getAttribute('onBlur');
$onChange = $element->getAttribute('onChange');
$element->updateAttributes(array('onBlur' => $onBlur . $valFunc,
'onChange' => $onChange . $valFunc));
with
if(is_array($element)){ $onBlur = $element[0]->getAttribute('onBlur'); $onChange = $element[0]->getAttribute('onChange'); $element[0]->updateAttributes(array('onBlur' => $onBlur . $valFunc, 'onChange' => $onChange . $valFunc)); }else{ $onBlur = $element->getAttribute('onBlur'); $onChange = $element->getAttribute('onChange'); $element->updateAttributes(array('onBlur' => $onBlur . $valFunc, 'onChange' => $onChange . $valFunc)); }

This doesn't really solves problem as first element may be hidden (than we must use the second), and if validation fails then error message isn't displayed, but at least there is no Fatal Errors and validation seems to work.

Hi Oleg,

What about just adding a select drop down box to select how many blanks to add to the form?

Jamie

First of all I think that ability to clearly see the number of blanks and enter it is far better that to search for the current number of blanks and calculate how many there is need to add. I can't see any advantage of selection number for adding on selection number of blanks. This doesn't exclude dropdowns by itself.

I tried dropdown box, but drop it because it's not highly usable (and accessible too - see Pierre's comment) with long list of numbers: I can get two digits number in text field by pressing two buttons - how many buttons I must press (or how much must I scroll down) to get any two-digits number in dropdown? On Internet Explorer (widely used by staff of our University) - too many.

Dropdowns are good when you have 3-7 choices. WIth more than 10 choices it's not very usable. Pity we doesn't have spinbox control in HTTP Forms, it's very good for entering numbers.

P.S. There isn't even a note in documentation that 'compare' rules doesn't supported by Moodle forms, just link to PEAR site with all types of rules.

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

I temporarely have no means to re-test it, but as far as I know there were no serious rework of forms library in Moodle 2.x versions so the bug is likely to persist.