|
Dan Marsden committed 1 file to 'Moodle CVS' - 28/Nov/08 03:49 PM
Dan Marsden committed 1 file to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 28/Nov/08 03:49 PM
Dan Marsden committed 1 file to 'Moodle CVS' on branch 'MOODLE_18_STABLE' - 28/Nov/08 03:50 PM
Hi Ron,
thanks for the feedback! - yeah I think there's a range of ways we can verify that the API has been loaded before calling scorm in a much more efficient manner than just waiting a set number of seconds (which is ugly/cumbersome/ and needs to be fixed!) - I'm hoping Piers will get a chance to look at this in the next couple of weeks or so. I've added Tim to this bug as he's been doing a lot of optimisation on JS in Moodle recently - Tim I can't remember if there was any discussion on compressing the js? - have you looked at how we might manage this in CVS at all? There was some discussion, but nothing done yet.
My preferred solution is mangle JS as part of install/upgrade, so we keep uncompressed JS in CVS - and have a way to turn it off, so developers working on JS are not inconvenienced. However, a prerequisite to anything like that is getting all JS into external .js files, and including it all with require_js. The existing require_js API is nice and simple for developers, and yet gives us all the flexibility we need to manage which actual file is included behind the scenes when a developer asks up to include a certain bit of JS, for example switching in a compressed file. However, there is first a big job going through the code and making everything use require_js.
Piers Harding committed 1 file to 'Moodle CVS' - 05/Dec/08 12:19 PM
Piers Harding committed 3 files to 'Moodle CVS' on branch 'MOODLE_19_STABLE' - 08/Dec/08 07:15 AM
Piers Harding committed 2 files to 'Moodle CVS' - 08/Dec/08 07:22 AM
Piers has just pushed a fix into 1.9Stable and HEAD that checks if the API has loaded and redirects much quicker! - improves the user experience a lot! - thanks Piers
Ron - as Tim mentions, the JS is getting a really good tidy up in HEAD - Thanks for your comments Tim!
Dan Marsden made changes - 08/Dec/08 07:25 AM
Petr Skoda committed 1 file to 'Moodle CVS' - 10/Dec/08 08:52 AM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Another suggestion, is to change the player and api so that the api is completely loaded prior to loading the SCORM TOC and module. This can be accomplished by separating the creating of these components into individual functions and adding code to the end of the api that triggers the loading of the SCORM TOC and module. This will guarantee that the api is loaded prior to the course looking for it.